From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2041.outbound.protection.outlook.com [40.107.115.41]) by sourceware.org (Postfix) with ESMTPS id 38C0B3858C54 for ; Tue, 17 Oct 2023 19:38:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38C0B3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38C0B3858C54 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.41 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697571510; cv=pass; b=R+iGeyWZohGxo0HdrlMbfuDBhdc+Ba4IxbN+pzGzWRrDNQWRUBnvk9r/DsFTx6ID5yFQ+0vLfT1r1fhs6LUdWWIaak4b11meJwo7mLYnpY7GOcsMIAu6nUP5FZ9K+vJy0vKtwRNbgkI5aUpHlQ9qWKsfVzPh9isCGJ/LBW5PoW8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697571510; c=relaxed/simple; bh=jktXTHX6HIziVP2vEt+NB9HDYAZnjLF5/SwlwbkY5Fg=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=MM4ZKEw8bm7U/loUqiA/+xKP/dAH90LWm4pzfBrKyqLgilNPRppRMdejLfOTIxQpZZbVrvUNBDvkbBHR8gN6dhjpXCceARpVcJVsdvCslGHYaZUjQqHN9gd6OjgqOnywiwbJUMPtAld44qdvBNZ94DfF8V/zPLXGQo14wyrZmBM= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EFHVy4Xdyxznpyn4srugWNGKqfTplzRwUHto4tiEnSoVyFHJ0d4LLjawj/QdWjXYRCFbH6zH4738pqJhs/Al+IhFgmN3Pr7+Yjo1XVhpnGl2f3DY7OsVCkPBhFOpgIxDH6t/aGsiC/cdodlLWPMVIpY1qD156qNPLaFa7J2G7V8sO1oKtR88vHngYEGKrTXlV+JU+k3w3PBxFW/wHPmoJQs+Oamd1cVpzflEjYTw+EJCJWEFEpf4Clmq8NcBaCgsp1rNJULYNTX4cCZZWvAXYKDRgxxWt5Vlv79U3Y0QHOGjXQX+F0BKKCQhEvCo1Gdj3y1pqZfR43AEy+DjtYN/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T/Gyv0UV37Pm1hoD7VuIdWuF58+g+Ob9l0isfloeduE=; b=AwEj+r0ivbsIHXuzGCxkyEepN9vn96S7tYvC2WyvbBP2camwkhMisJ6wq0rk3PwhG+Y3+s8WAwmo7s9O7BDQEJztJo5o+0j/KozenDdRRNYKTdV37EMrdRbzG/XInv4qpZq9/wqOu94mleMeXS64P1ngxY1CdDgjPtIh3NmYhNjlfTH5Bj+n6uN42M5wXMEdF2STcL8MKzhuRaHu0hFPET+4awpdPG9t7o3bPLGn4sjRxXLzsw+slzNx4mAR+lZNB6ZKhWWIHfdvwzthMAkrBlPm6GVit8fOMBu7eSMVvB2BjDXT7Lv1XZItSSMuxelQOEUEyu2RtQ+B6RrL3yJu9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/Gyv0UV37Pm1hoD7VuIdWuF58+g+Ob9l0isfloeduE=; b=UWsfhWCpuuU/H/R/wQ0Pz5hI867iUhSxzjqYoEx+xbD53QDYNxe5WfEYKHEOjFLBwUdg1ZjABTPggTzV975erGZ2SKrBli93Xz8pSxC/nBHpa2wwxsPMeXMzjb4zhP8JVAP3MwvEcICJAwy6mvnAULXUEjWSytBc/r+z7+gOAg6Z3xcO0BOqW8xL2fTm+hJeOPr7JOGzNFAmw/EQIgQK2F9PylilZmP0ScrlAWXmQNpMyFlQ/U3/oJh3u5lda71m8RiUImo8cU93jUTW9N41cQJn1/lBhP/FBj7pSva09NG7EbbSk0QQHcCbJBq02EiyXG+srnHq4VSrGWDvnQz9ig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB6357.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:74::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.21; Tue, 17 Oct 2023 19:38:27 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%7]) with mapi id 15.20.6907.021; Tue, 17 Oct 2023 19:38:27 +0000 Message-ID: Date: Tue, 17 Oct 2023 15:38:25 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21/24] gdb: link so_list using intrusive_list Content-Language: fr To: Pedro Alves , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-22-simon.marchi@efficios.com> <708a1d8c-ab07-4e38-a352-1b58a6e189e4@palves.net> From: Simon Marchi In-Reply-To: <708a1d8c-ab07-4e38-a352-1b58a6e189e4@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0264.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:68::11) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB6357:EE_ X-MS-Office365-Filtering-Correlation-Id: 984431b1-b0d1-4cd6-5054-08dbcf48a252 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uQKvYygqgx98IJk7isonWXFItXJN1KriMSJZT9s/knocZZkdW4MSUpAGe9Cyzf8RlEP7F7TxJ9lVJRH6Fzm9Jg+8qFV4YDZTFh5FRtgKZrkbJX1ZuDFvlzYOMGE+ma+kQcFJLFZg8vT/lgENEQ3KIzuS9zTYG8+yxMNLdFOxLWCvCu0HXAZ1N5euhN5cWUC+KgLnX42ixhFc5luS88sKiWiQ9UoFuIuAQ0VARg7rNiT6HFXrBVXg96tfuXm3iHV4O/13WRjdmQfo4iKVexBGlDrXy127elCGkwJfyuYFwUxaPmgsP21gsLuE63P6/hRj5ZZiM+9u4Nr2IVF2SuLM2qLJjQKZVT7qRLKPX72x8ZYACCdF0S+Yw56o15M2lUAQ8/I3bFLNfgs/1//2Vm+5y3gbJGrRgzgWx75JdOvUiMqwgrmgrRbc5BX9INhuKEPlWrpqHfudFL+mq6Kps92F5v8kELVwN4LFkGVhEbyJSG0wiw5K0DQ37phyBMGVoJ5jIEGJNUjGlzLefU1w771VxKLLoHG1l2Rg9PUJ5kjrqokflLY9usgbvbvJqZqJ8jXepsldcK1/M+QxqHDiaca50SbRRi/671o9/9db45eFhIvZ8JK9EUj5hwDCAJXKfRSHRpqI1waC2G2rmtXySvfD6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(366004)(376002)(39830400003)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(316002)(6486002)(66556008)(66476007)(66946007)(2616005)(26005)(83380400001)(38100700002)(31696002)(36756003)(478600001)(53546011)(6506007)(31686004)(2906002)(4744005)(4001150100001)(41300700001)(6512007)(5660300002)(44832011)(8676002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXlhRzFqbzdLQjBZZXAwNFN3MDVRdHdBVncwNjR4K2pRZTlBN2FLWTZmZnJl?= =?utf-8?B?M3ZOWjlrNUlMYW5oSjAzTVlOL2ErQS9YdjY3S3VwK1pxdGVSU2trblFvNUZX?= =?utf-8?B?ZnZJS01rTHQ2V2NqMHRPbVNZUDFoK0VRSldYWXMyQWlkUFV6Q0VOUXhxS1pO?= =?utf-8?B?ejNDaVFQWk8zMmZjdW5lbmJZb1lkRnNTMzhmWTdDa3hXZlZNY0c4Qkp0U0Fr?= =?utf-8?B?UCs5aEVWUFBUN1ZSOU4vN3hLbiswNkc1Y1dsRDlEUksxRmJiWkViS2RROW1r?= =?utf-8?B?bEQzTk1rZncrQk5jLzJ2QmRHakt5eVVmRUJXbEhnY0pvNlY1WDh3WWs1UXRL?= =?utf-8?B?K2lXRjkxWEcwREdpUXZSekNsVUpFYVZvenBzVjBpUGpSQklMV0RERTRYOVV4?= =?utf-8?B?ZElZODJGWWRONTE2L1lVN3FzeEJaR3YySzcwbU5qTDlsckI4Q2hMWEgwdFJv?= =?utf-8?B?QkxzTDVXdXdJWnk1NG03Tm5XOFNROUZ1NUNRZVhSNGk2QmIxWFhaZ0ZuZnNK?= =?utf-8?B?bVJsL3gyOTNEeFpTUVRMR1BURlhhNHhXOUV6YU1VRCtUbWl1VWNrbGJRWHls?= =?utf-8?B?TXRtKy9EUVljQVluU2x2cmhqdlc2V2Rqb0pWWUd5UmVFcll4Nnd4Q0U5VnRB?= =?utf-8?B?YlRhUzdwSkdXSEtmc2dqdk9QUHZRSjEyZGFBbmVhS2JUTThZNUp5QWdXME80?= =?utf-8?B?N2U5aGxhRXprcXBWOFFWWUdLT0ViUVE2VjRvRmIvQTlkR0c3UUlEYmdVR2Yw?= =?utf-8?B?OFd5SCt1WHdCSTVvUy8wZmNVZGhDbEQyV20wS2ZrcWFFQmcrT3JzYVZ3d3Nk?= =?utf-8?B?a0VCZkVlQUQyWmF0YzkzbmFzM0d0am9GVkZHSFFXRWFNdU1MN0d2RVpCRzFp?= =?utf-8?B?MWNNeng3azU4QUQ1aWptTEQvdjRwRWt5eU1zYzJqVnpJQWhyRlp3S3ZEeEQ4?= =?utf-8?B?SmJDSmpCbTNWYjloQkcrWkVMK1JHbnpJNmp2RGt6OFRzY0xEWE00a2ZJaG92?= =?utf-8?B?WUNlVTRLUjlhZEpxbVlEbFJLMm54RW9lQVlnUyt0eUl5cDRZeWROYnFheEd6?= =?utf-8?B?ZWZleW1rVWQ4MTJTT04yUmdxcG5jS0xkaW5rUXVHSUhzUk0vbFMyTGFIUXJ5?= =?utf-8?B?RmhMTXNab25ON2tmZWNudzZKZmNPdDZVVWxTbVlNRzJEYmUrUUxXbkU0T2ZY?= =?utf-8?B?L0h1cGFQaHFiUmpSa3RGWTZJOUluTDBmS1E2dnJaVE03dGtwdkcxSHQ5VjFh?= =?utf-8?B?OVNlZ2RSNWdleVFyampvR0NzMytFSlRNZ0JJUmdyYzhyaSs4d3BzeWRYS01q?= =?utf-8?B?Y0FPenlDcWROb1JpTU1NNmZXaW1zMWUzbVdWUE5CVW8yUFd3WS8rNTNvc3pY?= =?utf-8?B?eGJxdTdFTXd3VmJsaFNaazEvWDZsQ0w2bWNSZElrUXVtTDc3RXY1L3BxVFJ0?= =?utf-8?B?RDFlRHQra0NwVG9VVVphQjVxbTlzYTFlOFV0ZEo4dDB2cDJZVUk0cG1Lc3Ns?= =?utf-8?B?YlJoVGs4ekp6VUliY3VkMCt5WHdhRC9HR2lFbHpadzlHN2pCdmNncWROTzdV?= =?utf-8?B?Z09vV0xKZ1liVk5GTml5MU92SHZMZzRPVzJveVM4WWc4NjVJNzVQMXpIM05V?= =?utf-8?B?Qi8rTitMZVE4enR5bWplT2REZHp2WHFTejRYNjlyRFJqNjlLOElEMWlvb0pN?= =?utf-8?B?NlhTTE5EUTRISXg5U2pRNFBVc1FLR3R4dFBMajVnVzBLemd2V0NGNk1VNnov?= =?utf-8?B?K3FUdDR4d2FoQVRBKzZsWkRHZXRIZmRpRDAvdGVsV2VlbGZoaXY2bXozRkVE?= =?utf-8?B?WFlvQkp1Z0hYL2pXOEdlTzZIZDY0Y2lLTHNseFJFVWVuQUEralV2V016QkJW?= =?utf-8?B?M1QrbG5ISXhna1QwQmxGUzNHNjZxNmRSb1BJeDNKa0NCdElKaEdnaU5mbUpB?= =?utf-8?B?cldTbUt2OEVUUHNGMi9GRTY3NkN4RUpBakkwc285eWIxeFk5ZGJ3R3RlMXkw?= =?utf-8?B?U2NSMzEvV0l6SmczaWFpVlVaOXpjZHBkamk2cktCM2U0ZTJTenRmMnZpZ2FC?= =?utf-8?B?YTVCNlA2bGZINW1oajNrT01vVWhRMksrR0t6NWREb1o0MC9Qa2pZZDl5ZXNz?= =?utf-8?Q?ewceZKxtONKfHO9oAPl2LzM1a?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 984431b1-b0d1-4cd6-5054-08dbcf48a252 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 19:38:27.2369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V3MZqimkwR+QjpF0dbDYu3lAKhj05gsKN85lDYuWiA89QgiLd48XLygwYG4s0WHXWxyMkrrU3qYXjCbgJI0Wvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB6357 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/17/23 15:14, Pedro Alves wrote: > On 2023-10-10 21:40, Simon Marchi wrote: > >> diff --git a/gdb/solist.h b/gdb/solist.h >> index 9320acb7fd3e..31b823a3a482 100644 >> --- a/gdb/solist.h >> +++ b/gdb/solist.h >> @@ -36,7 +36,7 @@ struct lm_info >> >> using lm_info_up = std::unique_ptr; >> >> -struct so_list >> +struct so_list : intrusive_list_node > > I noticed this in patch #24: > > > @@ -52,7 +52,7 @@ struct so_list : intrusive_list_node > > dynamic linker's tables in the inferior, and are initialized by > > current_sos. */ > > > > - struct so_list *next = nullptr; /* next structure in linked list */ > > + so *next = nullptr; /* next structure in linked list */ > > Err, what "next" still doing there? :-) This patch should have deleted it. Good find, fixed locally. Simon