From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D8F563858D1E for ; Fri, 8 Sep 2023 15:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8F563858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 388FpW4H029684 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Sep 2023 11:51:37 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 388FpW4H029684 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1694188297; bh=/dSO57xTrR6IpZcU6K8VN8v/DhX4+d4tbFk0C4Ofbyg=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=uY5AWqpp8IbHZHS+l2ZI2U+my7UEUUypbDtX8L4TScnQBkflO35ICiG4auvPD7ECe t5wNWSYkxcQwU8X1kE7B+6tmrP7N48OqrfflAFewsSPq4GbbabhX60k+h8hhcCm0Rf 1RBdpzPO34ELoYU7jHJL372ps3JoZbJmNhzwX/Jg= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 69EF31E092; Fri, 8 Sep 2023 11:51:32 -0400 (EDT) Message-ID: Date: Fri, 8 Sep 2023 11:51:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/16] [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes Content-Language: fr From: Simon Marchi To: Luis Machado , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20230907152018.1031257-1-luis.machado@arm.com> <20230907152018.1031257-11-luis.machado@arm.com> <76297091-3417-0086-b1b7-4ecb438d9cd8@arm.com> <08ceb244-9694-46a3-b656-1c169a31bfb4@polymtl.ca> In-Reply-To: <08ceb244-9694-46a3-b656-1c169a31bfb4@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 8 Sep 2023 15:51:33 +0000 X-Spam-Status: No, score=-3031.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/8/23 11:48, Simon Marchi wrote: > On 9/8/23 07:08, Luis Machado via Gdb-patches wrote: >> It would be nice to have a global maintainer go through this one, as it touches a small part of generic gdb code. > > I don't have time to go in depth in the AArch64-specific bits, but for > the trad-frame changes: > > Approved-By: Simon Marchi > > Simon Maybe a minor comment I forgot to mention: instead of defining a new frame_prev_arch_ftype typedef, can we include frame-unwind.h? The intention of the new prev_arch is really just to forward it to the unwinder created around the tramp_frame, so I think it would make sense to do so. Simon