From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 9C1C73858C52 for ; Mon, 28 Nov 2022 21:07:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C1C73858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ASKtcA4003107; Mon, 28 Nov 2022 21:07:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding : subject; s=pp1; bh=1sXiBA8ZcUbXO4tmYmHIR7LPfKQsxbEI1rE7p7/Kagk=; b=rHLKg9KrXNXVIrH3vVYeTTYsswv9ZcgsuM0MQXNRAUGOaB1qViZpkzUlCArI3KmG5Dsy NmHn0C6Rv/XOdoCdCy4hNTwGOoqwAcr03JwRchFdczp7K5joT1vRYFQ4Q7fgxCkQIDaO yweCtVn8Zj1sbQmFmNdThlYfx+EWjX8WxfEQs2O/rr9THbiasoz03DTRELij7jQykyle maEn/cRujzNyZwXFbypONGbofOjoJJYlVVevDlVkZVpg8xTUUacekww4bYESm8bhQ4ub xg6UM0f4Sx8iFw5pZGzgWvKKCyRt32vcpu5ZmOjGmUeoJppA7N2lQqf2jJsnHOJghqNI TQ== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m54f1g7sq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 21:07:17 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2ASL5OPD012637; Mon, 28 Nov 2022 21:07:16 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma01dal.us.ibm.com with ESMTP id 3m3ae9v08n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 21:07:16 +0000 Received: from smtpav02.dal12v.mail.ibm.com ([9.208.128.128]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2ASL7Ci338535764 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Nov 2022 21:07:12 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A094558069; Mon, 28 Nov 2022 21:07:14 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BB9E5805A; Mon, 28 Nov 2022 21:07:14 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.52.7]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 28 Nov 2022 21:07:14 +0000 (GMT) Message-ID: From: Carl Love To: Tom de Vries , gdb-patches@sourceware.org Cc: Ulrich Weigand , Tom Tromey , Will Schmidt , cel@us.ibm.com Date: Mon, 28 Nov 2022 13:07:13 -0800 In-Reply-To: References: <20221128162134.20424-1-tdevries@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: UrU9U34cGvLc4rttENoLA5HZAqCXEY9M X-Proofpoint-GUID: UrU9U34cGvLc4rttENoLA5HZAqCXEY9M Subject: RE: [pushed] [gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp for ppc64le X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-28_17,2022-11-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211280151 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_ASCII_DIVIDERS,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom: On Mon, 2022-11-28 at 21:46 +0100, Tom de Vries wrote: > > I made the change $decimal\\.$decimal? and that seemed > > to work on my system. I tried the test on my X86 box but it is not > > supported. Looks like the system doesn't have the ada compiler > > installed. > > > > Can you verify that the change works on your system and if the > > patch > > looks ok. Thanks. > > > > It doesn't work, as expected, because the output is: > ... > Breakpoint 1, foo_o224_021.child1.child2 (s=...) at > /home/vries/gdb_versions/devel/binutils- > gdb.git/gdb/testsuite/gdb.ada/out_of_line_in_inlined/foo_o224_021.adb > :24^M > ... > and $decimal\\.$decimal? does not match "1". If I use the original suggestion, here is the patch I ran: diff --git a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp index 621b04e179b..54c55bc6f7e 100644 --- a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp +++ b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp @@ -34,7 +34,7 @@ foreach_with_prefix scenario {all minimal} { gdb_run_cmd gdb_test "" \ - "Breakpoint $decimal, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \ + "Breakpoint $decimal(\\.$decimal)?, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \ "run to foo_o224_021.child1.child2" set opt_addr_in "($hex in)?" then I run the test I get: make check RUNTESTFLAGS='GDB=/home/carll/bin/gdb gdb.ada/out_of_line_in_inlined.exp ' > out WARNING: Couldn't find the global config file. WARNING: Couldn't find tool init file WARNING: Couldn't find the global config file. WARNING: Couldn't find tool init file WARNING: Couldn't find the global config file. WARNING: Couldn't find tool init file WARNING: Couldn't find the global config file. WARNING: No tool specified WARNING: Couldn't find the global config file. ERROR: tcl error sourcing /home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp. ERROR: tcl error code TCL LOOKUP VARNAME decimal ERROR: can't read "decimal(\.[0-9]+)": variable isn't array while executing "gdb_test "" "Breakpoint $decimal(\\.$decimal)?, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" "run to foo_o224_021.child1.child2"" ("uplevel" body line 13) invoked from within "uplevel 1 $body" invoked from within "foreach_with_prefix scenario {all minimal} { set flags [list debug \ optimize=-O2 \ additional_flags=-fgnat-encodings=$scenario] if..." (file "/home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp" line 22) invoked from within "source /home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source /home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp" invoked from within "catch "uplevel #0 source $test_file_name" msg" ERROR: ------------------------------------------- ERROR: in testcase /home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp ERROR: can't read "decimal(\.[0-9]+)": variable isn't array ERROR: tcl error code TCL LOOKUP VARNAME decimal ERROR: tcl error info: can't read "decimal(\.[0-9]+)": variable isn't array while executing "gdb_test "" "Breakpoint $decimal(\\.$decimal)?, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" "run to foo_o224_021.child1.child2"" ("uplevel" body line 13) invoked from within "uplevel 1 $body" invoked from within "foreach_with_prefix scenario {all minimal} { set flags [list debug \ optimize=-O2 \ additional_flags=-fgnat-encodings=$scenario] if..." (file "/home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp" line 22) invoked from within "source /home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source /home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp" invoked from within "catch "uplevel #0 source $test_file_name" msg" -------------------------------------------------- make[4]: *** [Makefile:226: do-check-single] Error 1 make[3]: *** [Makefile:161: check] Error 2 make[2]: *** [Makefile:1922: check] Error 2 make[1]: *** [Makefile:13585: check-gdb] Error 2 make: *** [Makefile:2531: do-check] Error 2 The error seems to be that it is looking for an array??? Second attempt, maybe the parenthesis need to be escaped, i.e. diff --git a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp index 621b04e179b..de1a6d053f1 100644 --- a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp +++ b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp @@ -34,7 +34,7 @@ foreach_with_prefix scenario {all minimal} { gdb_run_cmd gdb_test "" \ - "Breakpoint $decimal, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \ + "Breakpoint $decimal\\(\\.$decimal\\)?, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \ "run to foo_o224_021.child1.child2" set opt_addr_in "($hex in)?" GDB seems to accept this, but I get the test failure: (gdb) break foo_o224_021.child1.child2^M Breakpoint 1 at 0x10011870: foo_o224_021.child1.child2. (3 locations) (gdb) run Starting program: /home/carll/GDB/build-test/gdb/testsuite/outputs/gdb.ada/out_of_line_in_inlined/foo_o224_021-all [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Breakpoint 1.1, foo_o224_021.child1.child2 (s=...) at /home/carll/GDB/binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined/foo_o224_021.adb:27^M 27 Do_Nothing (C); (gdb) FAIL: gdb.ada/out_of_line_in_inlined.exp: scenario=all: run to foo_o224_021.child1.child2 So it doesn't match. I am guessing it is looking for the parentheses in the string to match and of course doesn't see them. Carl