From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1032A3858D37 for ; Tue, 14 Jul 2020 02:28:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1032A3858D37 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 06E2Sj0g032693 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jul 2020 22:28:50 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 06E2Sj0g032693 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 75ECA1E5F9; Mon, 13 Jul 2020 22:28:42 -0400 (EDT) Subject: Re: [PATCH] gdbserver: fix memory leak when handling qsupported packet To: Tom Tromey , Simon Marchi via Gdb-patches References: <20200709015338.322449-1-simon.marchi@polymtl.ca> <89540b90-c738-d687-c6ee-90e499d71848@polymtl.ca> <87o8oj6ywe.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Mon, 13 Jul 2020 22:28:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87o8oj6ywe.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 14 Jul 2020 02:28:45 +0000 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 02:29:02 -0000 On 2020-07-13 2:41 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> gdbserver/ChangeLog: > > Simon> * server.cc (handle_query): Use std::vector of > Simon> std::string for `qsupported` vector. Use separate > Simon> vector for unknowns. > Simon> * target.h (class process_stratum_target) : > Simon> Change parameters to array_view of const char *. > Simon> (target_process_qsupported): Remove `count` parameter. > Simon> * target.cc (process_stratum_target::process_qsupported): Change > Simon> parameters to array_view of const char *. > Simon> * linux-x86-low.cc (class x86_target) : > Simon> Likewise. > > FWIW this seems fine to me. Thanks for cleaning this up. > > Tom > Thanks, I pushed it. Simon