From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80081.outbound.protection.outlook.com [40.107.8.81]) by sourceware.org (Postfix) with ESMTPS id 63700385780F for ; Mon, 16 May 2022 14:56:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63700385780F ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Q9as5+zOzPEQv4ojhhLbKPCXMIznY6MzvJB8AONQZ3pDHM+g7utNNe4EVHtu1elwfpYdu1eKMdznHKAX/3PgZxgdOKTdDgFUGHEHpABq37ZFpldz/Y0lidzzE/HLNzR1XYT0GLWOXgSgjpx9OHBAsRVq4cWIVAfPGkau4DqliGfsVspbmb9XHcDsH+TfaAjDbB/Vyxr/rDmfzp1UDQTZ+RlsUCnS9QdhuPkibi8NaGTdmp5FJwKetk7n5SfSjuKWyFoKQLk1z+lhlKMZBCzE++IJKkAE2T70BDMw9GiC3N9QstpVLbOw6jKP1yxiQaN9k0vT8PTVyMejerr/y3xXUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dg0+8WnpIFlteujlbHqgnef/nTl5xS8IQqyG7WpmILM=; b=duz1QObhFRpO23Bd5hpfcJTrEr1bsHuYK8TRB/snjKwNQvml74wVl2akifm6P8HIWaoW9VOf8Cl5KOIm4ILrs8ikzv0HIZaL5795/3J7FxlWIT+45DP8SJ06oGRJVMrLqTND6Ag3t7JhwAUYcIR1lkUhbWH5N2goYegDO8kou/Nef+872lkP/ovVU0oJkihcb91lNMo2dIy4ovi1ytrOJY6gnnloYr+k3yfZNqBKbLsNzBHDkOQNHWTlVQHyAd1d5HZfZ6xyr607Cmyls3V9JZ2svBjcPlgMIF48RTZJiKSQzZkCoPX9Cl6bGK94YmVXyW2q19lKizHun8QUJFk42A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DU2PR04CA0337.eurprd04.prod.outlook.com (2603:10a6:10:2b4::35) by AM6PR08MB4424.eurprd08.prod.outlook.com (2603:10a6:20b:73::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 14:56:10 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b4:cafe::ac) by DU2PR04CA0337.outlook.office365.com (2603:10a6:10:2b4::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18 via Frontend Transport; Mon, 16 May 2022 14:56:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Mon, 16 May 2022 14:56:09 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Mon, 16 May 2022 14:56:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cc1d0da4f1804871 X-CR-MTA-TID: 64aa7808 Received: from 980ff8474e31.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5B2E003E-5FC3-4C11-A30E-661A28854E60.1; Mon, 16 May 2022 14:56:03 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 980ff8474e31.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 16 May 2022 14:56:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJPm9gOhCwuE82vzYb+jyH/cL/gO66ZEfoi5nOeB0f8D5GMVITLyrf2creejlwD5jL4IwNUrzvSb7eIxdd5B0g8vo8RGCuAx6mGArjwmbwEWHuTRlNLpeJvp1QgdWm37OBBrrhVNWK0v90DhKFXvPPHy8PVJYZ/qnnqadvAvBGp3g3+xlqeqQCtSPTLk9izC2MSkChqkQN93aN8YfPuSOIhCUlfjIcPXMtqoVF9K62NVhAI8K7A1m/sDUBslYd+eTpUZ+1qdi0NlVzRV7DokepHbyeNxWSWBlhitcuczXAXvUYi+Ln2IiDEH/13AJshfX3uLhC4IoTxkhrTDnN2rSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dg0+8WnpIFlteujlbHqgnef/nTl5xS8IQqyG7WpmILM=; b=WsRKDuOYvIjchXR5vjElfWy3ncJqGkCRC0Jvx/pr+lrs3hNf0jK7ZGIiUkvudbNtfhaQBGVmjfG3VPjheZO9BbJDCGtdWrLSUMcfunMel9GCBtGz+jwR+lTnsvp643/eSW1p5y95tTld0GOxHxfQ/tK2Bh02SRcELSTs2YY0xi7ERODfO80poyb0xWusxcPzoCgv7k23wBtxHkK0XtERxWxZlyqsjJl9W9p8+ENkoEIHPzS7Q+4Z8ZSnOUUFB7H2tkFOECzsXLxiDydIeE1kmXkOp+Fl6+fmh+0vh7VD9JEtCbektgHp8tQhAV795uDRSixAJ8t8C8yRu+pcS6TkFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) by AM6PR08MB4967.eurprd08.prod.outlook.com (2603:10a6:20b:e8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 14:56:01 +0000 Received: from VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::1916:206:dd8b:6a91]) by VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::1916:206:dd8b:6a91%4]) with mapi id 15.20.5250.018; Mon, 16 May 2022 14:56:01 +0000 Message-ID: Date: Mon, 16 May 2022 16:56:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/3] gdb/arm: Fetch initial sp value prior to compare Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn Svensson References: <20220516135454.GA27993@gnbcxd0114.gnb.st.com> <20220516135935.GC27993@gnbcxd0114.gnb.st.com> From: Christophe Lyon In-Reply-To: <20220516135935.GC27993@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0440.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::13) To VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 2a7a3f36-474d-4139-93a0-08da374c3694 X-MS-TrafficTypeDiagnostic: AM6PR08MB4967:EE_|DBAEUR03FT035:EE_|AM6PR08MB4424:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OeBV+hhqt9tLDfRytCh/aPIN1dGS93J0Mi6dWr+FQ097CFG5E3zKfZfcxJnSujUYD31mRJmAqcHHiqNWEetCX3iRhi4V1+g5JJUfeU94e580uiYv6i0T8moPdr896rD5yKxAAt/rZPoacC/1Q0vfRsiTCo1czKGAtiKpvJfy9z1qCziBuYy0em0BkZF9ERiB/vmpR9T/Z+RpXoYSzrL+B7TYWdw5IEp2dBZf9PBXUHjfrgS7d7gNTOMOgxVCjc0gg6o2s2Nn0et9ocVyzTzdNoyTOUvInN1LefVAZn1yVvYu2uL1QgV4cIxjbxMx8hlo14LH7SWVbOp54ou4RTIrRCBmq2+at+cVvlOkvZxtXTytvcyynxQt1dOOFkt9JEPz0GFgHzAOKbtRMvX4lRiw58Hm7ueb5HwL/yz67RXezXYkKjhvUUT2T4ylFH+Yt9nxRyb7ZkKc9v4wJnKJzdY9SdW7YymS+ViuP5bZPIMaVNPwcvkTyqVGtQqYrGy5oVaQSKmWt7xQkCUQ9Mm9T8vSdoZXtkIVu61vVc9WR1C+kbF1gEsOfpUsdrkGC9xyLP7r+HHAeC3oSsrvyR3HlJhP3Q8pbquPfGDkgp5qfS/5fMm03N5mY6gTA6mVkrwWAJFF8jrh+YK8TEwowDkDUPXKvqozczjjkH/RnQkBmhXA5nOMKTwnNubnUygvcthzSc2ItLcnXpCb9eO1+l1OMcLEZyZUdrQslAf2M7/asR/pWAc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3694.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(53546011)(8676002)(66556008)(6506007)(2616005)(66476007)(44832011)(8936002)(508600001)(83380400001)(5660300002)(6486002)(2906002)(316002)(26005)(6512007)(36756003)(31696002)(31686004)(4326008)(66946007)(86362001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4967 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a198d727-42e5-4321-3cc6-08da374c31a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 23xRSDP5T0eGEUxNLJEyfI+JDmGlgmtRCnLgkXRvLbP1ZDZyNY26Yfpu9l2VAHTLHqNFgmbNIa+JwHLEzLdPfL/7RQB0kOXN/74T6/VhtAmKlyTmkztxyLyyGbmwM8PrnOgNjxFNZ19bd8fwKMCVaxVco+t9FFKaWSmfyQIf4dWqxPsZkhrQ7zB/M5eqpb3N4aRD5q0JMUdKwEMjZ2ah39kQthlrjiLOAjAsLFsOIIq/dZPkD8DhTxE51a2PtLzh9b1EJRpUUcwu5EcUC8nSayaf66Zy9Y3SmrHGnBUHo/cHiCbGBoJ2QlyIRbBeu8BaaxrkCUGhYY59DMYmM6YJ8IbFXVSA8/OsjvthDnz1OeJy7PC2XIn9yFOrf16t9gc3kkaP4E+eeWayZXGkJA/eQ3TjJelXqvvnSMWf0w196XyUN5XUmPJsJtntYPunc+8VehK3GtPyje7WiMV7WxIP0+loe3TTmHmsjnGQmyaxyOdZ0myXX2WfgYaeqD2ft/nDF7ztdL4mnLNk8CqqjLti2V5FrrkWZUY8bMukQFgMqP9NVrXI63ncc7ZhKe+5w29uUQbVHn67YV/sywM8WLCG8uC9lLmNKG8oKmP2c3wiX3lfh1/tgaIFi2XU+eF0+t6HSK1SDOPaz83SwHnVAaBkJya3BvNZkPze6GfKCpW6mbnHB7an7gK7SkVMGU4tXTkrbmShfWoc7Z5O0r/6eR3k2w== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6486002)(356005)(40460700003)(31696002)(336012)(47076005)(81166007)(8936002)(5660300002)(508600001)(2906002)(70206006)(82310400005)(70586007)(316002)(83380400001)(6506007)(31686004)(36860700001)(2616005)(4326008)(8676002)(53546011)(44832011)(6512007)(26005)(36756003)(86362001)(186003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 14:56:09.9095 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a7a3f36-474d-4139-93a0-08da374c3694 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4424 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 14:56:18 -0000 Hi, On 5/16/22 15:59, Yvan Roux via Gdb-patches wrote: > For Arm Cortex-M33 with security extensions, there are 4 different > stacks pointers (msp_s, msp_ns, psp_s, psp_ns). In order to > identify the active one, compare the values of the different > stacks. The value of the initla sp register needs to be fetched to Typo: "initial" > perform this comparison. > > Signed-off-by: Torbj�rn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index c37254c2ce1..4aa277f5bc8 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -341,6 +341,7 @@ arm_cache_init (struct arm_prologue_cache *cache, struct frame_info *frame) > arm_gdbarch_tdep *tdep = (arm_gdbarch_tdep *) gdbarch_tdep (gdbarch); > > arm_cache_init (cache, gdbarch); > + cache->sp = get_frame_register_unsigned (frame, ARM_SP_REGNUM); With such simple fixes, I always wonder "how did that somehow worked so far?". Can you describe the broken scenario fixed by this patch? Thanks, Christophe > > if (tdep->have_sec_ext) > {