From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6DE713857C45 for ; Wed, 10 Jan 2024 15:54:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6DE713857C45 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6DE713857C45 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704902102; cv=none; b=vAlZr+7BIB/5v9P1ImM0VxQLHv8rd0SLzsWNUeblbI7stDP5IE2G5GdFSKe5kAmAtHVsoHBVsWQPunxxFVUpxYsSnbi51Edp8GgNe1Q8R29AUHIp7VB8705ZZDe2ifk8KBA0L6AGZVutFenBTRSyvtFy375Yae+172d1pW36weY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704902102; c=relaxed/simple; bh=VbrDf+cllGINFkyjU8HJmxaLG3f140bpf9hHU1SXWiM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=D7d4DdwkeCgAzNXKeXi7DoREtJidmqVQYSRS6Audi1pG3fqE4omdhwJPmzKHohfD7baDCzS4eLlxITO1+83wdKaKWAH2vRl6+EbzGGSDXjxk0u+w68XbvM3bmS3iuWHQitNx9YKmKQL4ff5A5iiuYVwFkgIoKbR4wUtkaGalCa8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704902098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GIurhLwzKPJMpUlG4tYypyzqOSUyPWdwovdKmgp5yP4=; b=Ry5hZo5zheKiP2/7QkaOeKclDsXVUiMiwDSIZcyVXX8DWc5KnyDwknlsC1m3VtJwyRu0wL AjJOu0rFIBGDbSfrARWe/8UpEr2C9BmJybXTDuE9rY2rfdrPf9wEe3lGifoRif6x8atYyJ VhuTSzSepGvM+HgynN9bjQ5xeWG5Gb8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-ite43Xr8OAqArdZRvTXO6Q-1; Wed, 10 Jan 2024 10:54:56 -0500 X-MC-Unique: ite43Xr8OAqArdZRvTXO6Q-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40e439092a0so29380775e9.0 for ; Wed, 10 Jan 2024 07:54:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704902095; x=1705506895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GIurhLwzKPJMpUlG4tYypyzqOSUyPWdwovdKmgp5yP4=; b=NdNH2kFWstk5y232D/30XoMXYSEavruwpgfdWOrn92DFqjQXlf7Nmi9Z61zLP2NaXT M7b1z8NDe+yMNHXQKlUrydVdlF6AxqAts5yHTXfcT+EBdD9fQd2VN8nNGR5Eh2WKklzA Sq/4zouxajXTiwPcGYlFE9+6T6QWj1VJ9qCpegDDRhKWU+SzRb7H6ejWu/LapYgmcubc SrntxEQ79DDnmwK5o4ygHrxZhYhwOkBd1s5ByRuuFnCj+6eu9UpZgD2SD5Y6WbXzDk0H hfdEF2dV7/IpCkR5Us9no+pvdTQR5xhVt0XwSFLoaom+v+tAjYIPeDR5tYizsH+kVqgg xB+A== X-Gm-Message-State: AOJu0Yzzg7hZ78JdM5MgA2za7ealG0OPLYqUATlXCJeKZW7dOa96oXE4 iEoSz9dqkVLo52GlKYqngWiHd0WAALjsv5WEZCYRKzsq81DeB5mocWtfuPvX0c/MGdJ44mQbC1F QKIig5C2IIFT1eC0ipCxiq4RF07J+VcIrZhwuAd19FhvkL1nsGOMnndgei9fdJGZyK4FqAMcvdF JkolVZClkt0W8Z2g== X-Received: by 2002:a05:600c:228b:b0:40e:3ad9:c139 with SMTP id 11-20020a05600c228b00b0040e3ad9c139mr706820wmf.81.1704902095390; Wed, 10 Jan 2024 07:54:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHksf+r3k2t93N1F/EU8Qoc03jshFg9CPlaPboW6xtlM6oShoxGitl4XbN9iW08/1hZCiF+Q== X-Received: by 2002:a05:600c:228b:b0:40e:3ad9:c139 with SMTP id 11-20020a05600c228b00b0040e3ad9c139mr706813wmf.81.1704902095127; Wed, 10 Jan 2024 07:54:55 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id bh21-20020a05600c3d1500b0040d987aae3esm2596167wmb.13.2024.01.10.07.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:54:54 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 3/8] gdb/python: add gdb.Frame.__repr__() method Date: Wed, 10 Jan 2024 15:54:40 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Add a gdb.Frame.__repr__() method. Before this patch we would see output like this: (gdb) pi >>> gdb.selected_frame() After this patch, we now see: (gdb) pi >>> gdb.selected_frame() More verbose, but, I hope, more useful. If the gdb.Frame becomes invalid, then we will see: (gdb) pi >>> invalid_frame_variable which is inline with how other invalid objects are displayed. --- gdb/python/py-frame.c | 19 ++++++++++++++++++- gdb/testsuite/gdb.python/py-frame.exp | 8 ++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c index f38bf5d8237..ee465ed64a1 100644 --- a/gdb/python/py-frame.c +++ b/gdb/python/py-frame.c @@ -84,6 +84,23 @@ frapy_str (PyObject *self) return PyUnicode_FromString (fid.to_string ().c_str ()); } +/* Implement repr() for gdb.Frame. */ + +static PyObject * +frapy_repr (PyObject *self) +{ + frame_object *frame_obj = (frame_object *) self; + frame_info_ptr f_info = frame_find_by_id (frame_obj->frame_id); + if (f_info == nullptr) + return gdb_py_invalid_object_repr (self); + + const frame_id &fid = frame_obj->frame_id; + return PyUnicode_FromFormat ("<%s level=%d frame-id=%s>", + Py_TYPE (self)->tp_name, + frame_relative_level (f_info), + fid.to_string ().c_str ()); +} + /* Implementation of gdb.Frame.is_valid (self) -> Boolean. Returns True if the frame corresponding to the frame_id of this object still exists in the inferior. */ @@ -840,7 +857,7 @@ PyTypeObject frame_object_type = { 0, /* tp_getattr */ 0, /* tp_setattr */ 0, /* tp_compare */ - 0, /* tp_repr */ + frapy_repr, /* tp_repr */ 0, /* tp_as_number */ 0, /* tp_as_sequence */ 0, /* tp_as_mapping */ diff --git a/gdb/testsuite/gdb.python/py-frame.exp b/gdb/testsuite/gdb.python/py-frame.exp index 16177c8a5f8..6162696948f 100644 --- a/gdb/testsuite/gdb.python/py-frame.exp +++ b/gdb/testsuite/gdb.python/py-frame.exp @@ -36,6 +36,10 @@ gdb_breakpoint [gdb_get_line_number "Block break here."] gdb_continue_to_breakpoint "Block break here." gdb_py_test_silent_cmd "python bf1 = gdb.selected_frame ()" "get frame" 0 +# Test Frame.__repr__() method for a valid Frame object. +gdb_test "python print (repr(bf1))" "" \ + "test __repr__ for gdb.Frame on a valid frame" + # Test Frame.architecture() method. gdb_py_test_silent_cmd "python show_arch_str = gdb.execute(\"show architecture\", to_string=True)" "show arch" 0 gdb_test "python print (bf1.architecture().name() in show_arch_str)" "True" "test Frame.architecture()" @@ -100,6 +104,10 @@ gdb_py_test_silent_cmd "python bframe = gdb.selected_frame()" \ "get bottommost frame" 0 gdb_test "up" ".*" "" +# Test Frame.__repr__() method for an invalid Frame object. +gdb_test "python print (repr(bf1))" "" \ + "test __repr__ for gdb.Frame on an invalid frame" + gdb_py_test_silent_cmd "python f1 = gdb.selected_frame ()" "get second frame" 0 gdb_py_test_silent_cmd "python f0 = f1.newer ()" "get first frame" 0 gdb_py_test_silent_cmd "python f2 = f1.older ()" "get last frame" 0 -- 2.25.4