From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 28397383B417 for ; Sun, 20 Jun 2021 02:17:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28397383B417 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15K2H1wk021958 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 19 Jun 2021 22:17:06 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15K2H1wk021958 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B5A941E813 for ; Sat, 19 Jun 2021 22:17:01 -0400 (EDT) Subject: Re: [PATCH v2] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS To: gdb-patches@sourceware.org References: <20210615054416.1232-1-vapier@gentoo.org> <20210618140342.16460-1-vapier@gentoo.org> From: Simon Marchi Message-ID: Date: Sat, 19 Jun 2021 22:17:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 20 Jun 2021 02:17:01 +0000 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jun 2021 02:17:08 -0000 On 2021-06-19 10:10 p.m., Mike Frysinger wrote: > On 19 Jun 2021 20:48, Simon Marchi wrote: >> On 2021-06-18 10:03 a.m., Mike Frysinger via Gdb-patches wrote: >>> These dirs don't use automake, so use AC_CONFIG_MACRO_DIRS to specify >>> ../config as a search dir for m4 macros. This allows removal of a lot >>> of hand-written m4_include's from acinclude.m4 files, and simplifies >>> use of `aclocal` or `autoreconf` as manual -I is not needed. >>> --- >>> v2: include comment in top of acinclude.m4 files. >> >> With this patch, I get: >> >> configure.ac:531: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd >> ../config/iconv.m4:12: AM_ICONV_LINKFLAGS_BODY is expanded from... >> ../config/iconv.m4:23: AM_ICONV_LINK is expanded from... >> ../config/iconv.m4:104: AM_ICONV is expanded from... >> configure.ac:531: the top level >> configure.ac:531: warning: AC_LIB_RPATH is m4_require'd but not m4_defun'd >> ../config/iconv.m4:12: AM_ICONV_LINKFLAGS_BODY is expanded from... >> ../config/iconv.m4:23: AM_ICONV_LINK is expanded from... >> ../config/iconv.m4:104: AM_ICONV is expanded from... >> configure.ac:531: the top level >> >> To fix this, we'd need to keep these three lines: >> >> m4_include(../config/lib-ld.m4) >> m4_include(../config/lib-prefix.m4) >> m4_include(../config/lib-link.m4) >> >> If I bring them back, it's all clean. > > just in gdb/ right ? Yes, gdbserver was fine. > you're running `autoreconf` to test ? > -mike Yes, (autoreconf -vf). Simon