From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BFAEB385840E for ; Fri, 6 Jan 2023 09:51:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFAEB385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672998692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KMDBqOG4p++2LmOHeM1od3k3HEHFDNzgOlhmdwH84wI=; b=VjB8qZK7s8Wp3/tGuz3vphDRnWteMukhsKWtKfwmbO+BSe0GzU1udF7VbIroif5x67NZDW uGdTbu5UDMif0ZjoQJD00J8euBMnuMLsw/XQfEbDSnmYF1SyB8DSR2Y1rrN1vD3zOzJPr5 os9StJ1QVzgjYfYxS1qctZ+Gvv/3GnA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-81-75doEmohMGO9dkPQRIdoEg-1; Fri, 06 Jan 2023 04:51:31 -0500 X-MC-Unique: 75doEmohMGO9dkPQRIdoEg-1 Received: by mail-qk1-f197.google.com with SMTP id l16-20020a05620a28d000b00704af700820so700343qkp.5 for ; Fri, 06 Jan 2023 01:51:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KMDBqOG4p++2LmOHeM1od3k3HEHFDNzgOlhmdwH84wI=; b=M6sH3TH8lu4EDUvPqHPInv1WgbQoCVvGKE+ASOBASAn+M+mxxCQQo0vHVkdRBF3BhK azHSxY7IQ/y9cim7qajQ7q1272AYtAmQTztYnJ6SirlB9N3HqrVhaIzKVWrNM0p8z6Xy KCRMl2bEko/82bXq8dwK9Otz3yJ/YUXVH6kJhqTv1ICxs8UG78a1OHBH6OUclsw7cgH7 5Y+OsEqqbOdCcpVua5VI1ZSCn88nTGFyvJjb+umHEqIG3f3KLZaePqJl5E3zl1CpxtU+ TahzlDgCCjBWAPb+u3J8j1W6LpSjgpUCNdarlqN2YQixjKl3DNluna84mgNpnW1GUHrE ++UA== X-Gm-Message-State: AFqh2krP+5WgQn4Uky3u5l2rtYzwjBfZAyUoqdaG41le2ES7nbFdv0KR 4bxnSWsTNV87fJClda2zTYOAr1zrEwLHozO50AJs5dxVQ55PMILjMhCcMOjXVFM8mk8cEC1f9FY 0ZGbAnTeBuZQtVLVca9DzwQ== X-Received: by 2002:ac8:7386:0:b0:3a8:1896:e2fc with SMTP id t6-20020ac87386000000b003a81896e2fcmr77977060qtp.35.1672998690531; Fri, 06 Jan 2023 01:51:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXthoPFX9uqHrT9Fu96mSiENaD/XxGBTZ2S5seu3RJi7DnE0uGjh63VdwB6yeuLy+747Y6vzMA== X-Received: by 2002:ac8:7386:0:b0:3a8:1896:e2fc with SMTP id t6-20020ac87386000000b003a81896e2fcmr77977044qtp.35.1672998690251; Fri, 06 Jan 2023 01:51:30 -0800 (PST) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id cm8-20020a05622a250800b003a50ef44a77sm291850qtb.28.2023.01.06.01.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 01:51:30 -0800 (PST) Message-ID: Date: Fri, 6 Jan 2023 10:51:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] gdb/testsuite: Fix FAILs in gdb.linespec/cpcompletion.exp when using clang To: Tom Tromey , Bruno Larsen via Gdb-patches References: <20230105075705.2271636-1-blarsen@redhat.com> <87fscod9v5.fsf@tromey.com> From: Bruno Larsen In-Reply-To: <87fscod9v5.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05/01/2023 21:06, Tom Tromey wrote: >>>>>> Bruno Larsen via Gdb-patches writes: >> When using clang 16.0.0 to test gdb.linespec/cpcompletion.exp, I get 99 >> unexpected failures. They all fail to produce a complete list of >> completion options for a function, either overload2_function, >> overload3_function or anon_ns_function. This happens because clang is >> optimizing them away, since they are never used. >> Fix this by adding __attribute__((used)) to all declarations to the >> aforementioned functions. > Thanks for the patch. I guess we use this attribute in the tests > already, so I think this is ok. thanks! pushed > > Tom > -- Cheers, Bruno