From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2122.outbound.protection.outlook.com [40.107.115.122]) by sourceware.org (Postfix) with ESMTPS id B207B3849AF0 for ; Fri, 19 Apr 2024 19:41:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B207B3849AF0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B207B3849AF0 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.122 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713555706; cv=pass; b=b7OmRKWCLRbN4O/fnd5IPIYOl3BQOOmyUW6NvVcvHQtO5YIasEzeVNhMEIAP3yfX11JaQFLnqCFV5nCxczmypGwj1pTU1wiMVlWpEF+51s4hw1NfZ14jHFIjQ+jnZhDcDp/NWxFbF4ixtgE+691FtospcxoOjSLxvx4zkmYnEtM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713555706; c=relaxed/simple; bh=UyIOWfLLyOJT6ENdUVz1AV0HGADzBTzI0zDihWlw5SU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=R47JQ72PVaFn+o7RweqZcBX1Dn7I0yxPfV1JmTFUbN7s4E1THHU9DBOPzqQA5ADdwK7zQCTc/5cl2Vk5vJpaiNdgSTh2wmgV1Ma0f2Im4DJTtony1b5rom675RZWOYVKoHvyjC/UjtwNs7dKG7BBmfUlMeMADN17uopUQ9fEs1k= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LIYV2J18wEFPQinLMWA4RvKb6zHRCNz5bRcREBz+5FqGnnqOu76/IXFK5yuJJRwkc4R+bc/vTgfAwoUPZKj3SexuWu26pQ76GFWlSyU97na1Yu0aI2+OIv8ZG01nWLPjHaYvWYkQqEEcVylQcvRGGj95Dj5y/Lx2tbs23orxBaITmIrV9xE3mTtEUceCTlWgzqdcTKkzT/IY0LRm5ZeGoUaj5+MFCNA9mC1/SiDP8uy6UF0naTTPuh7ndO2az9AE9lQqPSPIrA8q9Be+U3GcqfCQLPbKEDig4kkXJaakYcbkb5GBSHBUFkL9yTow/tMfEyq7xZnvh0lUAJvidf+CHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ZvfR+h+le9pi1VP+1/C55iUyXQfwLaLol5JpQFe7lg=; b=a+MiA0Sq2yMMYn4AzHDtc2eFj0DGZeeOaIK7TpacyD+2kPo2Df+j6CO6O/t/al8gdIRlI9YU+GLsxGRXiwFLSzNMdDQMAKpOSzaxfU6Yn/diUgETJVT4DoBe/XOSVV1Ul0YFCshIC1H8f/hXBTPgVku4jYr6lZFkNnsYS/JByoh0GdGHm5CyY4R7xRjRo9xCBhBx7ifn+q0EnQPCGcAtFW7NznRft/CzOjFeD2NUF73CdFU3+AlFsLF/vmsu0TgO02bVTawUFi98nld2WoayWgSVW3BGW7ObnIEET0kXdQLesBB3BnjXsSffxWvGmhMxPLj7q0wneBfJlyQtk4K28A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ZvfR+h+le9pi1VP+1/C55iUyXQfwLaLol5JpQFe7lg=; b=hjmNwuuRCeHepkAa/c4+oMGpJ7fmFPxHaSKcsZqn8ORNzRUrXAnxxGuQJ7RTo8MaA+pACU+vXUIC5ftMjQaSUCS6PC+JG0azWBfFIgVM+mCRPlpMLIHWSGo/TP9btJFRQHxP+aWSuKfFb/Vqfvoa8PoNPjYWKHamwGBb7SExoZNTRQeY8DkammAJPtcpo0AthNFXfh7/vppiW5/Bol1spFhRdglC4sfKHYX4lxeIKTY7kUxqzLqAxD83ihZIFuNggLc2nRi/NKQy1rIukYNtBNb4uKG5c1DJw2SSFbMGQ//dibwcHa81Hi/HxG9iXH3EG7AvgA6XqpMN7+GiDZxvXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YT2PR01MB5528.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:53::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.14; Fri, 19 Apr 2024 19:41:39 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1%5]) with mapi id 15.20.7519.010; Fri, 19 Apr 2024 19:41:39 +0000 Message-ID: Date: Fri, 19 Apr 2024 15:41:38 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] gdb: make target debug functions return std::string To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20240417205426.2030615-1-simon.marchi@polymtl.ca> <20240417205426.2030615-3-simon.marchi@polymtl.ca> <87o7a5upk9.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87o7a5upk9.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0008.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:85::23) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YT2PR01MB5528:EE_ X-MS-Office365-Filtering-Correlation-Id: efcd3944-9be9-4f42-adbb-08dc60a8bb7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: 1xFkU07YisxPtKW7SPj/65J/y7IwoOaPz3xWvqZqcLNrdJTDDkWdqRlnqGsxsNg7KQec7QBnqgnDr1Ykrh4GWOosIOV5FemAC/PzKedm5Y7ddej6e0xUECDjMPINdW/lj7eYD+KzuAivhad4DkTJOw+CgVOODYSGbvTNf4cEA+sRL+u+uu5iy3SogyKCl/Q1GX9Gvn4Pf2XqPm0U8Hu4s1JqM1QtFl1Qsql7QPF3D52M5ww9C5Y9Xw5TG8ELQRexJdpS1opfVB1g11HqQyMwETHZIOZNl8QLCQJSuBqf0jI5CJn+c6NWQbLQEV2cr6RQ8Ccyld0LFT0T0L/t8soVlg8WrD8pJV0D1sB4881ZJnhrQyWH/op9LKYMScZ8G30GZSnWtXF0Y0ucngjkJMDev85Oootfy9u2x3K3H3LGzRerfA4Itm+MrQRzNeoa6alIRUijrx1nsRoIgilXdBfm9uNOFtcxOxwCDHX7J2RQep+y42DnLGLWFK8+IVfO0TIQRU7DcjT/kKURJhPNa/WmLl5h7/1+7bvA0fo0kmXhaMxkDzdeUGmehT2yIbHuk8A4TmfxQXJLqNyXU7f/WswJfELeVw94rT+EQAdjRBeZ49IvxMHT2ofzBpDMcBLUaxC4EMDgIlA+xdksrtF9eiheHSpgUc1ffCY92Px8rmT0qQM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHg1VzQraDlOVFYwTFFPSkpKN25GMWhsckVrS1JZcDJvWElxOHZPSlJFRS9a?= =?utf-8?B?ajB6OHJ0U00vOXF0SDZTZkVoUVlNZzU2cmZoQTNhTU1NUzV4N2ZaZ3BPV25T?= =?utf-8?B?Qys3YmdJTXluZENZVzFGdHpYRHZ5Mk96MVp0QmJZRWNDR3ZNeXVYS2NWRXgv?= =?utf-8?B?dlZSc0QvUHpkdTlRMjJhc1FHeXlKRzdHUnlHa3pBMVBvc1gzdDRmdUlFa3FY?= =?utf-8?B?MFllK2NVMXJRd2RPaUxKcVBQNUtOenVVeGF2SUQ1eEtKYW9xZmttYU9UV1ZO?= =?utf-8?B?NGFjUHlUZjFoOFFvRVMydUFCb24yTG5NMS9vTlA3aFJoYzd2MlBDZEJDbmZh?= =?utf-8?B?V1grTklwOHR4NE9hR25HNjZiTW5hL09WejJ1SmFqUlUvYjVuQ2ZwZllzVW9S?= =?utf-8?B?NXFrMTFXMGU3QXBDa0xSd1lMVEJkRHFSRUVuVHdVRUNvUmYyeEFzSHNRYTZo?= =?utf-8?B?NVJSOVlHRXRuYmJDQWh3c2FLcGxNc1BSYS96T254WGV2V21nVGo0My96Ny9W?= =?utf-8?B?SnlTekpCVHl0WVJlSDJrdnhNRitOekdnek8zYjFGZlc4YWJmdlNaSEl4U1Mw?= =?utf-8?B?K2tMOTNxaCtYK2N3WjZUZ04wQkE0dmJoT2wzcE4rYnJpTDhPallFcDd2T3I4?= =?utf-8?B?dHpwL0k3QnVWN2xkYmtKRGhZMDRsdDdvUjBGaHBuZDBqSktoNERZODkzM2o1?= =?utf-8?B?a2ZmRlhvQnlNUGZTZVBNclNGTDNpeGJ0Zm1CUkJkRWFYRzRYYzRydXRWOHJH?= =?utf-8?B?UXdwakNuZnozNnZYMWdoNm5TVzFBZUNYZjE3aTJOY3RqVFFKQlp1aytReHZs?= =?utf-8?B?Wk40aFZKai9XOFZYZGhWSnNCMUJyYjJsM0Y4VnN0QXExeG93TTNOaWtnYmFw?= =?utf-8?B?Mk9tUzBvdHZ6bmJyVytsV3p1a1dHR21aeXk0Q2Nmb3c0bTQ1N0VFOFB4cUx1?= =?utf-8?B?SytxZzh0dERtUHRJc3MvUmI5UkRlRVJjMVJQZGl3Uk9rcFdNUnlHSXU2ekcr?= =?utf-8?B?dzYyVnJOY2s3NHhxYUlUTGZPQlYwQjN2SEtDSk0zSmZJQy9DNk10RGN1ZENV?= =?utf-8?B?aE40eXRXdlRIZ1lrcWhXN2gvU3MxdFkzTGFkZEowUm5rNVdwR1h5NnZOUWJ3?= =?utf-8?B?UU9lUlFob2N2TXl4YVNjalZwRldvdGxxUmpIRm9nN0FQYksxZVdZOGVtQU42?= =?utf-8?B?ZU9yZGtJYWcybktGVDkxVHJZdFZrbjVQQTRuTDJzaEN5MEtEbS9ZMjVaWTVS?= =?utf-8?B?NU1EdkZmTjJ1WGp6a1JCeUNURWVrTDltbVZ4aTJiTlMycHNTYWovejRzOTNk?= =?utf-8?B?M2hwNGRBZnBrQm90emFBS3c5R3JzVlFLRlFsbG9KdWhHTTF6YllDVzJhbTkr?= =?utf-8?B?cnJxenZzL2JRQjdaN2NwMEN4Q3hGWEttdWtOb0diTVl3Q2ExTE9MQlNjdEFK?= =?utf-8?B?citNT3Y0eXcra2c0UmVCbStlQ2t4UG5aOGk2SkdhZEhYT0dVcGlVTVVCS3pG?= =?utf-8?B?VHl0RENTQlRjbWFWeDQyMVBWWittOTlPZ3pybk9pL3p6T3NRUDcxWWQ3YTRo?= =?utf-8?B?d1p6djA3Y0RycGRwOWRHWmJaODl1Ri8xR1k2bTVvRmxpaGtqejlrMHA0MnpY?= =?utf-8?B?ZnhJWDhqUUc4SkIzZDhycVdYa05kUWc0RFltTXJGZTRTZ0NVN3JWdEwwRWcr?= =?utf-8?B?M1k0TjRjSUZDQldTZVZGb2tKWlk4VzRZZE11QjRlVis2amh2d1NsWkNNTFA3?= =?utf-8?B?UGhJSyt5cGpLam5NY21JS29CZ3VSWUUzQk5vcCtQUk5YQlBya1ZqMEl4NVBl?= =?utf-8?B?ejd1MTlqRkNSNEtSeFBQUFZ6T1pEakdVaTFaQW1td0VCWnNGd2xOcnZZYm84?= =?utf-8?B?VzZaZWZzSVFYaFJHc2UvNmovU01Vc1JpbDd1Y01ZNmtJbzd3NFI4MFBXWWR1?= =?utf-8?B?TjF0TTI3RkhYSEZWdGV1YWJDMVFCcUdDU2l2L3h0eitlVU5WOE4wcXNhZmhK?= =?utf-8?B?YUxLbkdITEd4MEhYMXJudVEwc2kveGJSajRrZGY4QVkxeG5SRTNySHhZUjZT?= =?utf-8?B?UXIvbTNRSCtKK3k0andPZTVhTW1zQTRFQWRVbHMrKy9TWTQrTy9yT2JQWDd6?= =?utf-8?Q?3vSdNlsTq7okgqerZ7eR1vYS0?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: efcd3944-9be9-4f42-adbb-08dc60a8bb7e X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 19:41:39.7643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vb8/QOEPCZqXl4at04bAS7+SNVMRvg0DZ21lcZUbgJIF9Qcommq4hmFRCiRPFc4TvFRWkB73MNyuZjRrkFwn3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB5528 X-Spam-Status: No, score=-3032.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-19 15:20, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> From: Simon Marchi > Simon> Change the functions in target-debug.h to return string representations > Simon> in an std::string, such that they don't need to know how the printing > Simon> part is done. This also helps the following patch that makes the debug > Simon> prints in debug_target one-liners. > > Simon> Update target-delegates.c (through make-target-delegates.py) to do the > Simon> printing. > > Simon> Add an overload of gdb_puts to avoid using `.c_str ()`. > > Simon> + string_appendf (s, " %s", > Simon> + gdb_signal_to_name (static_cast(i))); > Simon> + > Simon> + string_appendf (s, " }"); > > I think it would clearer if these were += instead of string_appendf. > It would also mean avoiding a trip through the printf code. Ok, I changed 3 instances of this to use += (I think you only meant these cases that append constant strings, right?). Simon