From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Kumar N, Bhuvanendra" <Bhuvanendra.KumarN@amd.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
"Achra, Nitika" <Nitika.Achra@amd.com>,
"Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>,
"E, Nagajyothi" <Nagajyothi.E@amd.com>,
"Tomar, Sourabh Singh" <SourabhSingh.Tomar@amd.com>
Subject: Re: [PATCH] [gdb.base] Convert multi-line function call into in foll-exec.c
Date: Thu, 3 Jun 2021 11:38:49 -0400 [thread overview]
Message-ID: <bc8b451f-966d-d492-555d-34804c0c7ffa@polymtl.ca> (raw)
In-Reply-To: <DM5PR12MB145035DEA1A0352ED04624CE873C9@DM5PR12MB1450.namprd12.prod.outlook.com>
> diff --git a/gdb/testsuite/gdb.base/foll-exec.c b/gdb/testsuite/gdb.base/foll-exec.c
>
> index fea62b06db4..f1b97aca4a4 100644
>
> --- a/gdb/testsuite/gdb.base/foll-exec.c
>
> +++ b/gdb/testsuite/gdb.base/foll-exec.c
>
> @@ -39,18 +39,11 @@ int main (int argc, char ** argv)
>
> memcpy (prog + len - 9, "execd-prog", 10);
>
> prog[len + 1] = 0;
>
> - execlp (prog, /* tbreak-execlp */
>
> - prog,
>
> - "execlp arg1 from foll-exec",
>
> - (char *) 0);
>
> + execlp (prog, /* tbreak-execlp */ prog, "execlp arg1 from foll-exec", (char *) 0);
>
> printf ("foll-exec is about to execl(execd-prog)...\n");
>
> - execl (prog, /* tbreak-execl */
>
> - prog,
>
> - "execl arg1 from foll-exec",
>
> - "execl arg2 from foll-exec",
>
> - (char *) 0);
>
> + execl (prog, /* tbreak-execl */ prog, "execl arg1 from foll-exec", "execl arg2 from foll-exec", (char *) 0);
>
> {
>
> static char * argv[] = {
Since these lines exceed the normal line length limit of 80 columns,
please add a comment above to say why the call is all on one line.
Otherwise, someone may be tempted to "fix it" and put it back on
multiple lines (such a comment may be useful in the other test too).
Thanks,
Simon
next prev parent reply other threads:[~2021-06-03 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 14:57 Kumar N, Bhuvanendra
2021-06-03 15:38 ` Simon Marchi [this message]
2021-06-07 6:31 ` Kumar N, Bhuvanendra
2021-06-07 15:07 ` Simon Marchi
2021-06-07 15:19 ` Kumar N, Bhuvanendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8b451f-966d-d492-555d-34804c0c7ffa@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=AlokKumar.Sharma@amd.com \
--cc=Bhuvanendra.KumarN@amd.com \
--cc=JiniSusan.George@amd.com \
--cc=Nagajyothi.E@amd.com \
--cc=Nitika.Achra@amd.com \
--cc=SourabhSingh.Tomar@amd.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).