From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 2168E3853828 for ; Thu, 3 Jun 2021 15:38:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2168E3853828 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 153Fcn2b003675 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 3 Jun 2021 11:38:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 153Fcn2b003675 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6F5DC1E01F; Thu, 3 Jun 2021 11:38:49 -0400 (EDT) Subject: Re: [PATCH] [gdb.base] Convert multi-line function call into in foll-exec.c To: "Kumar N, Bhuvanendra" , "gdb-patches@sourceware.org" Cc: "George, Jini Susan" , "Achra, Nitika" , "Sharma, Alok Kumar" , "E, Nagajyothi" , "Tomar, Sourabh Singh" References: From: Simon Marchi Message-ID: Date: Thu, 3 Jun 2021 11:38:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 3 Jun 2021 15:38:49 +0000 X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2021 15:38:59 -0000 > diff --git a/gdb/testsuite/gdb.base/foll-exec.c b/gdb/testsuite/gdb.base/foll-exec.c > > index fea62b06db4..f1b97aca4a4 100644 > > --- a/gdb/testsuite/gdb.base/foll-exec.c > > +++ b/gdb/testsuite/gdb.base/foll-exec.c > > @@ -39,18 +39,11 @@ int main (int argc, char ** argv) > > memcpy (prog + len - 9, "execd-prog", 10); > > prog[len + 1] = 0; > > - execlp (prog, /* tbreak-execlp */ > > - prog, > > - "execlp arg1 from foll-exec", > > - (char *) 0); > > + execlp (prog, /* tbreak-execlp */ prog, "execlp arg1 from foll-exec", (char *) 0); > > printf ("foll-exec is about to execl(execd-prog)...\n"); > > - execl (prog, /* tbreak-execl */ > > - prog, > > - "execl arg1 from foll-exec", > > - "execl arg2 from foll-exec", > > - (char *) 0); > > + execl (prog, /* tbreak-execl */ prog, "execl arg1 from foll-exec", "execl arg2 from foll-exec", (char *) 0); > > { > > static char * argv[] = { Since these lines exceed the normal line length limit of 80 columns, please add a comment above to say why the call is all on one line. Otherwise, someone may be tempted to "fix it" and put it back on multiple lines (such a comment may be useful in the other test too). Thanks, Simon