From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13447 invoked by alias); 16 Oct 2017 21:02:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13381 invoked by uid 89); 16 Oct 2017 21:02:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 21:02:39 +0000 Received: from ESESSHC015.ericsson.se (Unknown_Domain [153.88.183.63]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 81.12.07039.D6E15E95; Mon, 16 Oct 2017 23:02:37 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.63) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 16 Oct 2017 23:02:36 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.59] (192.75.88.130) by DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.3; Mon, 16 Oct 2017 21:02:34 +0000 Subject: Re: [RFA 5/6] Return unique_xmalloc_ptr from target_read_stralloc To: Tom Tromey , References: <20171016030427.21349-1-tom@tromey.com> <20171016030427.21349-6-tom@tromey.com> From: Simon Marchi Message-ID: Date: Mon, 16 Oct 2017 21:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171016030427.21349-6-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR13CA0016.namprd13.prod.outlook.com (2603:10b6:300:16::26) To DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a70a97ef-d278-4f1b-dbf9-08d514d939c8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;3:+ocNSbpyC59Yi9sHN2Z4pN1oYQEG1DapmtyQ0BVjJBsZftHyMSwQqWev0LerZy4lAavdQOLU9Giu1iPMeYJnzt3Cp+5oL5xbDast6PvSvTv0AJFEy65KHk2uNgxp5afl5NIlhY5riCz6qKwGE2HjSDbxRLywKowGzKAL45tnlDl71xFfow+49hV0raEquvd5FVviIi05MpyU8dHNWu0DoZ0Nu3p8sYUAFCp9R8yPTH3oLGBxjMmDh1w3OjBIQFzD;25:FeEywAM/FcvjhIFosZqbeM+taa80TsoI2jZwKDff/RvaEHJdqc3E8/urTkXRDqiTGxLccphXGZyHbGXHfCOBs5tUBQiSAOa6hBST64TVM22RrbQ0bE/sS+EnbxncR6z0MSgXWNP23PFZby2hsTquJy+z2idhItWsjgvq3WettrXh2+SYB3OCn2v2/CrWj54hGGOtFrM2q2nUS3dslGbmamaqt7shVyYn0vZdS9FfHVsg/n/lhCuJxd6jvhmQ7jKHL+qHEN6LPE2xw24H1Ut3VLwSQiTQpH2720w3rTldckb0NgXTR9Ds3rw5YhO4ssYulPpc76Gsds78KBqipzMjEVqLLRqZ72SoGQnj66d0Pik=;31:ZgLAjz5mt7UtYV2ZpI+xHYPyYYH89v/a1tj6a3phMUtZ4kJNPKJk6jMYxkFxLEfINbuVkpKmUdh4fsh6UQm8jH8uoKZOSmQseQK1pP6RHqbfh6bI53s+CiB6uwxx96gwVPKJccGx4/EGsI4cnWaJ9xPQHuRZDA01Uzui7vXR5NiUHm8SjmXjcuYB6lso18m0lkXya3iWLSk2wysaseucZ/FBDMggjQh8CySl2I2A9cA= X-MS-TrafficTypeDiagnostic: DBXPR07MB318: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;20:aLEz2OxxQmf19ElSEyJj0FlpPp9JELM/Rnc95M4d8HFFEh9hiXVKao/FT/oen/oRU2p8hmk2XPYukvAKAbwp+W1loHkKGZQAhZ25GCgq5z3FEeMFoeKE9pSI9r/nuMKzybHN553fBOJho0XThT6smhKjkahW9Mhn2XZdZ3n211rUb+CpP4Jx5Vtio47PSYwFi9SIK1vsmRh1BRmOIo6FXwxTBm+5WdZ9t9r1rYcjvRSk1c4Us0Wk6ux+DeDaQx3HMiGiJA4VwUfEFHLkAhSaXJHYSxvSPSO4gDzzaLK5ZdV7GuFvrpIrzdUZpBNb45IzVsNG5lPPMz75SbmmewCjYY+XAK6jDiCBVH+SLhzEedN+Zh7S843RhiwjToCo7MkLX1QKFoDLgBAkaDgphBH7JPc8xhPlCmUyk26MXx4dcEN0nBzOz7803newssUuNEp7blagNBnDtWJaA5p85JtYf/E3XIIaeKuFldV+KiFIHcmYMVk8R2PGBuHjepjlbVWa;4:62fwYaQJHkuH7ZqZE1C5MG9NEfXumiy8/koBrhkolwraQt244DDOrJ3GOpae/8KbjUR8p2wZIHT2dWUhZv/yM/lydyg+OYFEtQu2eyu40Sw2cEKn6YHCVLyP/j9YE9vcUtAoeUF4NtjYtR6lCoG6PwU8A/TCPjX2rx+YLLYvnrqNJeyKyAYbm0h9CnH8n33/uiI3lbPEmt08fiaki2R78baf3/U2JOIkBcJCmybtMMR6jhceUe1w1e3JV3lnR0qn X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB318;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB318; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(346002)(24454002)(377454003)(199003)(377424004)(189002)(230700001)(31696002)(86362001)(50466002)(106356001)(105586002)(31686004)(83506001)(64126003)(33646002)(316002)(8676002)(305945005)(58126008)(478600001)(49976008)(16576012)(25786009)(7736002)(53546010)(4001150100001)(81156014)(97736004)(81166006)(2950100002)(2906002)(189998001)(8936002)(6116002)(3846002)(36756003)(6486002)(65956001)(65826007)(229853002)(16526018)(5660300001)(6666003)(68736007)(53936002)(47776003)(65806001)(23676002)(66066001)(6246003)(101416001)(50986999)(54356999)(76176999)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB318;H:[142.133.49.59];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMTg7MjM6YUJ0ek41UE9SRjNnUWlianJvZ1BLL0JKZlc5?= =?utf-8?B?R05adlJ2M0h6WGlEUGxPcE1TaDFJOTVWcXowV1FPWkt4Ym9HMjR2MythOUpC?= =?utf-8?B?Um5DR1NzMCtyRjdIUHFWRXpYaXIvV2N0Z2NCSVJSQWNncTIxSjlEelQ1TURa?= =?utf-8?B?dzdyNkxyMnRiWUhKM0RkQmJrWTU2czdkYm1yOGdZNmRUNVRzSUtiVVh1Z0Fa?= =?utf-8?B?aDU2ODlBcWl5VlZXRVF5eHc1VHJ4OFJnVVIxWG03dEdYZjhhL25VTFovWEJM?= =?utf-8?B?Zk12VlJXM1ZqdTdDT2hua3FHZjExRVkyS2hzZGp2UnBtN1R1dmF5OGtnV1pB?= =?utf-8?B?TWFCb1dTSFBJKzdMbHRZbUdZVUtna3FqdUpTSUhrSVcxUjFFSXlZMFRKRHZB?= =?utf-8?B?WFhCRm05VXdoMFRMbUt6ZTU2ZThyTzJRc25lL0Z6aVo2SVljS2wwR0dySWJi?= =?utf-8?B?K3FzVWszakNFWmNZdWxKeGFiUzRlakMyc3VsNldjdGtuRHl4WGJGZzRHNGly?= =?utf-8?B?NllxQi95SVMvN0llTWNMVUd1OElpc0NNRCs3WFRnYjV5c1ROVFZmb29HSG9N?= =?utf-8?B?czNIUHlwNWtiZERnc24vd2lraS9OUExMQ3pJcVU5M2o0dVQ2R1BFN0JvM0Z4?= =?utf-8?B?ZWt1d3NJSDZDZnl5eEwrZXNEbXRBVEJvNlcrVFJEUmJpS3BBcXA2UngxeEI0?= =?utf-8?B?dlBkbzcyMDg3b1BjbUd1VEQ4ZEJCWkJnZzFkYU1hNGFhYVZRVGk4RU4yYTMv?= =?utf-8?B?RFRmaGs0T0xUVnFkY0x6YUZESW5nMkE4alNab2U2VkMxbnpPRHJPVVNpRitJ?= =?utf-8?B?YUl5Y0lHZGhwS3dEeEJEWm50UTYwTmx3aXdHaWFQcmFJci9LQ2t0Q2k3SVhZ?= =?utf-8?B?QWZIQll4U3ZDVVF2eEhlNUpoNHRBcVhkUzFsZWZUeVFjMHIybU1mbTFkUTNN?= =?utf-8?B?VHFUNUh4WGZBL2o0ckhWRHA0Q3c3bWxBOHpuQmZXc29oMmxmcGN0d3hZaEZ2?= =?utf-8?B?N2srVlZYem01MzRPQUdkcUhJczJieGQxRlhtd0lEczFSdDgySno3SVl5dnJ1?= =?utf-8?B?YWFUT2pZZWpSWGZua3lKKzhVUndCdXZkQTVjeko2NUlKNjkraXMyZStPcHlq?= =?utf-8?B?blpYdGh6b01tcWZaTkFjWkN0VzVtb3FLRmVmVlZhRXFBZXhBUXBVTXkwelFV?= =?utf-8?B?LzIxSEhiMDdvd1BIZWtWVmgyZVVmZXVmNUhTcmlHMG5OYU5wRXNlODdFcDVZ?= =?utf-8?B?NFRjSWx3VmF6VHhtamVTMi9wb0ptcDh5aEV5Ky91Rm5mQkcySEJuUHJiWXpN?= =?utf-8?B?SDNMejR2MitjS3ZUSGFJK3kyVmxLaEdma05QTkU2bnRTZ2VzS0ExU0tSWW9T?= =?utf-8?B?L2VzWExEN0hrbmlvZ09VTmI3b3M3bTZVaEtyUFllWnY2S2s3Y3h4Q3pYMTBn?= =?utf-8?B?QmFqVDJmdTJna1YrN2p6SlBpdDN4SmhVVU5KaTRwMDVKcG4zTklneGtUMVpq?= =?utf-8?B?SXBBYjVwelNQWVVKZVR0NlRseEJJM3RkUnE0VTdQejltajlwSkRtMHFJaUFy?= =?utf-8?B?QVBSM0ZPRnNlS2JkZUc4aEhhWkJXTkI2WW5mSC9wVmVEQnY4NTdkellBTGp0?= =?utf-8?B?MXViQVBqUGpiQ216RVVTUkRoNnlIS1Z1V0ZNL0c5aWhmZk13d2p0OUs3MGFk?= =?utf-8?B?dHZIbXozcCttdG9DdmZiOWJkc2ZQM3cvVkNlMzVNZXBWWTFiUEl4ZFp2Y2FF?= =?utf-8?B?REhGeDVkbTRPNEsyd0ZwckFqMkJrU0drN2w5N3NSSTBBajgyd0tQa1M1dTVD?= =?utf-8?B?MlBIbkRjeG5Jdk1BZHhmaitWNmttV1pvdnZWbDZuNjNOeGI3alJ6ajAwYWtS?= =?utf-8?Q?aMdlcAQY6E=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;6:Mp49ltiAMcRh8qfh+RIW5WSICEtM7AchO72n6b78SYnrlwcW2P4zclhYFCmwOu5xix8khzMxUkBCKm7FatRWE7FdJMQkFYm3oEQA1LxtdVMlUEiLqVsD6G+aisYRpVSp9M0MQMM8m4a8wMzT40FucEjbhUirjOs2xpaCmBeBPXfXDbaulbQVKa+qY+wNptrv8Ugc7wu2CJQSgPGrBhMOqhi/szznUsIg+VDdyddSJ5UVcCHoEY0LtbpkfOwzCNIqZI8JE9W+QXccgi6EV+kBUIhpgCtDUx1a17qfjaiqpuyzooDBYOEA2cSL3CcFgg8p/FkLx5oQpN64AkAFy2Y+Xg==;5:JNxjR8X431ukywigzRQc3HvIA4uCHfMwE96JuzwONmAOd1/KhrTmdf60nN/AqwKJHdNgr46HF7DdmaDhgXUULWV2ScgCQ5mMbNCOkOiUzySywGCTzI7aEL+mbj0lJMckOYjNJqzFS1NThNeaKfPaCG7zZaqNa/PbOoIPq4RdaUs=;24:bxOy0CTTwckh/TbskzMiX3M//B5RUKoc8bOLcMxg6FsyaI9umidx8W7mtcRIfd/vODYM+To04iO8qabkUgOSipPcJ2UbrdAOekQD60/FRsE=;7:3+sWHnSmK2oYV/RDbfvIOwX+PuJg3dCdvDvC8Ngu/BtRUEkUuJcYyGt7XM96tDFDuohR7o4VliGr7rVW13IZ9Uj2Oe4uQlsc+OGqm4LEOh+Ep5PPW3rwFu9tufnVhi30B0QjaBAlicZuwaGw/iVMWVWar+XCNH1t+lyTfxDV4rLwsfhthw+hfEpxNxUP8dXg2O49ZSRmg9+JRPaJBBM76WZDXu7ngA2hYOXfNS/LAdw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 21:02:34.4122 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a70a97ef-d278-4f1b-dbf9-08d514d939c8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB318 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00470.txt.bz2 On 2017-10-15 11:04 PM, Tom Tromey wrote: > diff --git a/gdb/target.h b/gdb/target.h > index 581c89be54..98bcd789e0 100644 > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -358,9 +358,8 @@ extern LONGEST target_read_alloc (struct target_ops *ops, > are returned as allocated but empty strings. A warning is issued > if the result contains any embedded NUL bytes. */ > > -extern char *target_read_stralloc (struct target_ops *ops, > - enum target_object object, > - const char *annex); > +extern gdb::unique_xmalloc_ptr target_read_stralloc > + (struct target_ops *ops, enum target_object object, const char *annex); You changed the comment above target_read_stralloc in target.c. Can you put /* See target.h. */ and update this one instead? > > /* See target_ops->to_xfer_partial. */ > extern target_xfer_partial_ftype target_xfer_partial; > @@ -2401,7 +2400,7 @@ struct target_ops *find_target_at (enum strata stratum); > unsupported, NULL is returned. Empty objects are returned as > allocated but empty strings. */ > > -extern char *target_get_osdata (const char *type); > +extern gdb::unique_xmalloc_ptr target_get_osdata (const char *type); You can update the comment of this function in the same way, and add "See target.h" in target.c. > > > /* Stuff that should be shared among the various remote targets. */ > diff --git a/gdb/xml-support.c b/gdb/xml-support.c > index 50a062a3a4..7cecaa8d4d 100644 > --- a/gdb/xml-support.c > +++ b/gdb/xml-support.c > @@ -808,8 +808,7 @@ xinclude_start_include (struct gdb_xml_parser *parser, > struct xinclude_parsing_data *data > = (struct xinclude_parsing_data *) user_data; > char *href = (char *) xml_find_attribute (attributes, "href")->value; > - struct cleanup *back_to; > - char *text, *output; > + char *output; You can remove output too. LGTM with those fixed. Simon