From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 355B33858C1F for ; Fri, 10 Mar 2023 16:20:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 355B33858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 31CCF22AC0; Fri, 10 Mar 2023 16:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678465256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=35wcwGf5thU1tTEGgyGNw4/tIN9yNA2rbyRDjKxIqEw=; b=WYFY2lv7l5xpYGprT5gmfiX12iJB8zFLKX5IApLFQD2s6IVvBogH3XYTbdyml/cQYJid4F 38VEoBPPwt5X2s7r4SBQfTL+ERwweimLYWaoIVBW0Po68rJtil/1gurxOIYv6fPoaxfb0p gcIhFP02dIx2z3FDrPFRtNU0H2rCCvY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678465256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=35wcwGf5thU1tTEGgyGNw4/tIN9yNA2rbyRDjKxIqEw=; b=pb7KOxNa6JwIkx389kBXr5jgPKdmdRlss0UUHAirAGTUB/Lg5bhXM51AnhxTm5spmN2+jc llOGP/4NnVn52fDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C42A134F7; Fri, 10 Mar 2023 16:20:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aBSdBehYC2QuIQAAMHmgww (envelope-from ); Fri, 10 Mar 2023 16:20:56 +0000 Content-Type: multipart/mixed; boundary="------------XOZGMt109pBC1RDcPuo0J5sh" Message-ID: Date: Fri, 10 Mar 2023 17:20:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Introduce rust_at_least helper proc Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230301202538.3291371-1-tromey@adacore.com> From: Tom de Vries In-Reply-To: <20230301202538.3291371-1-tromey@adacore.com> X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------XOZGMt109pBC1RDcPuo0J5sh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/1/23 21:25, Tom Tromey via Gdb-patches wrote: > This adds a 'rust_at_least' helper proc, for checking the version of > the Rust compiler in use. It then changes various tests to use this > with 'require'. Hi, just an idea, this could also be implemented without introducing a new proc, using proc version_compare, so instead of: ... require {rust_at_least 1 30} ... we'd do: ... require {version_compare [rust_compiler_version] >= {1 30 0}} ... I needed the additional 0 because my rustc version is: ... $ rustc --version rustc 1.67.1 (d5a82bbd2 2023-02-07) (built from a source tarball) ... and version_compare currently requires comparing version-lists with the same length, but I suppose we could also change that to just assume a 0. WDYT? Thanks, - Tom --------------XOZGMt109pBC1RDcPuo0J5sh Content-Type: text/x-patch; charset=UTF-8; name="tmp.patch" Content-Disposition: attachment; filename="tmp.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLnJ1c3QvcmF3aWRzLmV4cCBiL2dkYi90 ZXN0c3VpdGUvZ2RiLnJ1c3QvcmF3aWRzLmV4cAppbmRleCA5NzZiNzIzODMzZS4uZWM2MTMw NDhiZjAgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLnJ1c3QvcmF3aWRzLmV4cAor KysgYi9nZGIvdGVzdHN1aXRlL2dkYi5ydXN0L3Jhd2lkcy5leHAKQEAgLTE3LDEyICsxNyw3 IEBACiAKIGxvYWRfbGliIHJ1c3Qtc3VwcG9ydC5leHAKIHJlcXVpcmUgYWxsb3dfcnVzdF90 ZXN0cwotCi1zZXQgdiBbc3BsaXQgW3J1c3RfY29tcGlsZXJfdmVyc2lvbl0gLl0KLWlmIHtb bGluZGV4ICR2IDBdID09IDEgJiYgW2xpbmRleCAkdiAxXSA8IDMwfSB7Ci0gICAgdW50ZXN0 ZWQgInJhdyBpZGVudGlmaWVycyByZXF1aXJlIHJ1c3QgMS4zMCBvciBncmVhdGVyIgotICAg IHJldHVybiAtMQotfQorcmVxdWlyZSB7dmVyc2lvbl9jb21wYXJlIFtydXN0X2NvbXBpbGVy X3ZlcnNpb25dID49IHsxIDMwIDB9fQogCiBzdGFuZGFyZF90ZXN0ZmlsZSAucnMKIGlmIHtb cHJlcGFyZV9mb3JfdGVzdGluZyAiZmFpbGVkIHRvIHByZXBhcmUiICR0ZXN0ZmlsZSAkc3Jj ZmlsZSB7ZGVidWcgcnVzdH1dfSB7CmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5y dXN0L3VuaWNvZGUuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucnVzdC91bmljb2RlLmV4cApp bmRleCAyYjQ3NjZiNTU1My4uOWYyN2ZkZGNhZDQgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3Vp dGUvZ2RiLnJ1c3QvdW5pY29kZS5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucnVzdC91 bmljb2RlLmV4cApAQCAtMTYsMTQgKzE2LDkgQEAKICMgVGVzdCByYXcgaWRlbnRpZmllcnMu CiAKIGxvYWRfbGliIHJ1c3Qtc3VwcG9ydC5leHAKLXJlcXVpcmUgYWxsb3dfcnVzdF90ZXN0 cwotCiAjIE5vbi1BU0NJSSBpZGVudGlmaWVycyB3ZXJlIGFsbG93ZWQgc3RhcnRpbmcgaW4g MS41My4KLXNldCB2IFtzcGxpdCBbcnVzdF9jb21waWxlcl92ZXJzaW9uXSAuXQotaWYge1ts aW5kZXggJHYgMF0gPT0gMSAmJiBbbGluZGV4ICR2IDFdIDwgNTN9IHsKLSAgICB1bnRlc3Rl ZCAidGhpcyB0ZXN0IHJlcXVpcmVzIHJ1c3QgMS41MyBvciBncmVhdGVyIgotICAgIHJldHVy biAtMQotfQorcmVxdWlyZSBhbGxvd19ydXN0X3Rlc3RzCityZXF1aXJlIHt2ZXJzaW9uX2Nv bXBhcmUgW3J1c3RfY29tcGlsZXJfdmVyc2lvbl0gPj0gezEgNTMgMH19CiAKICMgRW5hYmxl IGJhc2ljIHVzZSBvZiBVVEYtOC4gIExDX0FMTCBnZXRzIHJlc2V0IGZvciBlYWNoIHRlc3Rm aWxlLgogc2V0ZW52IExDX0FMTCBDLlVURi04CmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRl L2dkYi5ydXN0L3Vuc2l6ZWQuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucnVzdC91bnNpemVk LmV4cAppbmRleCBmODFiZThhMzA3OC4uMDdmNmMyZTdhMjEgMTAwNjQ0Ci0tLSBhL2dkYi90 ZXN0c3VpdGUvZ2RiLnJ1c3QvdW5zaXplZC5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIu cnVzdC91bnNpemVkLmV4cApAQCAtMzEsMTAgKzMxLDcgQEAgaWYgeyFbcnVudG8gJHtzcmNm aWxlfTokbGluZV19IHsKIAogZ2RiX3Rlc3QgInB0eXBlIHVzIiAiID0gLipWPFxcXFt1OFxc XF0+LioiCiAKLXNldCB2IFtzcGxpdCBbcnVzdF9jb21waWxlcl92ZXJzaW9uXSAuXQotIyBU aGUgbmVjZXNzYXJ5IGRlYnVnaW5mbyBnZW5lcmF0aW9uIGxhbmRlZCBpbiAxLjYwLCBidXQg aGFkIGEgYnVnCi0jIHRoYXQgd2FzIGZpeGVkIGluIDEuNjEuCi1pZiB7W2xpbmRleCAkdiAw XSA+IDEgfHwgW2xpbmRleCAkdiAxXSA+PSA2MX0geworaWYge1t2ZXJzaW9uX2NvbXBhcmUg W3J1c3RfY29tcGlsZXJfdmVyc2lvbl0gPj0gezEgNjEgMH1dfSB7CiAgICAgZ2RiX3Rlc3Qg InByaW50IHVzMiIgIiA9IC4qQm94PC4qPiBcXFxbMSwgMiwgM1xcXF0iCiAgICAgZ2RiX3Rl c3QgInB0eXBlIHVzMiIgInR5cGUgPSAuKiIKIH0KZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3Vp dGUvbGliL2dkYi11dGlscy5leHAgYi9nZGIvdGVzdHN1aXRlL2xpYi9nZGItdXRpbHMuZXhw CmluZGV4IGZiNWM5NTNhNmM0Li4zNzFjN2E4NmZjMiAxMDA2NDQKLS0tIGEvZ2RiL3Rlc3Rz dWl0ZS9saWIvZ2RiLXV0aWxzLmV4cAorKysgYi9nZGIvdGVzdHN1aXRlL2xpYi9nZGItdXRp bHMuZXhwCkBAIC0xMTUsNiArMTE1LDcgQEAgcHJvYyB2ZXJzaW9uX2NvbXBhcmUgeyBsMSBv cCBsMiB9IHsKIAkiPCIgICAgIHt9CiAJIjw9IiAgICB7IHJldHVybiBbZXhwciBbdmVyc2lv bl9jb21wYXJlICRsMSA8ICRsMl0gXAogCQkJICAgICAgfHwgW3ZlcnNpb25fY29tcGFyZSAk bDEgPT0gJGwyXV19CisJIj49IiAgICB7IHJldHVybiBbZXhwciBbdmVyc2lvbl9jb21wYXJl ICRsMiA8PSAkbDFdXSB9CiAJZGVmYXVsdCB7IGVycm9yICJ1bnN1cHBvcnRlZCBvcDogJG9w IiB9CiAgICAgfQogCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2xpYi9ydXN0LXN1cHBv cnQuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9saWIvcnVzdC1zdXBwb3J0LmV4cAppbmRleCBmMzcz OWUyY2UwMi4uMTg3MDg3YTQ3Y2IgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvbGliL3J1 c3Qtc3VwcG9ydC5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9saWIvcnVzdC1zdXBwb3J0LmV4 cApAQCAtMTA1LDEwICsxMDUsMTEgQEAgZ2RiX2NhY2hpbmdfcHJvYyBydXN0X2NvbXBpbGVy X3ZlcnNpb24ge30gewogCXNldCBvdXRwdXQgW2xpbmRleCBbcmVtb3RlX2V4ZWMgaG9zdCAi JHJ1c3RjIC0tdmVyc2lvbiAtLXZlcmJvc2UiXSAxXQogCWZvcmVhY2ggbGluZSBbc3BsaXQg JG91dHB1dCBcbl0gewogCSAgICBpZiB7W3JlZ2V4cCAicnVzdGMgKFxbMC05LlxdKykuKlwk IiAkb3V0cHV0IGlnbm9yZSB2ZXJzaW9uXX0geworCQlzZXQgdmVyc2lvbiBbc3BsaXQgJHZl cnNpb24gLl0KIAkJcmV0dXJuICR2ZXJzaW9uCiAJICAgIH0KIAl9CiAJdmVyYm9zZSAiY291 bGQgbm90IG1hdGNoIHJ1c3RjIHZlcnNpb24gb3V0cHV0OiAkb3V0cHV0IgogICAgIH0KLSAg ICByZXR1cm4gMC4wCisgICAgcmV0dXJuIFtsaXN0IDAgMF0KIH0K --------------XOZGMt109pBC1RDcPuo0J5sh--