From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20617.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::617]) by sourceware.org (Postfix) with ESMTPS id 4D5013858D35 for ; Thu, 16 Mar 2023 14:08:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D5013858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8QV3hyvXH6XpqlkYQLXzNuxEgJ3z2R1NuzAhh0POgWk=; b=KN/LeAvIRewdPDmB1fh66Eto9ffZ7uqsKGstLxe2arvf9EMir99hTvrScVL/n6wenJoBpoxSFFzLWJdHLpHakTCNCsVH/kSTPa419FNQKMXgzBMVKXpGjDBCab/8cyBgz03PPxRlgOpjcro5BguiqZumNQtowowfR4hgCTRUETk= Received: from AS8P250CA0001.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::6) by DB9PR08MB8435.eurprd08.prod.outlook.com (2603:10a6:10:3d5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Thu, 16 Mar 2023 14:08:07 +0000 Received: from AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:330:cafe::1d) by AS8P250CA0001.outlook.office365.com (2603:10a6:20b:330::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.31 via Frontend Transport; Thu, 16 Mar 2023 14:08:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT030.mail.protection.outlook.com (100.127.140.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6199.17 via Frontend Transport; Thu, 16 Mar 2023 14:08:07 +0000 Received: ("Tessian outbound b29c0599cbc9:v135"); Thu, 16 Mar 2023 14:08:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6953c9e3e4c0a5d2 X-CR-MTA-TID: 64aa7808 Received: from 186a67af75f8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 91F2D4BD-B2D9-4A1A-81C1-5759CEB15C58.1; Thu, 16 Mar 2023 14:08:00 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 186a67af75f8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Mar 2023 14:08:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kD5CT4lmPxPDKTQFBSm9j6nB9UESuKsKwBEuOAafFJZ0BGfjPEvyANOoZ2oMjIwscSypLYy8ukmwrTW28JjQ4ZDOxtuQei9FOZ6FYjcDHArrJnqIKc7NZRdgLSQ6RTERNuRa2xvwKbvfYsRx2YyqId8lO6h83paEaoY4MI4VwzXEBiekjANctdDU0WDzIEoqimv7EE89FBHQlVcoc7ezZd7tTKpU4MBKla+olt3t+B+bK3YFERfGUNzY4jg1IVGPT1NI6pbICjopRGq9rLplQAKUYfx3iRVHIsr8Tx9cb93TOD0DtD76LtP7JDNmqQlEIW/N6mZ7c2MH80tr3yw7Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8QV3hyvXH6XpqlkYQLXzNuxEgJ3z2R1NuzAhh0POgWk=; b=Kle3jdPj8pIgxfLUjrp+b/c8LC9Sy6Hv7uR8+qT8/WPwOnXgssQHjsrUHorKx5avwq+XIK7jFXO2wyPBXbhCspC7VdUl3Q1AM71jPAuhgzlXReCiHAMJXsbTWNvjO6HKgv8CEeMFrgv8wGBg9huxqFkdYqDf9bG7X9eAPAEqct8MzpViz893NfM5XfeyXFEs/8pJ3CS0zbioW2D6QQ+l+oHIgM2p+1uhKZwU6KI2/QHlafLto4mUkF5zYieEC5PgE6A7YzrNPi7gkoGFs1aoUulL7/1uum+gcr+OYAIFxqkdUpCpWQEznbwY3L6Dtgmwt3Xj2pcL9yRKnp1Iuif0og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8QV3hyvXH6XpqlkYQLXzNuxEgJ3z2R1NuzAhh0POgWk=; b=KN/LeAvIRewdPDmB1fh66Eto9ffZ7uqsKGstLxe2arvf9EMir99hTvrScVL/n6wenJoBpoxSFFzLWJdHLpHakTCNCsVH/kSTPa419FNQKMXgzBMVKXpGjDBCab/8cyBgz03PPxRlgOpjcro5BguiqZumNQtowowfR4hgCTRUETk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB9268.eurprd08.prod.outlook.com (2603:10a6:20b:5a4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Thu, 16 Mar 2023 14:07:56 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6%5]) with mapi id 15.20.6178.031; Thu, 16 Mar 2023 14:07:56 +0000 Message-ID: Date: Thu, 16 Mar 2023 14:07:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Fix build breakage in rs6000-aix-tdep.c Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230316134920.2913561-1-tromey@adacore.com> From: Luis Machado In-Reply-To: <20230316134920.2913561-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA1PR02CA0016.namprd02.prod.outlook.com (2603:10b6:806:2cf::22) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB9268:EE_|AM7EUR03FT030:EE_|DB9PR08MB8435:EE_ X-MS-Office365-Filtering-Correlation-Id: 5505ad54-edf3-4685-e843-08db2627de10 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XCVO8GVKY0AADuGIZyBHzDCpBvxZtbpQeuceGdx6DS1AABnAVXMInk11LktKD3hJc4MAmg6bBT61JxRnfic4GatmhpSflDDX6AQYJJ0GdqSnTjRo7RVCQ6rAUiJdtM5oQuxKZ0g+m4kXXlm9dwhABVaPQnwz+9tzsvtI0so2hRfiovjLdIXwIaW+4t/cmIPi5nU7YwnHfFeCfgjGZpKiru2JFwzB2phSs6/v7NyuIQGcLjSIHoCp3voQ1UZ8E4CwITGef2Vxv77UmKpZAjsq8cyp4/sTV1j6RDLDZsog/FbeeILe7i7dzXoxB18pqsjx32l7VfvOYsjRioUdxYq6ZgheM8UpU0o4nz2WQRuW66a2GePwn/Hzk26ex74kvNkgaqBhyTQwV2/6i21P4Qr8HSMTQzGHBiupM47amDrAPm3Tz6ZBl7Ftoaft7CfHE2jDUINx9tc31lPmgVsynTd2f6ITQqLbTv7+qrbWOX729feK4frz1LlcCdtvGVxij5SbEkQ13HgmIztJRADIkRspt0R9qAad8cSzqCTWfiIcvYFkbeZ7EZ5SRZxkvx/JDnjA7ECDf7lLu+n5+tP8D6SpfxByTiv7DBnqppty10wO2+mCgvbvdiUqe+LUB5xghF5/tRjuAA84fTZNN6wk7qT5YSNAh2ZJeyYb1hWK75l865xTlDo7VDWwA1JTqEMD3UaQ3IuQGTYQxI7fZltTNkTkeDuURW8Sw40p/aCY0sYqayo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(396003)(346002)(39860400002)(136003)(376002)(451199018)(31696002)(66946007)(478600001)(66556008)(66476007)(26005)(41300700001)(44832011)(5660300002)(83380400001)(186003)(8936002)(2616005)(6666004)(6512007)(316002)(6506007)(8676002)(6486002)(36756003)(86362001)(38100700002)(53546011)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9268 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: daeea336-7157-421b-ed69-08db2627d708 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eQ36/1twKxsiB+2C3B/rNsQoUfAXVxobNonigqvhBu4XgEj73WWTWbx66+lmD9DeBekY3yP2B2/XeWXi0eYXkW2leBpyZjGRisksZGYVroBJ/K9u3z0WUaLs77JgL8J/pffTEPrdp748sCxQIRNHir4wJFS/hxGIZTH2pG32DHOZ8QNEIFuyOcKsucP7IT9+4broHiM4p3SI8pZ2/fSfem00Uix97lNVQVnitrcQZVedrpQIj05WFwTjgnkqumqMg7neBajx/yFg/KQtn9WC2bgwtNoEOzagqzOTQD/5C4Ao0IYzxMhUssSgDxESsNL32bL7i+CVqMqDbjY/9M3DWl5RI7f7XdRCAQCTClQF4zamG77Yoqby+y8amt4JJIEkz7MNVMzLnVEb+J3ZbPJX+s2Sh43AQTO/XItwovN5bWlVDFSQ4GNoQa4f7m/4e44+gB3awW98dWafrSrVQgHH2Nmybd8ozmbZOuSsVC5Nnd3B9NBVLSA0+20Lo8GMvNWiU0boZXRQ7HgnClEkN4SqfQGfEz5G4GPJy8DcfgMU7UsbLCJocRFBJsG39H0tjbDDtHNUECFG29BcDbtR7jkJFx41Ga/AbcVBuZ6uOM1hPn5p9ReJMnhdxgXsa/JqLjlXzfLS5a7+EPcNi4IE/s8EkYiqdVEMRJu3Tmv0T4pc/33WLGFsp0/okwGX6+F4LE1XHjtbsT8trkGUOOdYjTydkXJ0bvHezLQUKy4/4bri87I= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199018)(46966006)(40470700004)(36840700001)(83380400001)(478600001)(2616005)(40460700003)(5660300002)(336012)(6512007)(2906002)(6506007)(26005)(53546011)(40480700001)(36756003)(186003)(44832011)(6486002)(6666004)(86362001)(47076005)(41300700001)(36860700001)(82310400005)(81166007)(8676002)(31686004)(82740400003)(70206006)(70586007)(31696002)(8936002)(356005)(316002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 14:08:07.3662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5505ad54-edf3-4685-e843-08db2627de10 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8435 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/16/23 13:49, Tom Tromey via Gdb-patches wrote: > A recent change to rs6000-aix-tdep.c broke the build. This patch > fixes it by declaring a few target descriptions in ppc-tdep.h and then > not including the various features .c files in rs6000-aix-tdep.c. > --- > gdb/ppc-tdep.h | 6 ++++++ > gdb/rs6000-aix-tdep.c | 5 ----- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/gdb/ppc-tdep.h b/gdb/ppc-tdep.h > index fe41baef149..db4e53205a6 100644 > --- a/gdb/ppc-tdep.h > +++ b/gdb/ppc-tdep.h > @@ -450,4 +450,10 @@ struct ppc_inferior_data > > extern ppc_inferior_data * get_ppc_per_inferior (inferior *inf); > > +extern const struct target_desc *tdesc_powerpc_vsx64l; > +extern const struct target_desc *tdesc_powerpc_vsx64; > +extern const struct target_desc *tdesc_powerpc_vsx32; > +extern const struct target_desc *tdesc_powerpc_altivec64; > +extern const struct target_desc *tdesc_powerpc_altivec32; > + > #endif /* ppc-tdep.h */ > diff --git a/gdb/rs6000-aix-tdep.c b/gdb/rs6000-aix-tdep.c > index c56e5a384e4..d4a7b22bc4f 100644 > --- a/gdb/rs6000-aix-tdep.c > +++ b/gdb/rs6000-aix-tdep.c > @@ -40,11 +40,6 @@ > #include "trad-frame.h" > #include "frame-unwind.h" > > -#include "features/rs6000/powerpc-altivec32.c" > -#include "features/rs6000/powerpc-vsx32.c" > -#include "features/rs6000/powerpc-altivec64.c" > -#include "features/rs6000/powerpc-vsx64.c" > - > /* If the kernel has to deliver a signal, it pushes a sigcontext > structure on the stack and then calls the signal handler, passing > the address of the sigcontext in an argument register. Usually The patch makes it build again for me (with --enable-targets=all).