From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tom@tromey.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFA 6/6] Return unique_xmalloc_ptr from target_fileio_read_stralloc
Date: Mon, 16 Oct 2017 21:07:00 -0000 [thread overview]
Message-ID: <bd75ecd6-b688-86f3-199b-9e5b0d0f8244@ericsson.com> (raw)
In-Reply-To: <20171016030427.21349-7-tom@tromey.com>
On 2017-10-15 11:04 PM, Tom Tromey wrote:
> Change target_fileio_read_stralloc to return unique_xmalloc_ptr and
> fix up the callers. This removes a number of cleanups.
>
> ChangeLog
> 2017-10-15 Tom Tromey <tom@tromey.com>
>
> * linux-tdep.c (linux_info_proc, linux_find_memory_regions_full)
> (linux_fill_prpsinfo, linux_vsyscall_range_raw): Update.
> * target.c (target_fileio_read_stralloc): Update.
> * sparc64-tdep.c (adi_is_addr_mapped): Update.
> * target.h (target_fileio_read_stralloc): Return
> unique_xmalloc_ptr.
> ---
> gdb/ChangeLog | 9 +++++
> gdb/linux-tdep.c | 117 +++++++++++++++++++++--------------------------------
> gdb/sparc64-tdep.c | 12 ++----
> gdb/target.c | 8 ++--
> gdb/target.h | 4 +-
> 5 files changed, 64 insertions(+), 86 deletions(-)
>
> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
> index 8751718e84..d890083fa2 100644
> --- a/gdb/linux-tdep.c
> +++ b/gdb/linux-tdep.c
> @@ -749,13 +749,10 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
> if (cmdline_f)
> {
> xsnprintf (filename, sizeof filename, "/proc/%ld/cmdline", pid);
> - data = target_fileio_read_stralloc (NULL, filename);
> - if (data)
> - {
> - struct cleanup *cleanup = make_cleanup (xfree, data);
> - printf_filtered ("cmdline = '%s'\n", data);
> - do_cleanups (cleanup);
> - }
> + gdb::unique_xmalloc_ptr<char> cmdline
> + = target_fileio_read_stralloc (NULL, filename);
> + if (cmdline)
> + printf_filtered ("cmdline = '%s'\n", cmdline.get ());
> else
> warning (_("unable to open /proc file '%s'"), filename);
> }
> @@ -788,10 +785,10 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
> if (mappings_f)
> {
> xsnprintf (filename, sizeof filename, "/proc/%ld/maps", pid);
> - data = target_fileio_read_stralloc (NULL, filename);
> - if (data)
> + gdb::unique_xmalloc_ptr<char> map
> + = target_fileio_read_stralloc (NULL, filename);
> + if (map)
if (map != NULL)
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2017-10-16 21:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 3:04 [RFA 0/6] more cleanup removals Tom Tromey
2017-10-16 3:04 ` [RFA 6/6] Return unique_xmalloc_ptr from target_fileio_read_stralloc Tom Tromey
2017-10-16 21:07 ` Simon Marchi [this message]
2017-10-16 3:04 ` [RFA 1/6] Use std::vector in end_symtab_get_static_block Tom Tromey
2017-10-16 20:18 ` Simon Marchi
2017-10-16 21:59 ` Tom Tromey
2017-10-20 15:33 ` Ulrich Weigand
2017-10-20 16:47 ` Pedro Alves
2017-10-23 16:16 ` Ulrich Weigand
2017-10-24 13:55 ` Tom Tromey
2017-10-24 14:41 ` [pushed] " Ulrich Weigand
2017-10-16 3:04 ` [RFA 3/6] Remove cleanup from ppc-linux-nat.c Tom Tromey
2017-10-16 20:28 ` Simon Marchi
2017-10-16 3:04 ` [RFA 4/6] Simple cleanup removals in remote.c Tom Tromey
2017-10-16 20:43 ` Simon Marchi
2017-10-16 21:14 ` Tom Tromey
2017-10-16 21:37 ` Simon Marchi
2017-10-16 21:50 ` Tom Tromey
2017-10-16 22:35 ` Pedro Alves
2017-10-16 23:00 ` Tom Tromey
2017-10-16 23:34 ` [PATCH 1/2] Introduce string_appendf/string_vappendf (Re: [RFA 4/6] Simple cleanup removals in remote.c) Pedro Alves
2017-10-19 3:11 ` Simon Marchi
2017-10-19 3:13 ` Simon Marchi
2017-10-30 0:16 ` Simon Marchi
2017-10-30 11:48 ` Pedro Alves
2017-10-16 23:38 ` [PATCH 2/2] remote.c, QCatchSyscalls: Build std::string instead of unique_xmalloc_ptr " Pedro Alves
2017-10-19 3:17 ` Simon Marchi
2017-10-30 11:49 ` Pedro Alves
2017-10-16 3:04 ` [RFA 5/6] Return unique_xmalloc_ptr from target_read_stralloc Tom Tromey
2017-10-16 21:02 ` Simon Marchi
2017-10-16 3:04 ` [RFA 2/6] Remove some cleanups from probe.c Tom Tromey
2017-10-16 20:26 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd75ecd6-b688-86f3-199b-9e5b0d0f8244@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).