From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57091 invoked by alias); 16 Oct 2017 21:07:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56120 invoked by uid 89); 16 Oct 2017 21:07:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 21:07:41 +0000 Received: from ESESSHC021.ericsson.se (Unknown_Domain [153.88.183.81]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 51.82.07039.B9F15E95; Mon, 16 Oct 2017 23:07:39 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.81) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 16 Oct 2017 23:07:38 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.59] (192.75.88.130) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Mon, 16 Oct 2017 21:07:37 +0000 Subject: Re: [RFA 6/6] Return unique_xmalloc_ptr from target_fileio_read_stralloc To: Tom Tromey , References: <20171016030427.21349-1-tom@tromey.com> <20171016030427.21349-7-tom@tromey.com> From: Simon Marchi Message-ID: Date: Mon, 16 Oct 2017 21:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171016030427.21349-7-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR12CA0049.namprd12.prod.outlook.com (2603:10b6:3:103::11) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7db773b5-ec01-4f05-0bdf-08d514d9ee0b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;3:RnlAePJi7DXfHGUWtpUvCrClIdEdthdTS8h1Tio9YoHbNpd5VBKW7B6H/LDxxOojHRONNT8olgoCtrQyJ5E+v6h2V3q7Fs8boI1juxrkMBGUcGuvqz/29vah09Hlk/qNT4ScjgKQ3meGvpXGcRkwLuQphN+T/EwRXsW3woekOruy2ylnt3x7u5+R0VbuSFkKeZ26/9+tjpU5tAZurRqbzdXBoFb62FaklefowLJLrYplxL86F34kKDl92FoDQodS;25:zZ3a8oEbCvUG1HQ1yIfUblX50h5a9Y1ksmuAdnDZ0SXwVykWc0SDkytdFGnjhdPN83dfdVtjipHFBWfIhFs9vodJGY6zjgrHfDZf+T5GAgpTBZupneffkg8de1sfefoswenAaSXDUIm4M+4spaR6v4zP1DlisgLc7fshFjk4RgpeX5fgFdt0i3lhhWg+6/wJ7TmPFB7ma/ToMVGcy563lFQFNweI4feE05TfSNDIyY0ZAwCCVPdLj+8WnzVbCKcS8Uvl183UvxZ9m+NpPkzkmsjaaX6OkZDVfx2pGnD2UuftK7UKbpbi5bd5Jv+UIHPqm1WIAJ1zWjvmHNfhTxY//q/42aas9jD3iLIT/t+LTPI=;31:cZoUhnw/zTu9EJnZ6Fi29j96EAz5P/viKJ4/zGdRaEZ02uFwsKvJl9mZxUWvg8EiAhQ/sWneuheJVhzsJBYYEzYpk1z+nQasA/vnb0cNFK4BqXLWmTKt/KJWhcE1WpnkVPbLOdwc9lWN04ftfpfUBo5uVgndPs71heYodyfN8pOh1XmOZRz6I58CBuJ7U9C+b6WuYHtg2NNV9RoFhNACO34aO1DpD4jEl5erQTfbnXs= X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;20:+ggTfkpsBDHPMIs7TksfbPx0K1GnEG3PwvfAG9o17aMMlHIXKI05rZ9QNvc3wXZdYusMnpeW8xLxYk48whjFM4KltW9JgWzpbVgv2fREN/Xo2mvgen9EJJq+8ehBLEBKVMhDnx9KJqX4yBepKa4j028HqkJzp/l6ETxGjf9ArJqhItJK1S3893Eig+Hk2EYqdwVjGs6xp0xweZQLQqy/tIMEsC01hs6YOlmXltsVh+wwrY6VF3hNLAM42+9kJklLs+vFXdmnDSeFoH8Nq6VVd5AP0sOBEXmjpK84EHON/qzEdJWpKtIkSrNutU6ttRgPRrXdX+uPAccQQ3JBBFU9/+KY4t1yF/kwxJmoK1YIfLuckvIlWZDGZDupcBerTY1yOyi6noNTCIPP6tnMzF/NFYzp0qfveEUUzb0fMP/qi2yBekF/p/bEgngXvnLRr7/UoYVucKXZi4p6JBkzlNAUCao/EPdeuiagPvQoCwkVJECSg0yLmKbA+8PQTgvcWdN1;4:BL7WBpTlzX9QzQfVNGdxDf6RBMY7E71kQXpPyvgzMEW9J1pR91P2KXmbCMBlGkOiyyqFxpB1UJYo/QAY9G+wL5bMuAgWDGWMw4dACSD/ULtT/tSYeY8+rtgoFgvDXUqz9n7PB5q4WUmszlxCgkk/4UjVptvqqyY03E3CaaJiGE4pexYcRhLaYDVbaktp9AB19/xjjSOwuVci5m1HAS0qmcaOa9ZZT0EGfCQBihqgxFGzSY9wYIPuwYXkLGWksmGV X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB312;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB312; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(346002)(39860400002)(199003)(189002)(377424004)(377454003)(24454002)(54534003)(189998001)(83506001)(64126003)(81166006)(8676002)(81156014)(16526018)(8936002)(50466002)(31686004)(6486002)(49976008)(6116002)(31696002)(3846002)(229853002)(53936002)(65806001)(6246003)(66066001)(97736004)(36756003)(58126008)(16576012)(305945005)(7736002)(316002)(65956001)(86362001)(50986999)(5660300001)(33646002)(6666003)(2950100002)(53546010)(47776003)(478600001)(23676002)(65826007)(54356999)(76176999)(105586002)(106356001)(101416001)(4001150100001)(2906002)(230700001)(25786009)(68736007)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB312;H:[142.133.49.59];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTI7MjM6NjArN1Zsd1VaNmRDV01Fa1VISGlrVlBaTTNY?= =?utf-8?B?S0o4TXkxNHMzMitHaTBEb3U3TXh5VklUNHptS3Z5d0h4V28rRDFXODRjYTFw?= =?utf-8?B?ZDdsVFFHaThEUXE3bU5iVjJvcmRFY0xOS2lLSFZ0ZDZGclNrOVpsLzVad0Zl?= =?utf-8?B?WWdUeE55dkMrTTVVN1kzZXdkVnhHdXovQzcrbjZYUmxMSnZsMTMrVGxQMXlX?= =?utf-8?B?UFU2YW1NU2ExYjRDS0xoNk5BWkZiVk5qOHFDcGlRUlhlZ2ZoQ0pTOEdwYTNy?= =?utf-8?B?SkNRNUJ0QVNxOExuaEV6TUJHNG82TjliNUZMNjZja3V3Z1d4RjVSUGU1TGts?= =?utf-8?B?SDAxNDFIWEpzZ2QzMURaeGhYcEtvZUZsNmViV2xySkdaZGFyVGVGblNSL09Q?= =?utf-8?B?VjdMK3B4dG13bFVuT05XKzlYSVh5a2wxRmREN2pqWVBaWFV2OGxQRnh4TXpy?= =?utf-8?B?NUxKTHdGZ0MvU1QrZXpOL0Y4QTJVbkQvYkpHNXlWU3NIa0w3YzY0NFhJYWky?= =?utf-8?B?R2Z5bDlZN0dRK1RZNHh4emtNNnZXMTRDZTg2cm4xcDNSdHQzcTdrU1VQV1oy?= =?utf-8?B?YkoxSndwY1VjRndsUzV5dHVkaUYxNkJVempGblBxcU9uM1FYaGpLL01BcE1h?= =?utf-8?B?aE9wY0JTeXBzYko1VG5xUjUwa3NnRGRLekNRanNzNVo1N3k4cm5RNFphTFNo?= =?utf-8?B?TjY3UnBlZFRtUWt0VEcwOHQ2cWIwNm90SXRKblJ0VmVpeHliYlZYN3ozbHVl?= =?utf-8?B?d3dvOHdrUkdGSDBzVUU1amhRTzRIZUgzdU1UaE8zc1N1bTFTMWp4Zk02cGMx?= =?utf-8?B?Nk9lUzNYbCtFYTQ3UUhadVpXY2VmSktGTW9nVGNjWGJkamNwTzY1NTdYeEt5?= =?utf-8?B?cUtvK1dJVzFpNDNXU1lYRmJ3emN3bnFNWUVIcUVUbUhLQ0VwY1piQXFIcmpP?= =?utf-8?B?OUlUQUhpQ0VmejNvL1lhdjJPZGM4U2lSR0JnQTJnMkF1RTVRSS8yTFZUckxx?= =?utf-8?B?NjhNb3ZZRnA3Vnp5MW9ZOHRuZkxmV3lGdUQ1aHJuYnArZHQ1ckhnenBLYXZX?= =?utf-8?B?cFRiYmlVY3ZOcW41cG13K1MvTlhIRWVObjJVMWxFOVdqNDFSUEJJd1U0SG1q?= =?utf-8?B?c1BTNUxOUmhEaXBoK2YxZmJEazlnbCtueElReGg4dmhoUUlEbEpZODhVMEVE?= =?utf-8?B?R1BiWG1mdy9aSVN6Y1NMY1dyOEkwc09wcUhxTmtyZGl3d3dHbWFFU0k2ODZX?= =?utf-8?B?RHQ0L3ZEdFY5ZXR5S2p4cTZEZzBZM1dEWUpWNjFnM2htSUNnZ2dFWGZoL1pD?= =?utf-8?B?QkEvTkZ1clFsaHJmOHIwRHE1MGNodlN4cjJvVVNCcmpvb2Y1U3BsUHlkK2pr?= =?utf-8?B?WFRUZDB3U1NRNExpT2E3MXIvNnFmeUxHbStjT1dtemIvOTBWVUNsVjVYMm1Z?= =?utf-8?B?eUg0NnFPTXFvQzVhQlAxenQ3RmkveWttRVJKR2VNMldHb0Y2REhVNzhtMGZK?= =?utf-8?B?bU9LelNuQ3RjSUxvaTlNYmlSbng0OTJpeVFZN3lwY3dlWTZEVUV2V2xmK0Ey?= =?utf-8?B?a0lYSHZIKzRhSmtDNDE0elN2V20vbmRtMEh6R29tSUNpaVBPeng4L3hzM2w5?= =?utf-8?B?NjNqc1MwZUlxY1dMMUxIOW5MSzlYUTEyL1o4clZhL05XWm5XTnB4Ulk1cGpH?= =?utf-8?B?VU5URkQ2Nlk5SlFhTGRmYzRUejNhZHJ6Vlo2TDl6RnRVY1BFZTFhT0hiMUJS?= =?utf-8?B?bTlicm9mZjZDZ1lWbVplUUJQSGRwSXdYVnY4ZUw5TThXNXVLV1djU3AyRWFS?= =?utf-8?B?NDJBc21aM1hpVkkyMWsvSTI3VFM1NTluZEJCcDZDS25YSTdBdFo1NnMrdDhR?= =?utf-8?B?cElsWWNGS0MvckZTa3VHb0hVVGFPWFRrK29qeGJ4WFJNam5VYnU2d2tYdzV2?= =?utf-8?B?LzMzN3BNUVE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;6:qxJOtjtfGLQrkS8RiFuK18wnLqHT1cQraSB3FiTlFy080Fd8X5i0o+YVcRY0+6AeXyYnBCQzBQOStGBlTfGyzmIqvmfli1m3T7iS3R9LK7z7uYPl321W0xuNfEgf1L20AxaVU8FOfjWCJutv3ep/Xh6O25CXxqlmYDE6oZ6uM1If/fponbvPS6IMQKkOwHt7E+YSNaobREKKquH0tqN0rWFu0cIL9TWVKMvbhmM9Phm7X25RMOXR3OxUMqUchfc2kUwpKoLKJ6PX3Djcsqm7jfxDNfSF0vuWhGlBElwAp/V/gw3O9FsHxTEtT0BjOgCoq8QXlIHLL0wsgoStBMhYBQ==;5:oKsqI9hHS5HVJKnYFCBNm5B4pk/r2Y8DjGVyvD2+mqEY49d1SA4Jgr3l5YNqqfllJHGdIMVOV9hkqNA6E/mxpcAroHbzyoUdiarmCNFQaZUzDx2ErOrshkyN0KMdgkUph9WIykXvaMSeXeqrt6Clbre4/BdOn+5OhzMUCM+TNpA=;24:flMNG1Sf8XCpoly76HFEhAmZfeEas8YOlWpnf8lYDNs9xWO3oU7xgtftIJJ/Fc7ayuWKHO+D4cwhsL3RG+aikWsNSs7Ixvmi/G49K59FnNE=;7:egwAFR8iRTRJOogr7H2G5kP37TitBqqejvggupFeK2KJ9Qxh5IMeLEnIbCR0O2f+Qz+h6Dc8npw77bUhABPaDws+MYB3iFNJsYlfgc61VsWoYau2C4pZCUCw4FkQEOqMCGDdRPRBoOCbr9yVQtVKg2uJAuTCYXjndQ6o17Ltcb4sYgEpGl+WKlQt0fT79JozfLj1IBGBezhDjyNJVAq0k7YHT99mXMPq62FT/8BcBUs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 21:07:37.0703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00471.txt.bz2 On 2017-10-15 11:04 PM, Tom Tromey wrote: > Change target_fileio_read_stralloc to return unique_xmalloc_ptr and > fix up the callers. This removes a number of cleanups. > > ChangeLog > 2017-10-15 Tom Tromey > > * linux-tdep.c (linux_info_proc, linux_find_memory_regions_full) > (linux_fill_prpsinfo, linux_vsyscall_range_raw): Update. > * target.c (target_fileio_read_stralloc): Update. > * sparc64-tdep.c (adi_is_addr_mapped): Update. > * target.h (target_fileio_read_stralloc): Return > unique_xmalloc_ptr. > --- > gdb/ChangeLog | 9 +++++ > gdb/linux-tdep.c | 117 +++++++++++++++++++++-------------------------------- > gdb/sparc64-tdep.c | 12 ++---- > gdb/target.c | 8 ++-- > gdb/target.h | 4 +- > 5 files changed, 64 insertions(+), 86 deletions(-) > > diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c > index 8751718e84..d890083fa2 100644 > --- a/gdb/linux-tdep.c > +++ b/gdb/linux-tdep.c > @@ -749,13 +749,10 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args, > if (cmdline_f) > { > xsnprintf (filename, sizeof filename, "/proc/%ld/cmdline", pid); > - data = target_fileio_read_stralloc (NULL, filename); > - if (data) > - { > - struct cleanup *cleanup = make_cleanup (xfree, data); > - printf_filtered ("cmdline = '%s'\n", data); > - do_cleanups (cleanup); > - } > + gdb::unique_xmalloc_ptr cmdline > + = target_fileio_read_stralloc (NULL, filename); > + if (cmdline) > + printf_filtered ("cmdline = '%s'\n", cmdline.get ()); > else > warning (_("unable to open /proc file '%s'"), filename); > } > @@ -788,10 +785,10 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args, > if (mappings_f) > { > xsnprintf (filename, sizeof filename, "/proc/%ld/maps", pid); > - data = target_fileio_read_stralloc (NULL, filename); > - if (data) > + gdb::unique_xmalloc_ptr map > + = target_fileio_read_stralloc (NULL, filename); > + if (map) if (map != NULL) Otherwise, LGTM. Simon