From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48868 invoked by alias); 28 Jun 2018 13:33:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48854 invoked by uid 89); 28 Jun 2018 13:33:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Jun 2018 13:33:29 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5SDXMdc015401 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 28 Jun 2018 09:33:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 2D8FD1EF28; Thu, 28 Jun 2018 09:33:22 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 9B21E1E529; Thu, 28 Jun 2018 09:33:21 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 28 Jun 2018 13:33:00 -0000 From: Simon Marchi To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [RFA] Make dwarf2_free_objfile static Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00680.txt.bz2 On 2018-06-27 18:31, Andrew Burgess wrote: > I don't know if we have a preference for static_cast over C style > casting these days? Indeed, static_cast provides some compile-time safety, so I guess we should always prefer that over the C-style cast. > Otherwise, FWIW, this looks like a nice clean up. Indeed, LGTM (with possibly the cast fixed up). Thanks, Simon