From: John Baldwin <jhb@FreeBSD.org>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/5] Unify getpkt methods in remote.c
Date: Mon, 28 Aug 2023 14:15:16 -0700 [thread overview]
Message-ID: <be5f7ea4-16cf-72e2-483a-f8abbec6575d@FreeBSD.org> (raw)
In-Reply-To: <20230828-getpkt-cleanup-v2-0-7dd1a6974b94@adacore.com>
On 8/28/23 1:05 PM, Tom Tromey via Gdb-patches wrote:
> This series unifies the various getpkt methods in remote.c, and
> applies a little bit of bool-ification as well.
>
> ---
> Changes in v2:
> - Default 'forever' to false
> - Link to v1: https://inbox.sourceware.org/gdb-patches/20230828-getpkt-cleanup-v1-0-0f3da220530c@adacore.com
>
> ---
> Tom Tromey (5):
> Remove getpkt_sane
> Remove expecting_notif parameter from getpkt_or_notif_sane_1
> Use bool in getpkt
> Unify getpkt and getpkt_or_notif_sane
> Default getpkt 'forever' parameter to 'false'
>
> gdb/remote.c | 243 +++++++++++++++++++++++++----------------------------------
> 1 file changed, 104 insertions(+), 139 deletions(-)
> ---
> base-commit: b8a175b415454df6a039ba0b5d2ff13c3c180275
> change-id: 20230828-getpkt-cleanup-126c625821bf
>
> Best regards,
All lgtm.
Reviewed-by: John Baldwin <jhb@FreeBSD.org>
--
John Baldwin
prev parent reply other threads:[~2023-08-28 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 20:05 Tom Tromey
2023-08-28 20:05 ` [PATCH v2 1/5] Remove getpkt_sane Tom Tromey
2023-08-28 20:05 ` [PATCH v2 2/5] Remove expecting_notif parameter from getpkt_or_notif_sane_1 Tom Tromey
2023-08-28 20:05 ` [PATCH v2 3/5] Use bool in getpkt Tom Tromey
2023-08-28 20:05 ` [PATCH v2 4/5] Unify getpkt and getpkt_or_notif_sane Tom Tromey
2023-08-28 20:05 ` [PATCH v2 5/5] Default getpkt 'forever' parameter to 'false' Tom Tromey
2023-08-28 21:15 ` John Baldwin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be5f7ea4-16cf-72e2-483a-f8abbec6575d@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).