From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=uZh4=D7=suse.de=tdevries@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 4EF9B3858C3A
	for <gdb-patches@sourceware.org>; Mon, 14 Aug 2023 20:54:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EF9B3858C3A
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out1.suse.de (Postfix) with ESMTPS id 21BCE21963;
	Mon, 14 Aug 2023 20:54:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1692046483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=z7cDhE7D1ZEYcLR5O6s3YrTV5oSpchk7OFqyklXk3S0=;
	b=ftApFOCzVKOl/jTlSrpjYroyKtun+2jftPSgbaIDCMYs0B/saPjxILmXzqZAPzONb/W2n9
	XTWLy94NMU4gahnPqLubVyLoepVPDiHugO/DpCwHgb64ub8LrmmzSgwL2u2rZyt/J/U/GV
	+3UFTvDc9hW0YAVQXwpjCQt2wkkxGDE=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1692046483;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=z7cDhE7D1ZEYcLR5O6s3YrTV5oSpchk7OFqyklXk3S0=;
	b=aRLLBt2Uv+uoVTyUjmgLy/shpctQ5EH3alMYfsQNXviXAG3NmVX2WWWWvHrYPd3C5ckl7y
	kLh8BNxux3dPOACQ==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0E835138E2;
	Mon, 14 Aug 2023 20:54:43 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id RzlOApOU2mR8HwAAMHmgww
	(envelope-from <tdevries@suse.de>); Mon, 14 Aug 2023 20:54:43 +0000
Message-ID: <be6be36f-af95-c508-8363-90381a8ecbac@suse.de>
Date: Mon, 14 Aug 2023 22:54:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] [gdb/build] Fix YYSTYPE and yyalloc odr violation
Content-Language: en-US
To: Tom Tromey <tom@tromey.com>,
 Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
References: <20230814122441.20617-1-tdevries@suse.de>
 <87edk5zjtv.fsf@tromey.com>
From: Tom de Vries <tdevries@suse.de>
In-Reply-To: <87edk5zjtv.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 8/14/23 18:10, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> When building gdb with -O2 -flto I run into:
> Tom> ...
> Tom> ada-exp.c.tmp:576:7: error: type ‘union YYSTYPE’ violates the C++ One \
> Tom>   Definition Rule [-Werror=odr]
> Tom> ...
> 
> Tom> Fix this by renaming to ada_YYSTYPE and likewise for other .y files.
> 
> Tom> Likewise for yyalloc.
> 
> It is fine by me but did you try it with byacc?

Thanks for the review.

I hadn't, but have now, and ran into this PR ( 
https://sourceware.org/bugzilla/show_bug.cgi?id=30760 ), reproduces with 
and without this patch.

Committed.

Thanks,
- Tom

> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom