Re: [PATCH] gdb/python: allow Value.format_string to return styled output

[Simon Marchi <simon.marchi@polymtl.ca>]

LGTM, just two small comments:

> @@ -725,6 +728,7 @@ valpy_format_string (PyObject *self, PyObject *args, PyObject *kw)
>      return NULL;
>    if (!copy_py_bool_obj (&opts.static_field_print, static_members_obj))
>      return NULL;
> +  bool styling_p = (styling_obj != nullptr) && PyObject_IsTrue (styling_obj);

Can styling_obj actually be nullptr?

> @@ -1023,9 +1030,16 @@ with_test_prefix "format_string" {
>    # Perform C Tests.
>    if { [build_inferior "${binfile}" "c"] == 0 } {
>      with_test_prefix "lang_c" {
> -      set current_lang "c"
> -      prepare_gdb "${binfile}"
> -      test_all_common
> +      save_vars { env(TERM) } {
> +	# We run all of these tests in an environment where styling
> +	# could work, but we only expect the final call to
> +	# test_styling to actuall produce any styled output.

actuall -> actually

Simon