From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id CA419385E02C for ; Sat, 28 May 2022 13:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA419385E02C Received: by mail-lj1-x233.google.com with SMTP id 24so106593ljw.11 for ; Sat, 28 May 2022 06:35:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to; bh=CiW/SW7+hn5mMhUMTM3y9SfH6WGstroho9TYdrk54qw=; b=WnZyYldYMX/gP6WNhR4lq6vjKfOBOUt87RskskGgVgHqq0rZYMW3VBlTN0HvoF3FXQ II2LQ9oPcJsIz1KxUPgMoYRmlXLVr8bVqo4maBeI6Q3k2KMxsPXR7cNvAWamEQ0Q8twC Irgv7csHq0L3bazzwNZJ0Kos4hpssPg5U2Y7UGCsugCreHWo1dkSfKMFEQ78+y3HcX1j KlEBnTro0aXBpQ4uN3TzjvBalx4g6F0IsOkk8WZIXB2a80n94b8g0p3f2M4csxe9ujCa MAQfrCY8rRvCRIjAkg7r4fqDMDFBt0E/jPWE38clOIc4hiwXJkHz+HfpFltnfFJ6QR15 khiw== X-Gm-Message-State: AOAM533kfzI+keYPgRuLbr8fy/5+UBDkLGUJ7qU+yOD5s1nUoGm13clk ZWh1Yp4+Ro02ZXCKCct+FDRs5FssdYsb X-Google-Smtp-Source: ABdhPJxguVJzCSHZPvKWDYT3qPWlkToNx1oQBgzwxMx2WavapQd3s3pclPbZ+hfAvP2xhdZK/3rwYA== X-Received: by 2002:a2e:a273:0:b0:253:e0e7:7948 with SMTP id k19-20020a2ea273000000b00253e0e77948mr22582571ljm.463.1653744940214; Sat, 28 May 2022 06:35:40 -0700 (PDT) Received: from [192.168.1.10] (83.11.64.124.ipv4.supernova.orange.pl. [83.11.64.124]) by smtp.gmail.com with ESMTPSA id b14-20020ac2410e000000b0047255d211b3sm1327671lfi.226.2022.05.28.06.35.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 May 2022 06:35:39 -0700 (PDT) Message-ID: Date: Sat, 28 May 2022 15:35:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] gdb/python doc: Add enable property to the unwinder example Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20220528115509.3865342-1-ptsneves@gmail.com> <20220528115509.3865342-3-ptsneves@gmail.com> <83sfotludj.fsf@gnu.org> From: Paulo Neves In-Reply-To: <83sfotludj.fsf@gnu.org> X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 May 2022 13:35:44 -0000 On 5/28/22 14:22, Eli Zaretskii wrote: >> Date: Sat, 28 May 2022 13:55:09 +0200 >> From: Paulo Neves via Gdb-patches >> Cc: Paulo Neves >> >> The enable property is now also in the example code making it clear how >> it is used and how it influences the operation of an unwinder. >> --- >> gdb/doc/python.texi | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi >> index 5b7fba798a9..cb148d9b0ea 100644 >> --- a/gdb/doc/python.texi >> +++ b/gdb/doc/python.texi >> @@ -2796,6 +2796,10 @@ class FrameId(object): >> class MyUnwinder(Unwinder): >> def __init__(....): >> super(MyUnwinder, self).__init___() >> + # If set to True the unwinder will be enabled. >> + # If upon registration the enable property is True, the unwinder will be usable immediately. > This last line is too long for an @example, please break it into two. Done > >> + # gdb or code may change value. >> + self.enabled = >> >> def __call__(pending_frame): >> if not : > Other than that, this needs to be reviewed by someone who knows about > programming unwinders in Python. > > Thanks. Ok, I will be waiting then and ping according to the guidelines. I added a 3rd patch that also corrects a mistake in the module name mentioned in the example and doc.