Re: [PATCH 1/2, ver2] PowerPC, Fix-test-gdb.base-store.exp

[Carl Love <cel@linux.ibm.com>]

Ulrich, Andrew:

On Mon, 2023-10-30 at 16:44 +0000, Ulrich Weigand wrote:
> Andrew Burgess <aburgess@redhat.com> wrote:
> 
> > I think adding this to the commit message would be a great
> > improvement.
> > But also, you said:
> > 
> > > Now, as Carl fixed the PowerPC DWARF mapper to fix some test
> > > case regressions that showed up on POWER10, he added correct
> > > mappings for all registers including VSCR.  This then caused
> > > unwinding out of the signal trampoline to start working
> > > correctly, which in turn exposed the pre-existing infrun.c bug
> > > in handling signal call trampolines.
> > 
> > As part of the commit message at this point I'd like to see the
> > name of
> > at least one (if the number is small, I'd list them all though)
> > test(s)
> > that required this change in order to keep working correctly.
> 
> I believe this showed up in sigstep.exp, but Carl would know for
> sure.
> Carl, please update the commit message as requested by Andrew.

I have updated the commit message adding some of the additional detail
that Ulrch gave on the underlying issue.  The commit message now starts
with an overview of the initial issue to be fixed in store.exp followed
by a discussion of the underlying bug that was then exposed by test
sigstep.exp.  The commit message then goes on with the detailed
discussion of the fix for both issues.  Finally, it summarizes the
failures in both store.exp and sigstep.exp that are fixed.  Hopefully
this updated commit message clearly explains the two separate issues
that the patch addresses. 

Thanks for the feedback from Andrew and the help from Ulrich to improve
the commit message. I will post the update patch for your review.

                            Carl