From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 1AE5E3858C41 for ; Mon, 7 Aug 2023 23:11:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AE5E3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4173A20114; Mon, 7 Aug 2023 23:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691449905; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lerkFEcvhQqNdyDsDpVWLRkMG+1L69u8XlHcW2IBjyM=; b=aAonK7+D1s+NqnOvGZ6SA86j/uHUFEkXHdfq75JlapcB1muCmEc/biz6zSXKEZ1ZUH5noH E45fsSl4SXn1T9ppJH8S8M4FJmvxa0B7BthkQPrxRMIp8EofSDfmOKITa9Twtj9ZZTHYpl RhW0KOW+hAi8e+Peex/slk8XxhXBT78= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691449905; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lerkFEcvhQqNdyDsDpVWLRkMG+1L69u8XlHcW2IBjyM=; b=DtcDcIEBQRpg6ImHfC7n9W1+c7h6P72BjnzRVrKcRAoh3N9u2WmyB+iLXHv9mRTof3RwkC mEduOTxoXRR2hrDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 222E913910; Mon, 7 Aug 2023 23:11:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9Y87BzF60WQSEAAAMHmgww (envelope-from ); Mon, 07 Aug 2023 23:11:45 +0000 Content-Type: multipart/mixed; boundary="------------nR8Mkv7yEyGzaJ1FWBkOQcxb" Message-ID: Date: Tue, 8 Aug 2023 01:11:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/build] Fix build breaker with -std=c++11 Content-Language: en-US To: John Baldwin , Simon Marchi , Tom de Vries via Gdb-patches Cc: Tom Tromey References: <20230806235915.18746-1-tdevries@suse.de> <51561E9D-24F0-48CB-A563-50F29C2966D9@polymtl.ca> <6682f2e5-f6ab-7b54-ba95-a60c217b6c86@suse.de> <21fba7d9-3f98-9ecd-2eb6-b574c23fd5db@FreeBSD.org> From: Tom de Vries In-Reply-To: <21fba7d9-3f98-9ecd-2eb6-b574c23fd5db@FreeBSD.org> X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------nR8Mkv7yEyGzaJ1FWBkOQcxb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/7/23 20:01, John Baldwin wrote: > On 8/7/23 10:15 AM, Tom de Vries via Gdb-patches wrote: >> On 8/7/23 16:35, Simon Marchi wrote: >>> >>> >>> On August 6, 2023 7:59:15 p.m. EDT, Tom de Vries via Gdb-patches >>> wrote: >>>> When building with -std=c++11 I run into: >>>> ... >>>> gdb/dwarf2/cooked-index.c: In member function \ >>>>    ‘void cooked_index::start_writing_index(dwarf2_per_bfd*)’: >>>> gdb/dwarf2/cooked-index.c:469:10: error: lambda capture initializers >>>> only \ >>>>    available with -std=c++14 or -std=gnu++14 [-Werror] >>>>            ctx = std::move (ctx)] () >>>>            ^~~ >>>> ... >>>> >>>> Fix this by capturing a copy instead: >>>> ... >>>>      = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd, >>>> ctx] () >>>> ... >>>> >>>> Tested on x86_64-linux. >>>> >>>> Reported-By: Tom Tromey >>> >>> When we encounter things like this, should we add some greppable TODO >>> comment to record an actionable item for when we switch to a more >>> recent C++ version? >> >> Hi Simon, >> >> thanks for the review. >> >> Fine by me, added comment. > > An alternative that is slightly more work but might be nicer long term > would be > to #if on the C++ version, so for example: > > #if __cplusplus >= 201402L >   = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd, >                                                 ctx = std::move (ctx)] () > #else >   = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd, ctx]) () > #endif > Thanks for the suggestion. Updated patch attached. Thanks, - Tom --------------nR8Mkv7yEyGzaJ1FWBkOQcxb Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-build-Fix-build-breaker-with-std-c-11.patch" Content-Disposition: attachment; filename="0001-gdb-build-Fix-build-breaker-with-std-c-11.patch" Content-Transfer-Encoding: base64 RnJvbSBkZGJlOGMzYzhhODY2NWU3N2Y5ZWJiMTA4YzU2MjdhNmViZWNiODFmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IE1vbiwgNyBBdWcgMjAyMyAwMDozMTowNCArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IFtnZGIvYnVpbGRdIEZpeCBidWlsZCBicmVha2VyIHdpdGggLXN0ZD1jKysxMQpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29u dGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKV2hlbiBidWlsZGluZyB3aXRoIC1zdGQ9 YysrMTEgSSBydW4gaW50bzoKLi4uCmdkYi9kd2FyZjIvY29va2VkLWluZGV4LmM6IEluIG1l bWJlciBmdW5jdGlvbiBcCiAg4oCYdm9pZCBjb29rZWRfaW5kZXg6OnN0YXJ0X3dyaXRpbmdf aW5kZXgoZHdhcmYyX3Blcl9iZmQqKeKAmToKZ2RiL2R3YXJmMi9jb29rZWQtaW5kZXguYzo0 Njk6MTA6IGVycm9yOiBsYW1iZGEgY2FwdHVyZSBpbml0aWFsaXplcnMgb25seSBcCiAgYXZh aWxhYmxlIHdpdGggLXN0ZD1jKysxNCBvciAtc3RkPWdudSsrMTQgWy1XZXJyb3JdCiAgICAg ICAgICBjdHggPSBzdGQ6Om1vdmUgKGN0eCldICgpCiAgICAgICAgICBefn4KLi4uCgpGaXgg dGhpcyBieSBjYXB0dXJpbmcgYSBjb3B5IGluc3RlYWQgd2hlbiB1c2luZyAtc3RkPWMrKzEx OgouLi4KICAgID0gZ2RiOjp0aHJlYWRfcG9vbDo6Z190aHJlYWRfcG9vbC0+cG9zdF90YXNr IChbdGhpcywgcGVyX2JmZCwgY3R4XSAoKQouLi4KClRlc3RlZCBieSBidWlsZGluZyB3aXRo IGFuZCB3aXRob3V0IC1zdGRjPSsrMTEgb24geDg2XzY0LWxpbnV4LgoKUmVwb3J0ZWQtQnk6 IFRvbSBUcm9tZXkgPHRvbUB0cm9tZXkuY29tPgotLS0KIGdkYi9kd2FyZjIvY29va2VkLWlu ZGV4LmMgfCA3ICsrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvZHdhcmYyL2Nvb2tlZC1pbmRleC5jIGIv Z2RiL2R3YXJmMi9jb29rZWQtaW5kZXguYwppbmRleCBkZjgyZTg2YjY5MC4uOTJlZjBlMzVj NWUgMTAwNjQ0Ci0tLSBhL2dkYi9kd2FyZjIvY29va2VkLWluZGV4LmMKKysrIGIvZ2RiL2R3 YXJmMi9jb29rZWQtaW5kZXguYwpAQCAtNDY2LDcgKzQ2NiwxMiBAQCBjb29rZWRfaW5kZXg6 OnN0YXJ0X3dyaXRpbmdfaW5kZXggKGR3YXJmMl9wZXJfYmZkICpwZXJfYmZkKQogICAgICBz dGFydGVkLCBiZWNhdXNlIGl0IG1heSBjYWxsICd3YWl0Jy4gICovCiAgIG1fd3JpdGVfZnV0 dXJlCiAgICAgPSBnZGI6OnRocmVhZF9wb29sOjpnX3RocmVhZF9wb29sLT5wb3N0X3Rhc2sg KFt0aGlzLCBwZXJfYmZkLAotCQkJCQkJICAgY3R4ID0gc3RkOjptb3ZlIChjdHgpXSAoKQor I2lmIF9fY3BsdXNwbHVzID49IDIwMTQwMkwKKwkJCQkJCSAgIGN0eCA9IHN0ZDo6bW92ZSAo Y3R4KQorI2Vsc2UKKwkJCQkJCSAgIGN0eAorI2VuZGlmCisJCQkJCQkgICBdICgpCiAJewog CSAgbWF5YmVfd3JpdGVfaW5kZXggKHBlcl9iZmQsIGN0eCk7CiAJfSk7CgpiYXNlLWNvbW1p dDogOGQyN2IwOWQwODc3OTgyZGMyMjUyYzAxYTNmMWQ5YzYzMWIyZDZlYgotLSAKMi4zNS4z Cgo= --------------nR8Mkv7yEyGzaJ1FWBkOQcxb--