From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C309C3896C1C for ; Fri, 22 Jan 2021 20:43:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C309C3896C1C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10MKhFoN020468 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Jan 2021 15:43:20 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10MKhFoN020468 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3C0711E939; Fri, 22 Jan 2021 15:43:15 -0500 (EST) Subject: Re: [PATCH] gdb/testsuite: eliminate gdb_suppress_tests mechanism To: Tom Tromey , Simon Marchi via Gdb-patches References: <20210120210618.3937071-1-simon.marchi@polymtl.ca> <874kj8ojlp.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Fri, 22 Jan 2021 15:43:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <874kj8ojlp.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 22 Jan 2021 20:43:15 +0000 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2021 20:43:22 -0000 On 2021-01-22 2:30 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> There is a lot of support code for the test suppression mechanism. But > Simon> as far as I know, it is not useful. The gdb_suppress_tests proc is in > Simon> fact disabled with this comment that has been there since: > > Simon> return; # fnf - disable pending review of results where > Simon> # testsuite ran better without this > > Simon> I suggest to just remove everything related to test suppression, that > Simon> removes some unnecessary complexity from the support code and the tests. > > I think removing this makes sense. > Thanks for doing this. > > Tom > Thanks, pushed. Simon