public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>
To: Michael Eager <eager@eagerm.com>,
	"gdb-patches@sourceware.org"	<gdb-patches@sourceware.org>
Cc: Vinod Kathail <vinodk@xilinx.com>,
	Vidhumouli Hunsigida	<vidhum@xilinx.com>,
	Nagaraju Mekala <nmekala@xilinx.com>
Subject: RE: [Patch, microblaze]: Add slr and shr regs
Date: Tue, 10 Jun 2014 13:51:00 -0000	[thread overview]
Message-ID: <c0151d38-382c-4af8-9b97-555ef50e0c0b@BN1AFFO11FD014.protection.gbl> (raw)
In-Reply-To: <539613D1.4020808@eagerm.com>



-----Original Message-----
From: Michael Eager [mailto:eager@eagerm.com] 
Sent: Tuesday, June 10, 2014 1:37 AM
To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze]: Add slr and shr regs

On 06/09/14 12:31, Ajit Kumar Agarwal wrote:
>
>
> -----Original Message-----
> From: Michael Eager [mailto:eager@eagerm.com]
> Sent: Monday, June 09, 2014 11:59 PM
> To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
> Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
> Subject: Re: [Patch, microblaze]: Add slr and shr regs
>
> On 06/09/14 10:26, Ajit Kumar Agarwal wrote:
>>
>> Sorry for the late response as I was on Vacation. Please find my response inlined below.
>
> It's difficult to figure out which are your responses and which is text quoted from previous email.
>
> AJA:
>> SLR/SHR was added in MicroBlaze v8.10.a, EDK 13.1.  XMD's gdbserver stub releasesed before this design throws an error mentioning gdb is not supported  for the version below v8.10.a, EDK 13.1.
>
> I don't know what this means.  XMD released with EDK 9.1i doesn't generate any such error message and works with mb-gdb built from FSF sources.
>
> Ajit:   The necessity of the XMD to generate such error message came when we have shr and shl support in Microblaze v8.10.a, EDK 13.1  to have downward compatibility. The XMD you are using is quite old.
>
> There are several ways to make gdb to adapt to different target architectures.
> Pedro described the preferred solution, but there are others.
>
> Ajit: We would surely like to implement as suggested by Pedro.
>
> MJE:
>>>> I do not have any way to test microblaze-linux.  Make sure that your patch works with both -target=microblaze-linux and -target=microblaze-xilinx-gnu, and with both EDK 9.1i and >>14.2i, at a minimum.  Please provide documentation which show that this patch works using gdbserver on a Linux target, as well as using XMD.
>
> AJA:
>> Same as the Explanation above. The native Linux support patch is not yet  submitted and we will submitting the patches after this patch.  XMD testing is done and it works fine.
>
> This isn't responsive to my request.
>
> The only way that your patch makes sense is if you build gdbserver for 
> a microblaze-linux target.  If this is not what you are doing, you 
> need to explain (as previously
> requested) how you are building and testing the patch.
>
> Ajit:  I might have misunderstood the question. We build the  binutils 
> which comes with gdb with target as microblaze-xilinx-elf.  We do the following, 1. Invoke the XMD with gdbserver on.

>>XMD is not running gdbserver built with these sources, is it?

Yes XMD is not running gdbserver built with these sources.

>>Your patch modified files under gdb/gdbserver.  When you build binutils/gdb with -target=microblaze-xilinx-elf, these files are not built.

The patch related to building gdbserver with the latest FSF Sources will be the next patch which I am going to  submit for review. 

>
>>It would have helped if you previously answered my question about what targets you were building by saying -target=microblaze-xilinx-elf, rather than just "Microblaze target".

Thanks for this!! 

> 2. XMD connects to the target.
> 3. Invoke mb-gdb with the executables to debug.
> 4.Invoke command " tar remote localhost:1234".
> 5. Invoke the command "load"
> 6. Set the breakpoints and do the normal debugging.
>
> Kindly be more explicit regarding this question.
>
> MJE:
>> When you resubmit the patch, please make sure that you check for whitespace errors.  Make sure that you address all of the questions and comments made here and by other reviewers.
>
> Please respond to all comments.
>
> Ajit: Sure I will addressed all the comments.
>
>


-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

  reply	other threads:[~2014-06-10 13:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23  6:54 Ajit Kumar Agarwal
2014-05-23  7:34 ` Michael Eager
2014-05-23  9:47   ` Ajit Kumar Agarwal
2014-05-23 22:42     ` Michael Eager
2014-05-26 10:04       ` Ajit Kumar Agarwal
2014-05-27  6:34         ` Michael Eager
2014-05-27  7:46           ` Ajit Kumar Agarwal
2014-05-27  8:53             ` Pedro Alves
2014-06-09 17:26               ` Ajit Kumar Agarwal
2014-06-09 17:57                 ` Pedro Alves
2014-06-09 19:35                   ` Ajit Kumar Agarwal
2014-05-29  7:20             ` Michael Eager
2014-06-05 15:54             ` Michael Eager
2014-06-09 17:26               ` Ajit Kumar Agarwal
2014-06-09 18:28                 ` Michael Eager
2014-06-09 19:31                   ` Ajit Kumar Agarwal
2014-06-09 20:06                     ` Michael Eager
2014-06-10 13:51                       ` Ajit Kumar Agarwal [this message]
2014-06-10 14:12                         ` Michael Eager
2014-06-10 14:49                           ` Ajit Kumar Agarwal
2014-06-10 15:27                             ` Michael Eager
2014-06-12  8:34                               ` Ajit Kumar Agarwal
2014-05-23  8:32 ` Yao Qi
2014-05-23 20:33   ` Ajit Kumar Agarwal
2014-05-23  8:44 ` Pedro Alves
2014-05-23 20:36   ` Ajit Kumar Agarwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0151d38-382c-4af8-9b97-555ef50e0c0b@BN1AFFO11FD014.protection.gbl \
    --to=ajit.kumar.agarwal@xilinx.com \
    --cc=eager@eagerm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nmekala@xilinx.com \
    --cc=vidhum@xilinx.com \
    --cc=vinodk@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).