From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116849 invoked by alias); 29 Aug 2018 17:01:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115081 invoked by uid 89); 29 Aug 2018 17:00:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr1-f43.google.com Received: from mail-wr1-f43.google.com (HELO mail-wr1-f43.google.com) (209.85.221.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 17:00:50 +0000 Received: by mail-wr1-f43.google.com with SMTP id z96-v6so5498456wrb.8 for ; Wed, 29 Aug 2018 10:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=qEXmEqUsQDplmoqoNZhbIgn8qxWQaZ38elmGB1k/UtI=; b=eGOiwopg5VEe91IscAfNKZkpMglO5Z5vM5kui9l/wTJqKWApa3rys6uh2nXdDolL3f Wdz1KvQ/NrucID6FWqWli4+DAfr2j4ls8Sn/PESwyaTVfLmYnyVbRFQqE9KXxHC+G6jL pR1ZxwWKjMkRFDtRV5bp81O4HIz0w+5qO8EQkjBzg4l2VJWWL+bq2Hp9gMlAA7bz59Bm ec2OXVpHYS3bTlpCpBMJHihrl0WHToaY2OVQd4lArTDN1igZ1uogqAiPPZpNfmqzkDdu TN1HZuH0dh4PadWJCOImfx8iE/3EasvjdTB7xTqNrxlmn2XZaU8uMZIZot7JS/CFQm3G +D9A== Return-Path: Received: from ?IPv6:2a01:e35:2eac:2a80:7c7d:2022:97ba:9bab? ([2a01:e35:2eac:2a80:7c7d:2022:97ba:9bab]) by smtp.gmail.com with ESMTPSA id c3-v6sm6743812wrm.56.2018.08.29.10.00.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 10:00:42 -0700 (PDT) Subject: Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue To: Tom Tromey , Simon Marchi Cc: Eli Zaretskii , Pedro Alves , gdb-patches@sourceware.org References: <56c5911c-e0ba-5a17-64bb-3634af60a07d@gmail.com> <18eaf339-ca0a-061c-4a17-b837e6ef81a2@redhat.com> <83wosa2yos.fsf@gnu.org> <56153263-c5e6-45ce-8629-c5a77cf17f5b@gmail.com> <87va7t3zuk.fsf@tromey.com> From: SiZiOUS Message-ID: Date: Wed, 29 Aug 2018 17:01:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <87va7t3zuk.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-08/txt/msg00756.txt.bz2 Le 29/08/2018 à 18:24, Tom Tromey a écrit : >>>>>> "Simon" == Simon Marchi writes: >>> And I know, the MinGW/MSYS original project is maintained but almost >>> deprecated in favour of MinGW-w64/MSYS2 project. But I really need XP >>> support for my needs. >>> I proposed this patch because it's really simple and not intrusive, >>> but you're right, how many people uses that old MinGW/MSYS project? > Simon> If the missing definition is indeed a mingw bug, but there is really > Simon> no way of getting a new mingw release with that fixed because the > Simon> project is unmaintained (but still useful to some people), I would not > Simon> be against a patch like what you proposed. I would however add a > Simon> clear comment for why this is needed, so that if some day we > Simon> officially decide not to support this mingw, we can remove it. > > Also, is there any downside to the original patch? > If not then I think we might as well accept it, subject to Simon's > request here. Nope, as it only includes the winerror.h header file just in case that the ERROR_IO_PENDING is undefined. So if ERROR_IO_PENDING is defined (as it would be normally), my patch does nothing. > > Tom