From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90443 invoked by alias); 5 Jan 2018 18:34:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90434 invoked by uid 89); 5 Jan 2018 18:34:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=libsegfaultso, internalerrors, libsegfaultexp, internal-errors X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Jan 2018 18:34:41 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5485EC00DBB0; Fri, 5 Jan 2018 18:34:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72B966A039; Fri, 5 Jan 2018 18:34:36 +0000 (UTC) Subject: Re: [PATCH] Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7) To: gdb-patches@sourceware.org References: <1513305092-8610-1-git-send-email-palves@redhat.com> Cc: Andrew Pinski From: Pedro Alves Message-ID: Date: Fri, 05 Jan 2018 18:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513305092-8610-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00114.txt.bz2 On 12/15/2017 02:31 AM, Pedro Alves wrote: > At https://sourceware.org/bugzilla/show_bug.cgi?id=18653#c7, Andrew > reports that the fix for PR gdb/18653 made GDB useless if you preload > libSegFault.so, because GDB internal-errors on startup: > ... > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * common/signals-state-save-restore.c > (save_original_signals_state): New parameter 'quiet'. Warn if we > find a custom handler preinstalled, instead of internal erroring. > But only warn if !quiet. > * common/signals-state-save-restore.h > (save_original_signals_state): New parameter 'quiet'. > * main.c (captured_main_1): Move save_original_signals_state call > after option handling, and pass QUIET. > > gdb/gdbserver/ChangeLog: > yyyy-mm-dd Pedro Alves > > * server.c (captured_main): Pass quiet=false to > save_original_signals_state. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Alves > > * gdb.base/libsegfault.exp: New. I've pushed this in, both master and 8.1 branch. Thanks, Pedro Alves