From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 3483A3858406 for ; Wed, 23 Feb 2022 00:07:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3483A3858406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 358EE9D02B; Wed, 23 Feb 2022 00:07:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K3GZJ0ngCz4WNw; Wed, 23 Feb 2022 00:07:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645574856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfEN9GhCVYrbipvqlMhogC51Vco1z/tIwoaXvxTqtZw=; b=h8lxjvozu6S/TsA+xDvibRlh8GXaL4ZxOPbS0S92z5xWtmz2u/Lu4ZWc2/NxZWCk0OWuEV 1iFUo/JtEhltiFH9IEJQXwm1/7h6ik2lioZeUFqoKMgRb7utp1YCM32HK4aemLi24TqRdS 6x7O0CaCY1RaJHbihUSdHu3C68kps1IgZCdTLuO7a/IWp0av7B6dg8401OxI3Lr2gf/uQP +vUJ68mtU8jj8oXmZ8m+z2KR4SlgbjNFgxRiXROAeTzL9O4iEkL9sLX4ljAzZkeVTuPylA L28uSX8acVG0vmIti8lrBNqtg7frz0ehl8z71equF7Ij5TT0pK7QSZVc0t27WA== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id A5E31268A2; Wed, 23 Feb 2022 00:07:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 22 Feb 2022 16:07:34 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220121201631.63530-1-jhb@FreeBSD.org> <20220121201631.63530-7-jhb@FreeBSD.org> <2a4bc2e5-a7b9-a448-1988-75c53dd61c83@polymtl.ca> From: John Baldwin Subject: Re: [PATCH v5 06/15] do_target_wait_1: Clear TARGET_WNOHANG if the target isn't async. In-Reply-To: <2a4bc2e5-a7b9-a448-1988-75c53dd61c83@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645574856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfEN9GhCVYrbipvqlMhogC51Vco1z/tIwoaXvxTqtZw=; b=d5sDGh2CkhnVdSU67cckRtMAFwikVzvAOvGsZ4PXXw34yOxQDt8wg3GuYXq5IQ1GeWeAhD 0lgUrxXmYChXXcZG8Q6t0GpDmoJ7sBiX0xMejs3aPLWpuaNPRWS1lzZ26CaioMIAm5+qdw Zbw/tI7BHTYwevR4skjz9fPZQU5uSS8OcBcGQh1gMv38ZJ9FkZAzb3YhkViQA8RuJhGjCU 94K3YP2Xdo1/oNkbLrIgTVbhrb519C0tSNz52CXtncVxZvjlbGu01qiJOR9uNy9ySSVa/6 f2nQimpb4V4gW5UFAvDq7BB1GTS7zHLuTOcNsJpw9QkoJbl9GDuvzwjv29Ux1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645574856; a=rsa-sha256; cv=none; b=acQPsx8R5mygD68Mllg4Eh0YsGkRz6Ep2QnWVHmoqEf0lS/0PVM2DsJ0kuO76akJ/a1W8e xhShi1EFtoiez0827qrrFNnCriz/8ff9WAT4sQ65ADZgwbW6rGAH3aWMFYX0bXsj3qjja7 3slQx7xTtnUV9bGyxDu1shEgxIcTxFlMka0moLqix9DVEdid3se2CIg9+Imdh49+NP8ym+ rGbxG998FnSwUtrcNGrvfVjnxuU4l/ntFqZosW+kIHwcih0qDszV1MlxCzUHZ73vRE8WDs Ya74cjfzOlM3ti9ZbEXWm0180vS1tAKpSK94qonNjBk5pwBTKkeNPAdI1G7yjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2022 00:07:45 -0000 On 2/22/22 2:38 PM, Simon Marchi wrote: > > > On 2022-01-21 15:16, John Baldwin wrote: >> Previously, TARGET_WNOHANG was cleared if a target supported async >> mode even if async mode wasn't currently enabled. This change only >> permits TARGET_WNOHANG if async mode is enabled. >> --- >> gdb/infrun.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/infrun.c b/gdb/infrun.c >> index 5959c3e6658..f8ccafd287d 100644 >> --- a/gdb/infrun.c >> +++ b/gdb/infrun.c >> @@ -3629,7 +3629,7 @@ do_target_wait_1 (inferior *inf, ptid_t ptid, >> >> /* We can't ask a non-async target to do a non-blocking wait, so this will be >> a blocking wait. */ >> - if (!target_can_async_p ()) >> + if (!target_is_async_p ()) >> options &= ~TARGET_WNOHANG; >> >> if (deprecated_target_wait_hook) > > Hi John, > > Starting with this patch I see a bunch of multi-target tests start > to fail, for instance gdb.multi/multi-target-info-inferiors.exp. > > This is on plain Ubuntu 20.04 amd64. > > I don't have much time now, but I can provide more info later if > needed. Hmmm, I had tested this in a Ubuntu amd64 VM and hadn't seen any regressions. However, this change can be easily reverted without reverting the rest of the series I believe. Looking at my logs from before, it seems that all of the gdb.multi/multi-target* tests didn't report a status (either on stock master or in the branch with these changes) which explains why I didn't see a regression earlier: (gdb) PASS: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2 testcase /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-re-run.exp completed in 0 seconds Running /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-continue.exp ... testcase /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-continue.exp completed in 0 seconds Running /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-info-inferiors.exp ... testcase /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-info-inferiors.exp completed in 0 seconds Running /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-interrupt.exp ... testcase /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-interrupt.exp completed in 0 seconds Running /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-no-resumed.exp ... testcase /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-no-resumed.exp completed in 0 seconds Running /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-ping-pong-next.exp ... testcase /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-ping-pong-next.exp completed in 0 seconds Running /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-thread-find.exp ... testcase /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-target-thread-find.exp completed in 0 seconds Running /home/john/work/git/gdb/obj/gdb/testsuite/../../../gdb/testsuite/gdb.multi/multi-term-settings.exp ... I have no idea why these tests didn't run in my VM. If you revert just this commit and keep the rest of the series do you see any other regressions? -- John Baldwin