From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126016 invoked by alias); 19 Oct 2016 21:50:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125976 invoked by uid 89); 19 Oct 2016 21:50:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:935, sk:express X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Oct 2016 21:50:39 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB9103F1E4; Wed, 19 Oct 2016 21:50:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9JLoaPS005215; Wed, 19 Oct 2016 17:50:36 -0400 Subject: Re: [PATCH v2 05/31] 'struct expression *' -> gdb::unique_xmalloc_ptr To: Simon Marchi References: <1476839539-8374-1-git-send-email-palves@redhat.com> <1476839539-8374-6-git-send-email-palves@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 19 Oct 2016 21:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00586.txt.bz2 On 10/19/2016 07:45 PM, Simon Marchi wrote: > On 2016-10-18 21:11, Pedro Alves wrote: >> [1] - I'd like to set the rule that types named with an "_up" suffix >> are unique_ptr typedefs. > > I don't mind. It sounds funny when saying it out loud though, I read it as " u. p.". :-) > my goal > from now on will be to introduce a class named "whats". :-) > It ends up a > bit cryptic for somebody that doesn't know about that convention > (newcomers), but then expression_unique_ptr might be a bit long. > > I did a quick grep for various converted struct names allocation > keywords, I see there is still a > > bp_location = XNEWVEC (struct bp_location *, bp_location_count); > > Does that need to be converted too? You mean converted to "new"? No, because that is an array of pointers, not array of bp_location objects. Thanks, Pedro Alves