From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70950 invoked by alias); 24 Aug 2018 20:06:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70938 invoked by uid 89); 24 Aug 2018 20:06:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Aug 2018 20:06:42 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7OK6a34004879 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 24 Aug 2018 16:06:40 -0400 Received: by simark.ca (Postfix, from userid 112) id 9AE5B1EB43; Fri, 24 Aug 2018 16:06:35 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id C29281EB37; Fri, 24 Aug 2018 16:06:34 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 24 Aug 2018 20:06:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix 8.2 regression in gdb.python/py-evthreads.exp w/ gdbserver (PR gdb/23379) In-Reply-To: References: <20180824174616.3306-1-palves@redhat.com> <81f69245-7bad-a9f8-58ef-7f8ead16e71f@ericsson.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00604.txt.bz2 On 2018-08-24 15:47, Pedro Alves wrote: > On 08/24/2018 08:44 PM, Pedro Alves wrote: > >> >> Yeah, I definitely prefer copy-init when possible. In this >> case I'd prefer doing that as a separate patch though, because >> that's not something that the regression fix is adding, and >> also grepping around I see there's a lot of similar instances >> that can all get the same treatment. I'll post a patch >> for that as follow up. > Here's what I mean. Indeed, in the previous patch I just meant you could change the line you were touching (and indeed quoted the wrong hunk), but this more far-reaching cleanup is great too. I wouldn't put this one in the 8.2 branch though, since it doesn't actually fix anything. Simon