From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87819 invoked by alias); 15 Sep 2016 15:16:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87791 invoked by uid 89); 15 Sep 2016 15:16:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Sep 2016 15:16:04 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84B06A0C46; Thu, 15 Sep 2016 15:16:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8FFG2tP007472; Thu, 15 Sep 2016 11:16:02 -0400 Subject: Re: [RFA 2/2] Make some test names invariant To: Tom Tromey , gdb-patches@sourceware.org References: <1473893962-12420-1-git-send-email-tom@tromey.com> <1473893962-12420-2-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: Date: Thu, 15 Sep 2016 15:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473893962-12420-2-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00158.txt.bz2 On 09/14/2016 11:59 PM, Tom Tromey wrote: > While working on the previous patch, I noticed that the test names in > process-dies-while-detaching include the PID of some test process, > making it so that the test names change between runs. This patch > fixes the problem. LGTM. However, FYI, with the current "definition" of test names, it doesn't actually change, because tools should be ignoring the trailing " (...)" bit. See: https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages We've always had to consider this, given "$test (timeout)", etc. Note that the wiki doesn't say it, and I don't think we've ever discussed it, but but the space before the open parens should matter when deciding whether to ignore the trailing bit. If there's no space, it shouldn't be ignored. This in order to make it possible to write tests that call functions without coming up with odd contortions, like, e.g., "print foo(1)". Thanks, Pedro Alves