public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH] gdb/testsuite: Fix rtld-step-nodebugsym.exp
Date: Thu, 10 Nov 2022 09:37:14 +0000	[thread overview]
Message-ID: <c0becc53-ab6b-ed78-9b96-9b4cff12d67e@amd.com> (raw)
In-Reply-To: <a68429ff-09e3-372f-bacf-b4d4b541ae24@simark.ca>


> 
> In theory, the gdb_test for step expects to see a (gdb) prompt at the
> end, and I suppose that GDB would crash before printing that prompt.  So
> the test would catch the problem even without that "print 0".  But I
> don't mind the extra safety:

Hi,

Thanks for spotting the issue and for the review.

If GDB crashes, we always have an unresolved test case reported in the 
testsuite summary.  However, with this extra "p 0", the output during 
the test run is slightly more verbose as runtest complains it cannot 
issue the command, which I find slightly easier to spot.

I'll push this fix shortly.

Best,
Lancelot

      reply	other threads:[~2022-11-10  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 23:29 Lancelot SIX
2022-11-10  2:01 ` Simon Marchi
2022-11-10  9:37   ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0becc53-ab6b-ed78-9b96-9b4cff12d67e@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).