From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2082.outbound.protection.outlook.com [40.107.244.82]) by sourceware.org (Postfix) with ESMTPS id 550873858D28 for ; Thu, 10 Nov 2022 09:37:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 550873858D28 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5Z4GZ35gKQmCZgjsQIKAC/o6BryjMVxh2LLzWpn4YWlYNEcXQ07g4VDFNpGzqyZNxxRO28NCChiKJEWmVA79H+qucw0uWoaFAeK7hXgBrv9Cz+64L7Tau8+w0+DYpeG6r0rhdT9hBsmGNbb7E3kivikIHbnYcGwv9D7puphO9NB9KAGZIZvzmLVHNGcLNazAazs4H5lGy+Q9//RXE9h+Btjq/W5ho9P9aeICQby2ywrpc5DtR9NdjoB51c+WynSik0I2m+JHgwc7v/zABUR0SqEyT9gZyOtzbXXF/W7SW0ULMW/dSxP53+R3b2Y7sr7isfGEFDnMM+DS2P+7+Nf9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YJtKB4pogjmO5BILYxdddJbnPz3RxVAMQYGT+FhLEnA=; b=KgcFjyIBdF+eorBk/MDXPpNCYUMTY4/1KKZMJUSgnVUL12xReCpD3SAPrPBl6QglwvumtKsGXGD1XMrv3lgAFwFmqEghVFmR4YEgQuPBpWa0WUvBLu+KP7xF1uNVXeCLM+YtfS/aklvehc1hb497SKxwJQgCdnrOZtipq3YS1B8DBULRGmC+v+/gsuqWg8rFwxGWNnahk6MVXVfmO8uEy+5nKSIMVhf6fI0AN6EpOVmtdBlnrp7evdbdepzvFAfq1ktHprTrwCqqWpfMN8Fd537klXsznmwHrWivMSDgJ/8ueGaIbqGkj9UpHM6fJdyHI6jVFoH43iBd5Kd0azRCTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJtKB4pogjmO5BILYxdddJbnPz3RxVAMQYGT+FhLEnA=; b=uWkXS6ZCJPiTK12C/pUhfb9sN8vUA7/tP+q91/aqj7EFGdndiYgDeKOCApiW8IwcaOQg13/EWQyK5q0s7z5ETtfExbfk+WwKyMlbwG96TN1XuI131c05+3/MlJ5Xt19DXHSXzdEhXd/LktOBnv/doqVu63PnELhZrd4hSLQZprI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by CH3PR12MB7620.namprd12.prod.outlook.com (2603:10b6:610:150::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Thu, 10 Nov 2022 09:37:19 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::15e7:2ef7:ccc0:7f52]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::15e7:2ef7:ccc0:7f52%6]) with mapi id 15.20.5791.024; Thu, 10 Nov 2022 09:37:19 +0000 Message-ID: Date: Thu, 10 Nov 2022 09:37:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] gdb/testsuite: Fix rtld-step-nodebugsym.exp To: Simon Marchi , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20221109232945.2016705-1-lancelot.six@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0261.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::14) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5745:EE_|CH3PR12MB7620:EE_ X-MS-Office365-Filtering-Correlation-Id: 8121572d-1be0-4c7e-7e7a-08dac2ff297a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: im9d9ZfVctMFZHZCfAcoLYyqCH0dJZgQ52/Qrho1vfie45JnZjLdbHjbFiRB39ojZto74b3NppKnwu1vl0Slg7bEGKDbFiGpw/BucIKSvLLT+B5na7Jm/EPyfCErLZrkwBdkhAm3AcDV1YH/4tSlWEZR7GVmbwVF/duw/ONkpUuraJxmZsoUXy/77kKoHHkcXwinF+nielg/4yL8xWaD6suOBFjeassj3Aj4KTz+n2BXBLhQzJS3rf84Vo95rhrc+//QVTqLvrcWVrxFpFLbMSVMKQ0A6Jl/5Ps2uupLuh0V55Yogb0YCYezvgRLfd3iT154h/JQDCN/jm1d2qtBUGNCBsyt3aqidesqZyzEpQFcj935ou6HRBKUeiTJ6+LsMY00fH2+VKTwIyKGWOGo3d47JtxzPAMjBylMCG459jeRDO7N05/CJ1vcgtonkRBbU2A2k94a5q9aA81l96gdoWg3vYjv3biPFBGXDr9/zHzyIIyX/e1LUU83yZ8cK8IFgcV/C1DooNHV4LD0hoIJhNxYbifRjVuH8PPzlzBkqgjoqxhSYc9Wo2s78bg1oY6t91wBFNLly2Q1kMd36Tkzq9ww4/RPAK1M8PIXARHmBaph43oK/ai2VhN1Y0mH/HXfWqcX0eQFzHuDjzNg3ldbwkomRtylHRaXVc/h540H7QN8qMNHkPM7FKIaq2u6MsS2M4BDPY++3C5lLsEE2+vE8cWyjVAWRicVMfoBtg2aLebn8rX0/5ykxtUFCBK0s+Z7F/2vosjIxLP/pMyqE5RypCTymu5Z0a4nI1LimmEio98= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5745.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(38100700002)(31686004)(316002)(478600001)(6512007)(6486002)(6666004)(2906002)(36756003)(41300700001)(2616005)(66556008)(66946007)(66476007)(8676002)(4744005)(186003)(5660300002)(4326008)(8936002)(31696002)(6506007)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjhIYzRQc0ZhWEl3aW5RdnVaRi9FVVUyRThSeGU1ZHJ5WmF5RU9xY2lJTGhl?= =?utf-8?B?blowN3JrdTQrVUQ0NEdWbFU1ZWthWHk5enNvOXVtdW9KOXkvd3QrWVhZOXdJ?= =?utf-8?B?bVJLbUJUSit3ak8vb1pPbDZQWWNzZDdma1d4VDQzblk5N29RM1BpMnZKQnVB?= =?utf-8?B?QUhsdnRCaGFKakI3VWhldVJadlFZOEdwWTZjaDBFRnBpMExnMVRCbE5DUThK?= =?utf-8?B?clNhK1k1eWJsck0zV25ZVjFxL2lwbFhSL0xaQUVjWlVLTmxVcXlBSzExYzIy?= =?utf-8?B?NXU2emtKS0tQejdYdlJpZzlKb0xVWTI2UGY3ZjFZM291Q1hBa1hjWmZIdUpV?= =?utf-8?B?NUdKcTJQVkJZclY5MjA0ZVk3TnFTY3JQajYzVHlua0xwQVlNVjhjQWpzMVNq?= =?utf-8?B?RXlPN1FBZ1RvbDVuQ0V4WjBtMW43VitoaVlTNTZvMEVUZlpVMjlkbDVLMUhQ?= =?utf-8?B?eGNxbm1iRHBiY083NkFzcFRJK0M2NEdoQjF1ZnQ3bDJibWhtdE1pSk45dGVZ?= =?utf-8?B?cEpidENvajA5OW9sV0VuODdVR3hVTkwvcTkrdkxQaTlxN3hYR0QvSU90N29l?= =?utf-8?B?RGFXekJKdnVQcXc1ZnZwRjJ2UUxRRFNBZkdhbGllbXlwSWpTTHNLaVg1L1Aw?= =?utf-8?B?S0owc2RPRFFVMHBmbTNtZGJtS2tTSEM1cExjRnJCbzFXc0tIUXpySTdMMkR6?= =?utf-8?B?TEU3Yjh2WEhnS2xJYUlpMlJkS1kza2hHdTB5bDczWVo4d0ptMnk3eUhSVmNq?= =?utf-8?B?dEZWMm43QThRUUViVjFCQzlzenZRaUhlcXNCUVN2WVdFM2ZtdFhPYmROSDNn?= =?utf-8?B?Qk9va2N2T2gwcVZ1WDRSN1ZQYXM5Ui9NbVBPdHdRZW80VHpJYnk1L1JDRjdR?= =?utf-8?B?cUg2S2lTandzbFNEaVFMRjQzNGo0Mnp2K0FtdWtvd3ErWVc5UzYxTUF4cTNP?= =?utf-8?B?bitmWlB3bUtXVEJLZmtpdUVMOHU0M2R0Z2RRT1FESVFFOG5qUCtDY1ZFZWpz?= =?utf-8?B?WWRvMGZUNHZncUNVU1pzZTlyUTVmeVZnSTh1Wk9yYjUvRGpQblBBaHZzR0th?= =?utf-8?B?RitXMUxjWHhDQkRKOFdQZzQ5NXZsUXY1NUVJdWVnUG9DWHBmd0RYaWNMNmgv?= =?utf-8?B?UmcxbHRzcUtMS2xiQ09ZSFQ1TW1oUStiUGlHREpNbytYaUhMWlBIbE5FdXR1?= =?utf-8?B?ZTVjWFZBV1NpR1Uvclp6RW8yclRjVk9qZnk1aEhQK3VsMUVYYUFuOUYvbU56?= =?utf-8?B?Q1RGdStydE0vS0JVVGwxa2FHdGdueEtHTTJwQWszdDJ4Um1NT0RyNVdybjYz?= =?utf-8?B?cVpPaHhOQXEzVUJpSnZiR2M5ZFR1d0VFZG5XOVc4cENqYzZ6MXpRMGV6YTA3?= =?utf-8?B?SDJXaVd0STdtZnd0Q1VCRkZKd2tFM0l2aHdmam9lWGY4U0cxSS9QN09lME80?= =?utf-8?B?MHg0K242dzNyZVdwcTVrSUpVUlk5NE9NUDFibHRMSkVHd1VTVjVpRW1PaG1Q?= =?utf-8?B?M0RNcWZXeUNFVmpkdzNsaWtyVXNPR1JNYjM5ZXFraGg0azV5VmsyTkVQMkRk?= =?utf-8?B?Q3RJTmIxT3pzZzdrOU9GK3lRenZPd3M3RFhxWUNLYjZMcEx4WEZnaURXMHVF?= =?utf-8?B?M2F6SGJhY2NseCtQUGwvcjEvRWdDZzd3aFZUekVqSG9qS0NEa0l4cFNTbEhK?= =?utf-8?B?d24xd1RYRTRnd2FzMEJlTXdJTDlqcEdJY3NNaTd3Ym81UDFKZzFncm5XR3F0?= =?utf-8?B?ZzJibTgya2N4NWhpLzRGYWtHYmRLbFAwcTJYNTlYUE12Yzk0bWw1Q2VoeFRL?= =?utf-8?B?U3pWSlVyOHVNY2ljSjllZ0habExZT3gveERQV21MdTBRTnErS3diK015UVk2?= =?utf-8?B?UFNJa2pJOFo5VmZRbkNVVkpOYUpqRHhRYUJhbkpsT3RaN2VHemsyUER0b3Fh?= =?utf-8?B?TmhuSVY2aGc5b2U5cmNoeVQvMWl3RWt3NUQrYUhaN2crNXoydk5tcjlTdjI5?= =?utf-8?B?Y05DWDdXREprYU03TUxNeCtodmNYc29PbDN1dWZvVjZRaDNJRkpobHROQ0RV?= =?utf-8?B?Y3NjLzI0SXFSY2RhZVdKelpvK3ptQXZwbHdkM3owelJnbUtYcHdHaW1FZnZs?= =?utf-8?B?SitndEViUHlUeWpwMFR2NzlBT0daK3RxSElOTDY1QlNTbW9MUFB1Y2gvU05H?= =?utf-8?Q?A/dOdWe+5qK+A+xdjB6+Saw=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8121572d-1be0-4c7e-7e7a-08dac2ff297a X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 09:37:19.7500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ceUbdolHREMYoblGRphsPXr+clY8zrRoYPTBq8cvCoeB4691h4jF5EPwBtL5jnA8FPOiTAUFtz9E8cwCFVy9Iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7620 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > In theory, the gdb_test for step expects to see a (gdb) prompt at the > end, and I suppose that GDB would crash before printing that prompt. So > the test would catch the problem even without that "print 0". But I > don't mind the extra safety: Hi, Thanks for spotting the issue and for the review. If GDB crashes, we always have an unresolved test case reported in the testsuite summary. However, with this extra "p 0", the output during the test run is slightly more verbose as runtest complains it cannot issue the command, which I find slightly easier to spot. I'll push this fix shortly. Best, Lancelot