public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Make exec-file-mismatch compare build IDs
Date: Mon, 18 May 2020 14:52:20 +0100	[thread overview]
Message-ID: <c0c80c12-7837-b05b-b090-0c3a7509b33c@redhat.com> (raw)
In-Reply-To: <834ksebeqz.fsf@gnu.org>

On 5/17/20 7:25 PM, Eli Zaretskii wrote:
>> From: Pedro Alves via Gdb-patches <gdb-patches@sourceware.org>
>>
>> +If the debugger can determine that the executable file running in the
>> +process it is attaching to does not match the current exec-file loaded
>> +by @value{GDBN}, the option @code{exec-file-mismatch} specifies how to
>> +handle the mismatch.  @value{GDBN} tries to compare the files by
>> +comparing their build IDs (@pxref{build ID}).  If build IDs are not
>> +present in either file, @value{GDBN} compares the file names.  The
>> +@code{exec-file-mismatch} option specifies how to handle a mismatch.
> 
> The last sentence is a repetition of what was already said a few
> sentences back.
> 
> The documentation parts are okay with this nit fixed.  Thanks.

Thanks, I've removed that sentence.

Thanks,
Pedro Alves


  reply	other threads:[~2020-05-18 13:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-17 18:04 [PATCH 0/3] " Pedro Alves
2020-05-17 18:04 ` [PATCH 1/3] Default gdb_bfd_open's fd parameter to -1 Pedro Alves
2020-05-17 18:04 ` [PATCH 2/3] Eliminate target_fileio_open_warn_if_slow Pedro Alves
2020-05-17 18:04 ` [PATCH 3/3] Make exec-file-mismatch compare build IDs Pedro Alves
2020-05-17 18:25   ` Eli Zaretskii
2020-05-18 13:52     ` Pedro Alves [this message]
2020-05-18 13:55   ` [PATCH v2 " Pedro Alves
2020-05-18 14:21     ` Philippe Waroquiers
2020-05-19 15:43       ` Pedro Alves
2020-05-19 16:04     ` Tom Tromey
2020-05-19 17:44       ` Pedro Alves
2020-05-21 13:32         ` Philippe Waroquiers
2020-05-21 14:02           ` Pedro Alves
2020-05-21 14:23             ` Philippe Waroquiers
2020-05-21 14:27               ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0c80c12-7837-b05b-b090-0c3a7509b33c@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).