From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id CDAAA383802D for ; Thu, 31 Mar 2022 11:39:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CDAAA383802D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id h4so33359701wrc.13 for ; Thu, 31 Mar 2022 04:39:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=STDVLhFEU8stV/ZUPeGZvkFXPVLpnFU9gPagwn72Vao=; b=sl8uPdbiI4/ys2Kx4h7AJUiX8i+slQKMlyv/HqIYMXRGH2XxRwhr0/L1xZwqrkm7HW graTJtECgAKQPNheKU1jw+Wo9sB5vbGGd7PQPxYtOm4HgC0eo/T72o/S3crIAxaQ2Xl8 QJJTEFv961DPqjZ0MH21AX54O1QzDkyLwJga60cf+PILf26AseRGTada6YZ2r7j2VEKX CK/v4OCvETVK2QrILQOgEdZj0Kf+8u69REpR7kvOX9SKjF1Q+15IE+oL4m3ccQRRtctR ZdBVx+1AIN/lRmts2lWQ8icdVBvBYjTflNI/HH0CM/C17eN06843QSiShaW3oVk0sJKA Ongg== X-Gm-Message-State: AOAM533ZaUtXzkRJZNY3EHaTT8Rszska/9vQcZFGrLK4aO6e45dDiHB5 d8az4a3XchsU7Wj6fcV3wxEih4CP+1Zj2A== X-Google-Smtp-Source: ABdhPJz1cfgNogKjaVnSG2JmG6IglCQzeSrka18EMyJxNrGQwqTd6NX+v6KzRi8Sc3yXv85Q3E1ypQ== X-Received: by 2002:a05:6000:1085:b0:205:ab9b:8cf5 with SMTP id y5-20020a056000108500b00205ab9b8cf5mr3865398wrw.196.1648726760676; Thu, 31 Mar 2022 04:39:20 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id j17-20020a05600c1c1100b0038e389ab62esm6298043wms.9.2022.03.31.04.39.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 04:39:19 -0700 (PDT) Message-ID: Date: Thu, 31 Mar 2022 12:39:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/3] gdbserver/linux: Access memory even if threads are running Content-Language: en-US To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20220330124319.2804582-1-pedro@palves.net> <20220330124319.2804582-3-pedro@palves.net> <20220330132033.y3w4iyuedj76rfxd@ubuntu> From: Pedro Alves In-Reply-To: <20220330132033.y3w4iyuedj76rfxd@ubuntu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 11:39:23 -0000 On 2022-03-30 14:22, Lancelot SIX wrote: >> +/* Helper for read_memory/write_memory using /proc/PID/mem. Because >> + we can use a single read/write call, this can be much more >> + efficient than banging away at PTRACE_PEEKTEXT. Also, unlike >> + PTRACE_PEEKTEXT/PTRACE_POKETEXT, this works with running threads. >> + One an only one of READBUF and WRITEBUF is non-null. If READBUF is >> + not null, then we're reading, otherwise we're writing. */ > > Hi, > > Seems to me that this property can be asserted. WDYT? > > Something like > > gdb_assert ((readbuf == nullptr) != (writebuf == nullptr)); > > should do. > Doesn't hurt. I've added that locally. Thanks.