From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 2A9193858D20 for ; Sun, 21 May 2023 16:48:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A9193858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 27E1721BAB; Sun, 21 May 2023 16:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684687711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wO3EY1/Tx7tT7WQNVCzz8B4A0iiUS5JMs24GLng06sE=; b=mpoEeVGGvCeU3ZmO20r2KrVAbUirbbSREnX8+3BtrtYFxsJ3ZUcEE+ABY8PlEUsaR2x9Yc HGeLEICzS6l0BcTkphUud2Nvz2CIqHo+upQLlRyb3ed2sCcwkVVzjyGotbZwj+ypl45eXQ rfqwVC7RqsPUO6LmWeIS25rxlrVf18Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684687711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wO3EY1/Tx7tT7WQNVCzz8B4A0iiUS5JMs24GLng06sE=; b=K7Dkqy8v6Q/RaddhuDS5E0Rm0lW4khBzJb2dIw9TK5kxXV+QJgAmP/mobW2olLnSRuTAq+ Ul5ne4qqxfJurJDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0CD5B1346B; Sun, 21 May 2023 16:48:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id w+v4AV9LamStbwAAMHmgww (envelope-from ); Sun, 21 May 2023 16:48:31 +0000 Message-ID: Date: Sun, 21 May 2023 18:48:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.tui/wrap-line.exp To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <20230518061046.17837-1-tdevries@suse.de> <87ilcm83tt.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87ilcm83tt.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/21/23 10:51, Andrew Burgess wrote: > Tom de Vries via Gdb-patches writes: > >> PR testsuite/30458 reports the following FAIL: >> ... >> PASS: gdb.tui/wrap-line.exp: width-auto-detected: cli: wrap >> ^CQuit >> (gdb) WARNING: timeout in accept_gdb_output >> Screen Dump (size 50 columns x 24 rows, cursor at column 6, row 3): >> 0 Quit >> 1 (gdb) 7890123456789012345678901234567890123456789 >> 2 W^CQuit >> 3 (gdb) >> ... >> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: prompt after wrap >> ... >> >> The problem is that the regexp doesn't account for the ^C: >> ... >> gdb_assert { [Term::wait_for "^WQuit"] } "prompt after wrap" >> ... >> >> Fix this by updating the regexp, and likewise in another place in the >> test-case where we use ^C. > > Do we know why we sometimes manage to see '^C'? I guess it's a timing > thing, but right now I'm at a loss for how we manage to see it. It > appears that we print the wrapping line, that ends with 'W', and then > wait for this to be displayed. > > At this point GDB should be in a stable state waiting in the > event-loop. > > When we send \003 this should trigger an event, which should trigger > async_request_quit, which should result in the 'Quit' exception being > thrown, caught, and printed. > > I think the '^C' must be getting printed from tui_redisplay_readline > maybe, but I can't see how that gets triggered with \003 in the input > buffer. > > I only ask because if we understand why '^C' is sometimes printed then > we might be able to decide if this should always be printed, or never be > printed, and change GDB accordingly... > Hi Andrew, yes, that's a good question. [ Note that it's a TUI test-case, but the FAIL we're observing is in the cli part, before activating TUI, so tui_redisplay_readline has nothing to do with the FAIL. ] I've added an assert in rl_echo_signal_char and managed to trigger it to generate a core file corresponding to the FAIL condition (more details in the PR). My guess at what happens is the following: - we send a W to gdb - readline handles this, and echoes it - after readline echoing it, expect notices this and we send a ^C to gdb - at this point readline is still in the code handling the W, and handles the ^C by echoing it. Usually, at this point we're already back in gdb and handle the ^C without echoing it. Thanks, - Tom > Thanks, > Andrew > >> >> Tested on x86_64-linux. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30458 >> --- >> gdb/testsuite/gdb.tui/wrap-line.exp | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/testsuite/gdb.tui/wrap-line.exp b/gdb/testsuite/gdb.tui/wrap-line.exp >> index 4587517504c..2bfe342e04d 100644 >> --- a/gdb/testsuite/gdb.tui/wrap-line.exp >> +++ b/gdb/testsuite/gdb.tui/wrap-line.exp >> @@ -25,6 +25,8 @@ set cols 50 >> set lines 24 >> set dims [list $lines $cols] >> >> +set re_control_c "(\\^C)?Quit" >> + >> # Fill line, assuming we start after the gdb prompt. >> proc fill_line { width } { >> set res "" >> @@ -47,7 +49,7 @@ proc fill_line { width } { >> proc test_wrap { wrap_width } { >> # Generate a prompt and parse it. >> send_gdb "\003" >> - gdb_assert { [Term::wait_for "(^|$::gdb_prompt )Quit"] } "start line" >> + gdb_assert { [Term::wait_for "(^|$::gdb_prompt )$::re_control_c"] } "start line" >> >> # Fill the line to just before wrapping. >> set str [fill_line $wrap_width] >> @@ -64,7 +66,7 @@ proc test_wrap { wrap_width } { >> >> # Generate a prompt and parse it. >> send_gdb "\003" >> - gdb_assert { [Term::wait_for "^WQuit"] } "prompt after wrap" >> + gdb_assert { [Term::wait_for "^W$::re_control_c"] } "prompt after wrap" >> } >> >> # Test wrapping in both CLI and TUI. >> >> base-commit: 0cc8cc5e6f82b8d3d8e3803c6f7f5e63f0c866ad >> -- >> 2.35.3 >