From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id E2E6038708E0 for ; Wed, 10 May 2023 16:36:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2E6038708E0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f42c865534so20889045e9.2 for ; Wed, 10 May 2023 09:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683736588; x=1686328588; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sMWDA4YS8L5I4mvqFxMmMwRLcAFaePC79/t9AfmFJAw=; b=PWnfbdMVEgHPa/SZMyqXa/Vl3G4V5a8JOdKmx4pRWZkY35em967kXapnkNsOL2TSoy FZ1vkEjeK4VCbL/MJIsS535bWI6c7tnCFivpGnCT+FEuRfQJKmnkY+pcww4apXsuh+gJ jKohBTP8OpBjyPfvTqUaeflYaBXerTl5J0KPvvegvxFnGqH/OAy/aW8znakFJgAVCOqc xmbYR1vSRdq9TbUFDwHt/KvfwIaGEAtQuk043OQ6w2C7rSMJGYJ0XTHRyuykCHXIjk7D a7YthETejrsL6V0IrJVrxgIPy++6+MTsLp9+NkG/aEYISD0q35CE701ZeJfDmACms5wU kl/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683736588; x=1686328588; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sMWDA4YS8L5I4mvqFxMmMwRLcAFaePC79/t9AfmFJAw=; b=fevdYkK3fEMRNzotlCciEaEOoaGfOQST+515z4iIz9H7vqO38kzDzntoZtJVItgis4 ndAFva++GWn+VIPcBkh82Y/vZPr3tqz/8jab7ReBPDa6WJ8GTAa3rnxdT7Bm36By7c81 90jugHEFNnUdAUDXEm8jNwoHeJefrll8iCWl7bok5QhKBqACYUTJ1JNgyw8SrKeX/BZ8 piZleH6qDQ+H553KdTZaUeI5bFsw5kyPvXHPIRZv6Gdec6vbml2TOtZur4I1ekToZ2MP QIM+kJla/Qza18eEfsJ85E/5e7eV+GaqpLb31sVR0VJMDJFbkSS60vLZiRRY3cg3wP7V JacA== X-Gm-Message-State: AC+VfDy5U32z1rtmXn5NzXKpKupSWFXOLgf7mGzv3M9+rPSV7BNS1J+R I/N7QarBs2ECLbioMxp3DbUR/g== X-Google-Smtp-Source: ACHHUZ6f/ruPpEooDXjaptV0S6vHBWF2UAVYi3oqdUAzTfLgtGZxsnrtl/9QVsidYtwHoUP9XHJAow== X-Received: by 2002:a7b:cb58:0:b0:3ee:b3bf:5f7c with SMTP id v24-20020a7bcb58000000b003eeb3bf5f7cmr12992882wmj.23.1683736588526; Wed, 10 May 2023 09:36:28 -0700 (PDT) Received: from ?IPV6:2a00:23c4:9603:7f01:4745:47cb:3cd5:4c6e? ([2a00:23c4:9603:7f01:4745:47cb:3cd5:4c6e]) by smtp.gmail.com with ESMTPSA id n17-20020a5d4211000000b002f9e04459desm17839315wrq.109.2023.05.10.09.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 09:36:28 -0700 (PDT) Message-ID: Date: Wed, 10 May 2023 17:36:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] gdb/mi: Fix printing of fortran strings in stack Content-Language: en-US To: Tom Tromey , Richard Bunt via Gdb-patches Cc: Josh Cottingham References: <20230510102031.2125810-1-richard.bunt@linaro.org> <87ttwk5jds.fsf@tromey.com> From: Richard Bunt In-Reply-To: <87ttwk5jds.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/05/2023 15:52, Tom Tromey wrote: >>>>>> "Richard" == Richard Bunt via Gdb-patches writes: > > Richard> 547ce8f00b4ef826bdc9bf9a74f119fe9768852e fixed an issue where dynamic > Richard> types were not being resolved correctly prior to printing a value. The > Richard> same issue was discovered when printing the value using MI-mode. Solved > Richard> by porting the fix to the MI mode code path. > Hi Tom, Thanks for pointing me in the direction of that patch set. > I wonder if this can be fixed more directly after > 2fc3b8a4cb8439fc53975c4e70336d76e3ddc531 and its predecessors. > (Not that there's anything wrong with this patch.) > > Tom Even better than that, it fixes the issue I was seeing. I mistakenly thought I was sufficiently in a corner that I'd not need to retest for the failure after rebasing. If it is OK, I'd like to propose the test case for upstream as I believe it covers a legitimate gap, even if there is no known bug here. Many thanks, Rich.