[ was: Re: [PATCH] [gdb/testsuite] Add -q to INTERNAL_GDBFLAGS ]

On 4/10/23 21:40, John Baldwin wrote:
> On 4/7/23 1:25 AM, Tom de Vries via Gdb-patches wrote:
>> On 4/7/23 09:25, Tom de Vries via Gdb-patches wrote:
>>>> Not having the license text makes it a little less obvious in the log
>>>> when gdb has been restarted, so that might be a bit more confusing.
>>>
>>> Ack, true.
>>
>> And if you want something more verbose, we could always do some 
>> variant of:
>> ...
>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
>> index 7538071d1cf..4743150a878 100644
>> --- a/gdb/testsuite/lib/gdb.exp
>> +++ b/gdb/testsuite/lib/gdb.exp
>> @@ -2305,7 +2305,7 @@ proc default_gdb_start { } {
>>           }
>>           -re "^$gdb_prompt $" {
>>               # Output with -q.
>> -           verbose "GDB initialized."
>> +           verbose -log "GDB initialized."
>>           }
>>           -re "^\033\\\[.2004h$gdb_prompt $" {
>>               # Output with -q, and bracketed paste mode enabled, see 
>> above.
>> ...
>> to get:
>> ...
>> PASS: gdb.threads/attach-many-short-lived-threads.exp: successfully
>> compiled posix threads test case
>> builtin_spawn
>> /data/vries/gdb/leap-15-4/build/gdb/testsuite/../../gdb/gdb -nw -nx -q
>> -iex set height 0 -iex set width 0 -data-directory
>> /data/vries/gdb/leap-15-4/build/gdb/data-directory^M
>> (gdb) GDB initialized.
>> set height 0^M
>> (gdb) set width 0^M
> 
> I would prefer this type of approach for the "start of a session" sentinel.
> 

Hi John,

does this patch (currently testing) address your concern?

Thanks,
- Tom