From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 7E1343858D37 for ; Wed, 19 Apr 2023 14:04:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E1343858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B0B29219B2; Wed, 19 Apr 2023 14:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681913061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7JtmyQEpL7gBBVYK82383AYuJppZrorgELbhtWGfDYs=; b=rdoZwZLg6SX5Z6aLcXPIViJNtwtBcUkHLs4J8pQzDHWDXS7eqQlzKlEasMNbMrnd/Apjsb jwfc5zPbHl/J3OYK37GJ1Zux5yEnfKyJIvevn0GvuXHRtDwynbevsZsgx0cP1Xumbi/3Um iYaPDZZA+ZKuMuO6pCAGPh3BJ0cOXE0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681913061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7JtmyQEpL7gBBVYK82383AYuJppZrorgELbhtWGfDYs=; b=MiS3UFRyQMt0lxvr0BXbeeeBuL8bdkaAryGOBYJxTk0Ecm/tmMQ3TTIjtU5/QXx4eF93Wf /2NyNPI0q2sFjKAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 912A813580; Wed, 19 Apr 2023 14:04:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GT49IuX0P2QIVwAAMHmgww (envelope-from ); Wed, 19 Apr 2023 14:04:21 +0000 Content-Type: multipart/mixed; boundary="------------gpY3IVc0TFIbn40dirDBRqtS" Message-ID: Date: Wed, 19 Apr 2023 16:04:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH] [gdb/testsuite] Use verbose -log for "GDB initialized" Content-Language: en-US To: John Baldwin , Simon Marchi , gdb-patches@sourceware.org References: <20230405183410.13468-1-tdevries@suse.de> <8ca29409-2a43-c4a1-ebbe-02ae519b79e4@simark.ca> <62b4adb5-b810-c2a1-8c62-8f2347243971@suse.de> <6e123fa8-5619-361a-adae-ff115bdfa0e3@suse.de> From: Tom de Vries In-Reply-To: X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------gpY3IVc0TFIbn40dirDBRqtS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit [ was: Re: [PATCH] [gdb/testsuite] Add -q to INTERNAL_GDBFLAGS ] On 4/10/23 21:40, John Baldwin wrote: > On 4/7/23 1:25 AM, Tom de Vries via Gdb-patches wrote: >> On 4/7/23 09:25, Tom de Vries via Gdb-patches wrote: >>>> Not having the license text makes it a little less obvious in the log >>>> when gdb has been restarted, so that might be a bit more confusing. >>> >>> Ack, true. >> >> And if you want something more verbose, we could always do some >> variant of: >> ... >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index 7538071d1cf..4743150a878 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -2305,7 +2305,7 @@ proc default_gdb_start { } { >>           } >>           -re "^$gdb_prompt $" { >>               # Output with -q. >> -           verbose "GDB initialized." >> +           verbose -log "GDB initialized." >>           } >>           -re "^\033\\\[.2004h$gdb_prompt $" { >>               # Output with -q, and bracketed paste mode enabled, see >> above. >> ... >> to get: >> ... >> PASS: gdb.threads/attach-many-short-lived-threads.exp: successfully >> compiled posix threads test case >> builtin_spawn >> /data/vries/gdb/leap-15-4/build/gdb/testsuite/../../gdb/gdb -nw -nx -q >> -iex set height 0 -iex set width 0 -data-directory >> /data/vries/gdb/leap-15-4/build/gdb/data-directory^M >> (gdb) GDB initialized. >> set height 0^M >> (gdb) set width 0^M > > I would prefer this type of approach for the "start of a session" sentinel. > Hi John, does this patch (currently testing) address your concern? Thanks, - Tom --------------gpY3IVc0TFIbn40dirDBRqtS Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Use-verbose-log-for-GDB-initialized.patch" Content-Disposition: attachment; filename*0="0001-gdb-testsuite-Use-verbose-log-for-GDB-initialized.patch" Content-Transfer-Encoding: base64 RnJvbSA4YWQ0NDQ0MWViYjA3NGIwNTA3NzUyNGU5MTA0N2IxZTdjYTQwYmY1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFdlZCwgMTkgQXByIDIwMjMgMTU6NTA6MzIgKzAyMDAKU3ViamVjdDogW1BBVENI XSBbZ2RiL3Rlc3RzdWl0ZV0gVXNlIHZlcmJvc2UgLWxvZyBmb3IgIkdEQiBpbml0aWFsaXpl ZCIKClNpbmNlIGNvbW1pdCAzMWM1MDI4MDE3OSAoIltnZGIvdGVzdHN1aXRlXSBBZGQgLXEg dG8gSU5URVJOQUxfR0RCRkxBR1MiKSB3ZQpoYXZlIHRoZSBzb21ld2hhdCB0ZXJzZToKLi4u CmJ1aWx0aW5fc3Bhd24gZ2RiIC4uLiAtcSAuLi4KKGdkYikKLi4uCmluIGdkYi5sb2cuCgpN YWtlIHRoaXMgYSBiaXQgbW9yZSB2ZXJib3NlLCB0byBnZXQ6Ci4uLgpidWlsdGluX3NwYXdu IGdkYiAuLi4gLXEgLi4uCihnZGIpIEdEQiBpbml0aWFsaXplZC4KLi4uCgpUZXN0ZWQgb24g eDg2XzY0LWxpbnV4LgoKUmVwb3J0ZWQtQnk6IEpvaG4gQmFsZHdpbiA8amhiQEZyZWVCU0Qu b3JnPgotLS0KIGdkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAgICAgICAgIHwgOCArKysrLS0t LQogZ2RiL3Rlc3RzdWl0ZS9saWIvbWktc3VwcG9ydC5leHAgfCA0ICsrLS0KIDIgZmlsZXMg Y2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAgYi9nZGIvdGVzdHN1aXRlL2xpYi9nZGIuZXhw CmluZGV4IDllYTAzMzQ3NTlkLi42MzYwZTYyMDMxYSAxMDA2NDQKLS0tIGEvZ2RiL3Rlc3Rz dWl0ZS9saWIvZ2RiLmV4cAorKysgYi9nZGIvdGVzdHN1aXRlL2xpYi9nZGIuZXhwCkBAIC0y MjkyLDcgKzIyOTIsNyBAQCBwcm9jIGRlZmF1bHRfZ2RiX3N0YXJ0IHsgfSB7CiAgICAgIyBn ZXQgcmVhbGx5IHNsb3cuICBHaXZlIGdkYiBhdCBsZWFzdCAzIG1pbnV0ZXMgdG8gc3RhcnQg dXAuCiAgICAgZ2RiX2V4cGVjdCAzNjAgewogCS1yZSAiXFtcclxuXF0kZ2RiX3Byb21wdCAk IiB7Ci0JICAgIHZlcmJvc2UgIkdEQiBpbml0aWFsaXplZC4iCisJICAgIHZlcmJvc2UgLWxv ZyAiR0RCIGluaXRpYWxpemVkLiIKIAl9CiAJLXJlICJcW1xyXG5cXVwwMzNcXFxbLjIwMDRo JGdkYl9wcm9tcHQgJCIgewogCSAgICAjIFRoaXMgc3BlY2lhbCBjYXNlIGRldGVjdHMgd2hh dCBoYXBwZW5zIHdoZW4gR0RCIGlzCkBAIC0yMzAxLDE1ICsyMzAxLDE1IEBAIHByb2MgZGVm YXVsdF9nZGJfc3RhcnQgeyB9IHsKIAkgICAgIyBkZWZhdWx0X2dkYl9pbml0KSwgYnV0IGZv ciBhdCBsZWFzdCBvbmUgdGVzdCB3ZSB0dXJuCiAJICAgICMgYnJhY2tldGVkIHBhc3RlIG1v ZGUgYmFjayBvbiwgYW5kIHRoZW4gc3RhcnQgR0RCLiAgSW4KIAkgICAgIyB0aGF0IGNhc2Us IHRoaXMgY2FzZSBpcyBoaXQuCi0JICAgIHZlcmJvc2UgIkdEQiBpbml0aWFsaXplZC4iCisJ ICAgIHZlcmJvc2UgLWxvZyAiR0RCIGluaXRpYWxpemVkLiIKIAl9CiAJLXJlICJeJGdkYl9w cm9tcHQgJCIgewogCSAgICAjIE91dHB1dCB3aXRoIC1xLgotCSAgICB2ZXJib3NlICJHREIg aW5pdGlhbGl6ZWQuIgorCSAgICB2ZXJib3NlIC1sb2cgIkdEQiBpbml0aWFsaXplZC4iCiAJ fQogCS1yZSAiXlwwMzNcXFxbLjIwMDRoJGdkYl9wcm9tcHQgJCIgewogCSAgICAjIE91dHB1 dCB3aXRoIC1xLCBhbmQgYnJhY2tldGVkIHBhc3RlIG1vZGUgZW5hYmxlZCwgc2VlIGFib3Zl LgotCSAgICB2ZXJib3NlICJHREIgaW5pdGlhbGl6ZWQuIgorCSAgICB2ZXJib3NlIC1sb2cg IkdEQiBpbml0aWFsaXplZC4iCiAJfQogCS1yZSAiJGdkYl9wcm9tcHQgJCIJewogCSAgICBw ZXJyb3IgIkdEQiBuZXZlciBpbml0aWFsaXplZC4iCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1 aXRlL2xpYi9taS1zdXBwb3J0LmV4cCBiL2dkYi90ZXN0c3VpdGUvbGliL21pLXN1cHBvcnQu ZXhwCmluZGV4IDBkODMwZDhlNGFlLi40NTcwOTczY2NmNSAxMDA2NDQKLS0tIGEvZ2RiL3Rl c3RzdWl0ZS9saWIvbWktc3VwcG9ydC5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9saWIvbWkt c3VwcG9ydC5leHAKQEAgLTI2MywxMSArMjYzLDExIEBAIHByb2MgZGVmYXVsdF9taV9nZGJf c3RhcnQgeyB7IGZsYWdzIHt9IH0gfSB7CiAgICAgZ2RiX2V4cGVjdCB7CiAJLXJlICJ+XCJH TlUuKlxyXG5+XCIuKiRtaV9nZGJfcHJvbXB0JCIgewogCSAgICAjIFdlIGhhdmUgYSBuZXcg Zm9ybWF0IG1pIHN0YXJ0dXAgcHJvbXB0LgotCSAgICB2ZXJib3NlICJHREIgaW5pdGlhbGl6 ZWQuIgorCSAgICB2ZXJib3NlIC1sb2cgIkdEQiBpbml0aWFsaXplZC4iCiAJfQogCS1yZSAi Xig9XFteXHJcblxdKlxyXG4pKiRtaV9nZGJfcHJvbXB0JCIgewogCSAgICAjIE91dHB1dCB3 aXRoIC1xLgotCSAgICB2ZXJib3NlICJHREIgaW5pdGlhbGl6ZWQuIgorCSAgICB2ZXJib3Nl IC1sb2cgIkdEQiBpbml0aWFsaXplZC4iCiAJfQogCS1yZSAiLip1bnJlY29nbml6ZWQgb3B0 aW9uLipmb3IgYSBjb21wbGV0ZSBsaXN0IG9mIG9wdGlvbnMuIiB7CiAJICAgIHVudGVzdGVk ICJza2lwIG1pIHRlc3RzIChub3QgY29tcGlsZWQgd2l0aCBtaSBzdXBwb3J0KS4iCgpiYXNl LWNvbW1pdDogMjhhYjk0ZjUxZGNkZWUwNTZkOTZlNTdhZDA0YzI3YzIyY2Y4NTRlYQotLSAK Mi4zNS4zCgo= --------------gpY3IVc0TFIbn40dirDBRqtS--