From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2066.outbound.protection.outlook.com [40.107.237.66]) by sourceware.org (Postfix) with ESMTPS id 2E4723858D3C for ; Fri, 4 Feb 2022 15:32:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E4723858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QYwRoJXkr6ubSYD27YWyoDdX7CJe6w/Z3iztaEb+Kd7zvyvDnyV0w584NW7Xl7zH3lXGp/NVL8D55hrMmV/3XX+a47dnGqzNsCGl0tV6fK7wH5gDYPVglM2x69VwGMrJbkMV+83nCXZ5JIfJCk62QHs8oguBYIj9ao5clLeS9W/Hru2nN6NW0uPwIO8+tvLAmVYWk8wuoWRBajWUGdW1STFiqdq/eqXM0NkGgO0Pshjpyn1jCHGZl4rHg+RCxdc5adwM9lWieyZlGEH2id70GjiZBW95gSpZ8O4rwqMa2Ysa6oXcYnU2U8b7RlrdkQwCMqCVak7VIGEPeKdMJPU9nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8QmVEiz5l0VzvboZ8gfsnme7+xFQCrc9GgUE6zwhG1g=; b=ISGJ/cs5LpreUCzlstqHdY2BVdvVvOt3yt5MdcsTiJ4HnMhURxJV2L7GexLOatah6+7N3CEadfvKUFuzS9XF/CJK5ZuIUy+JrdZpqTB4ZXDsMvFof273r7weNfdUZ23Nq/Are7X5wmH68mhOiZznv3/R7G/V21Lx3+qNyoZXl+3IImKV360JSbxcElEYj2OeWLfmDsntcrff/Z/ud5zeG3XwWQpQYQDtQKOUC1/f+PWIFX/Ko59m0/TLsi2Ih6/u7ZfivetyxkE1BAR4SVJHlx4+jkelFgRrqMNjpjpHPqZaCIUoWIaf7SmdUAIcGh+NCF4gJRTN3tdrSJ1VajsWuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by PH0PR17MB5020.namprd17.prod.outlook.com (2603:10b6:510:ef::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb 2022 15:32:11 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::78f9:3a56:7d30:e2c9]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::78f9:3a56:7d30:e2c9%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022 15:32:11 +0000 Message-ID: Subject: Re: [PATCH] gdb: include address in names of objfiles created by jit reader API From: Jan Vrany To: Simon Marchi , "gdb-patches@sourceware.org" Date: Fri, 04 Feb 2022 15:32:05 +0000 In-Reply-To: <415ce744-4ad8-89ee-221e-76935ad8e9cf@polymtl.ca> References: <20220202120336.1918781-1-jan.vrany@labware.com> <91268ddc-e578-715b-54e6-f45f98fcfdb7@simark.ca> <815e2cde66266c2f9c301080f357140621022735.camel@labware.com> <21327fa2-02b8-fcd4-e8a3-02f9acd14d4d@polymtl.ca> <5a9608c4c242325f89c6d4e60e1e1d814d7e7afb.camel@labware.com> <415ce744-4ad8-89ee-221e-76935ad8e9cf@polymtl.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0332.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::32) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10501aad-8315-460b-b448-08d9e7f382db X-MS-TrafficTypeDiagnostic: PH0PR17MB5020:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JwE8VNdX4hMnhWF2eJ2G5lMiPjnIRjvJoHw0Ol24HVf2e/Q1N7YL4MWTYQ/1+oxV0wGVP7z8N9cSixvj1qDkkcQW8mvNz+s+HwnM3zBX4v/oXDJ3o3Yrb6EsES3XdllJC8ffW/3w5S3tjRbjiJh2MG1qWAFCPqFid5sTaRCj42xokKWJvxOoQJElTfZqyIkL2Agl+FjorE+5GzehewoqBscek5JooAsuJrKU1wtfpu3kJEFw+POUhHgIG8bkWlLNe/EE6cU/HSk497CamJe50OZYlc+TPV4TvrX3EhxqAq+YijJ2AjGjc9tjCxeqQPuCrvyUyZ+cWYsdk5Ci1+ycHe8Gj0PWs1lY7mJz4YhZifv59BqR/PswgCiqhCjlDrRtYJHpv2uBFqwbfzeJkYREl4px08NhObdGVwxNRTdSPzZen3hEpC+pm7dpE6YcOHcpbuJD4cBLmAaRgJ6ak3UJ5IUGu/bkABB900R/9EDigd9tK5orjFM1NUHE1YrPgcXLLiV0LkP+iZeXqarmiHL3LtcxR3CdXXnolUUXKReql7ElBDuTv5AOWQvC5WJg+YEWWuK1KGcPqXM7G0TwgaziCdZYbQzurYVQBC55XTVBm6MHGE9JtOGSpXP1OyhMocgWKWKf4SSVcGztq27SepI3V3J1RrZIr7s/Dj3OL3+azqWWTKmEhJDlneNksg9/twXD1BABLaNNFCQ6918YhlTJng== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(26005)(66946007)(316002)(6506007)(66476007)(186003)(66556008)(2906002)(8676002)(2616005)(83380400001)(6666004)(52116002)(8936002)(6512007)(44832011)(5660300002)(110136005)(38350700002)(38100700002)(86362001)(508600001)(6486002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFA1aW03bzJoVzZRYytuRktlNGVkMEJON29ieGd5bW9GZEFhV2xyUFpYQk8z?= =?utf-8?B?QnMyakdxdHU4M3JaejJVZUNxQUwzbHlPWkJxTjNJNmlBbC9ESkZkYTVEaXFF?= =?utf-8?B?MkVoMG9oVGhLSWpkR3l2TDRkQXZuTEljcGtmYWlDZk9IWHVIVGpoNFhtbngz?= =?utf-8?B?ZGxMeE4vZnFJemhhakwzTlBESmc4Vjh0THFPTkZrWlVtb1kwNitvUlBic0ZI?= =?utf-8?B?NVVBUDlmMjlCdXA3YlpuQnZVWVhEb3BRRHRNZXBKMU9tTGtnb0w4WDkyeXlE?= =?utf-8?B?VU11c2ZxbytoSm45MWlRTndFWk9xTlp1LzhxVnZTekVYQjhaWG82cGJlNFU0?= =?utf-8?B?NUo5QkovNzBVaEY3ekp5RUE1SmlUU1ZxdjZkVGFGVGQvMk9laDk5NExxNFI4?= =?utf-8?B?eU5PWERzNTVzeEdyS0hMR1RZOUlKVDRUMUNOS1NkS2xVWHg2TThHaTZVK3pF?= =?utf-8?B?dHBVS3pwWnU1dW9EbXpIWmwrbUFOV2VJcU9KcGVJamhzYnoxWlF2anBIb0NI?= =?utf-8?B?b2xiSGlzUmJ5WXZhVXZ2eU04VHlkTVlHaXFTZlp4V1BlSVZ2R2x6cnR4NDFn?= =?utf-8?B?Z2ZKU3puV1p5dC9rVWU0aWdTRHdMZHRYQm9xVStOcjBQMVcvdUxxdVNuKzVV?= =?utf-8?B?aW5ReWxlL3BndWdxK3huNTgwNHNxdWhvdGw2NzF5aHRzVVRva1B1SHZ5UTFP?= =?utf-8?B?YjE2QUluc1NDaTRZczIxQ1dkdjBlZWJZeDUwYWxjOThWUVdwYWVkOXRzNzBG?= =?utf-8?B?bFllajBMNUVuVk9xYlM4OG85N2VTdll5Sm9ZUURvSUQwV3NvWjg1MW5aZEJX?= =?utf-8?B?bit6enZzVzBxL0MyL0Uzd3NsVTdBTHpxOUZjYllCaEY0LzZWblVQZktBMm9N?= =?utf-8?B?bFBENTJtTmhWdXcxWEIvRnA3RjFHOFV2c3ozWTgzRkNiNlFQNHVicHc4ZURE?= =?utf-8?B?T3NORFN5Nmx2TnUxN1prci9JT1dvK1JsVmJpME5QcFZLcEFPTzJmS3QxSmNR?= =?utf-8?B?NWVHd3JRbU1YK3JGaEtveEM2VVR4aEwvZGN0bGtzVi83TWFqL2ptbEdCd3Jo?= =?utf-8?B?WU1LTm9uRExHTzh3d21hb2ZZSjM1Q04yV0NEalloSTFWNHFsaWlQYUE0cnlI?= =?utf-8?B?RWZCU1lmQVhORkdZYlowc3R4Q096RWpMZTg1U2YyekMyUWZqYmo0R0lNSC9m?= =?utf-8?B?M1N1Ry8vN0N1cFlqREIvTUQ0Slpkc1BTSmpoWVJ0cytuNXRtb094SXZYclpo?= =?utf-8?B?MnBKbVF4WkNPT09DQUgwMjRYbDFBMmtVTXVETEJMeWVVaDB0TEhFUHJVRjFJ?= =?utf-8?B?eTRoUnpVcHJZVjJCODczSlVpOTU1Tkx5bXdGa0tTeS8wQWZsMmU2UHFERlh6?= =?utf-8?B?R1krZGt1MUYrV2kvbTI0R2JTVURLTk9lZ1RjN3F1aWlHNGlDS24wQVZ6dld6?= =?utf-8?B?QlBTU2F0Z1lTUlYrTUMrKzU4MDgyRDk5K1ZJRGdJNEZOUmI0NUNMRDdmUXNp?= =?utf-8?B?NHdISDREVmYzM3RPRE1VOEdHc0ZrNll0TGRlRlBWYXpMSEV2ajJBUnhpVExn?= =?utf-8?B?Ny9KaFIyczJKUURkZUwwSEFPRXdjRnNGNlRUcUdEVDUwZzh5OTFJNU5NRTRQ?= =?utf-8?B?eG04Z0xvOW5waVBOelM5ME53MG10SEFLcmRoeDVqNzl0d2gwQjdHMGFJT2I1?= =?utf-8?B?blorTklZWGhmQWJabUVJNFZXcmY2c0RmYkRGa05JYnlrQWhuaGZzTGFGNkNH?= =?utf-8?B?N3c5b0tjNnJrSnB4dWdaaXJuMDZ2cVFFdk5xYUVxb3g5eUFIb0IycXladlg4?= =?utf-8?B?OGFleTVmNEhmbkhJdzFIUnhtVHFickRVM1VKbzVEWnF0Vmhva0ZaWnM5SlNs?= =?utf-8?B?aUJoNDZ2bVVZaUJnNllmQkZudk1VakFBc0FuTDNhTlNUWklVeVh4dkFqSWox?= =?utf-8?B?aFlaSE5JMC9HMGlWY1N5Y2dsZngrT0FRY2J4UllTRzhTaGpiVzVHQTF6NDdj?= =?utf-8?B?UjYvcm5PMzhMdmtjU0FtUjBtYXp0b2xNbXBFdnZ3aVlEUWJuYXNxdmc1Slpj?= =?utf-8?B?YTV6SENmZE1YVUVvZ2tKRi9RVVhZZ0pFQlB2WVRseFlEQjJzN0p2OW9TR2pP?= =?utf-8?B?SDQzSW1yZURkU2pWZlpJK3J5K0hrMnhYR0xBY05VekxCY3RjWjNEOHRmQnZP?= =?utf-8?Q?cqwYuN7nvTKkWMVT0Agltb0=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10501aad-8315-460b-b448-08d9e7f382db X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 15:32:11.0328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RDr60YrWvOpQYvcck6bjllily1wlbjm9cqrHdKEuXnqDKScwWKyPTaTMcMV4QeLtvHvE3orbDjqMrk24x5lNSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR17MB5020 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 15:32:24 -0000 On Fri, 2022-02-04 at 09:52 -0500, Simon Marchi wrote: > > Hmm, I actually think it has to be unique in order to make things work. > > The JIT (inferior) is - generally - oblivious of whether or not it's being > > debugged. It does not know whether or not the "symfile" put into linked list > > of jit_code_entry has been read by GDB or not. Or it may even be read multiple > > times, such as when you jit-reader-load, jit-reader-unload and jit-reader-load > > again during debugging. So one cannot reuse same memory for multiple entries. > > Ah you're right. And in case GDB attaches to a process that already has > some JIT objects, it will read them all. > > > > I agree, it would make sense for "maintenance info jit" and the objfile > > > name to display the same addresses. Given the concern I shared above, > > > maybe the code entry address is better in the end? > > > > I think it's matter of choice, I fine with either. > > Symfile address is fine, given what you said above. Perfect! Will you push the patch or shall I submit a new version based on yours? Thanks! Jan