From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AD2E8382FC82 for ; Thu, 24 Nov 2022 16:48:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD2E8382FC82 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2AOGljgV029083 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Nov 2022 11:47:49 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2AOGljgV029083 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1669308470; bh=2TcsP3WlAKhfFvC1GiqK2TVz3Idk8m5FVVs4+Icqnhk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RVe9ynzPokr50a53C8+WNiodme6XJm6b09414UHucCqpO3QmJCaSCpYru2Zp1ZlfI aJyLzWhCkHsseG9VO14bXKWjlak57b4Cp8p1lqNG4K3bq2lXupuGtfyT+/o204jmsw xPY4MKyHt81b+Lxw/lK8qoWvhz6B1tvy+oCNT4/c= Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1307B1E112; Thu, 24 Nov 2022 11:47:44 -0500 (EST) Message-ID: Date: Thu, 24 Nov 2022 11:47:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/5] gdb: add inferior parameter to set_target_gdbarch, rename to set_inferior_gdbarch Content-Language: fr To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20221124160428.83804-1-simon.marchi@efficios.com> <20221124160428.83804-3-simon.marchi@efficios.com> <20221124164154.sp7zrcpdfkzodjy4@ubuntu.lan> From: Simon Marchi In-Reply-To: <20221124164154.sp7zrcpdfkzodjy4@ubuntu.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 24 Nov 2022 16:47:45 +0000 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/24/22 11:42, Lancelot SIX wrote: > On Thu, Nov 24, 2022 at 11:04:25AM -0500, Simon Marchi via Gdb-patches wrote: >> From: Simon Marchi >> >> Add an inferior parameter, so it doesn't depend on the current >> inferior. While at it, rename to set_inferior_gdbarch, I think that's a >> better name than "target". >> >> The sole observer of the architecture_changed observable, >> pyuw_on_new_gdbarch, doesn't seem to depend on the current inferior. >> Neither does registers_changed. > > Hi, > > I kind of feel that it would make sense to also change the type of the > architecture_changed observable so the observers receive the inferior * > and the gdbarch *. It will not be used at the moment, but makes it > clearer that this observable gets triggerd for a given inferior. > > WDYT? That's a good idea, I'll add a patch that does that to my next version. Simon