From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 79FF53983A57 for ; Fri, 15 May 2020 17:29:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 79FF53983A57 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4B0E5ACF3; Fri, 15 May 2020 17:29:20 +0000 (UTC) Subject: Re: [PATCH v4 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board To: Michael Weghorn , gdb-patches@sourceware.org Cc: Simon Marchi References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200513094758.523845-1-m.weghorn@posteo.de> <20200513094758.523845-8-m.weghorn@posteo.de> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: Date: Fri, 15 May 2020 19:29:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200513094758.523845-8-m.weghorn@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 17:29:28 -0000 On 13-05-2020 11:47, Michael Weghorn via Gdb-patches wrote: > From: Simon Marchi > > This patch makes it possible to run tests requiring passing arguments to > the inferior with the native-gdbserver board. The end goal is to write > a test that verifies passing arguments to the inferior works, and to > have that test exercise inferior arguments passed on the gdbserver > command line, when using the native-gdbserver target board (in addition > to the other boards). This is done in the next patch. > > With the native-gdbserver target board, gdbserver is started in > gdb_reload (implemented in config/gdbserver.exp), called in gdb_run_cmd. > gdb_run_cmd already supposedly accepts inferior arguments (although that > feature does not seem to be used anywhere), which it passes to the `run` > command, for non-stub target boards. I've changed gdb_run_cmd so that > it forwards these arguments to gdb_reload as well. gdb_reload passes > them to gdbserver_run, and they eventually make their way to the > gdbserver command line. > > gdb_run_cmd currently accepts `args` (the varargs of tcl), which means > it receives inferior arguments as a list. This won't work with > arguments with spaces, because they will end up being formatted with > curly braces like this: > > % set args [list hello "with spaces" world] > hello {with spaces} world > % puts "run $args" > run hello {with spaces} world > > I've changed it to accept a single string that is passed to `run` and > gdb_reload. I've done the same change in gdb_start_cmd and > gdb_starti_cmd, although these two are not used with native-gdbserver. > > I've changed all gdb_reload implementations in the tree to accept a new > inferior_args argument, although most of them don't do anything with it > (and don't need to). People maintaining target boards out of tree will > need to do the same. > The curly braces are what you get when you directly convert a list of strings into a string. If we do the conversion ourselves, we get the desired outcome: ... $ cat test.tcl #!/usr/bin/tclsh set args [list hello "with spaces" world] proc string_list_to_string_with_quotes { args } { set s "" foreach arg $args { set s "$s \"$arg\"" } return $s } set args_str [string_list_to_string_with_quotes {*}$args] puts "run $args_str" $ ./test.tcl run "hello" "with spaces" "world" ... And we can use the normal "args" rather than the inferior_args, as long as we take care to pass the args from one varargs function to another using '{*}$args'. Thanks, - Tom