From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"will_schmidt@vnet.ibm.com" <will_schmidt@vnet.ibm.com>,
"cel@us.ibm.com" <cel@us.ibm.com>
Subject: Re: [PATCH] PowerPC, correct the gdb ioctl values for TCGETS, TCSETS, TCSETSW and TCSETSF.
Date: Wed, 8 Jun 2022 16:59:23 +0000 [thread overview]
Message-ID: <c14ceb0d685b0c8c82ac9e5065b6d1038dce720f.camel@de.ibm.com> (raw)
In-Reply-To: <56ccf64ceaaf37ab6c29b3dbcdce621a7378b556.camel@us.ibm.com>
Carl Love <cel@us.ibm.com> wrote:
>@@ -1898,15 +1903,16 @@ ppc_init_linux_record_tdep (struct
>linux_record_tdep *record_tdep,
>
> /* These values are the second argument of system call "sys_ioctl".
> They are obtained from Linux Kernel source.
>- See arch/powerpc/include/uapi/asm/ioctls.h. */
>- record_tdep->ioctl_TCGETS = 0x403c7413;
>- record_tdep->ioctl_TCSETS = 0x803c7414;
>- record_tdep->ioctl_TCSETSW = 0x803c7415;
>- record_tdep->ioctl_TCSETSF = 0x803c7416;
> record_tdep->ioctl_TCGETA = 0x40147417;
> record_tdep->ioctl_TCSETA = 0x80147418;
> record_tdep->ioctl_TCSETAW = 0x80147419;
> record_tdep->ioctl_TCSETAF = 0x8014741c;
>+ See arch/powerpc/include/uapi/asm/ioctls.h. */
>+ record_tdep->ioctl_TCGETS = 0x40007413 | (SIZE_OF_STRUCT_TERMIOS <<
>16);
This doesn't look right - unless I'm missing something this patch now
effectively comments out the ioctl_TC[GS]ETA* assingments?
Bye,
Ulrich
next prev parent reply other threads:[~2022-06-08 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 16:37 Carl Love
2022-06-08 16:59 ` Ulrich Weigand [this message]
2022-06-08 17:26 ` Carl Love
2022-06-08 17:43 ` [PATCH ver 2] " Carl Love
2022-06-10 12:00 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14ceb0d685b0c8c82ac9e5065b6d1038dce720f.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).