From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by sourceware.org (Postfix) with ESMTPS id A0E333858D3C for ; Mon, 17 Oct 2022 18:54:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0E333858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f54.google.com with SMTP id i131-20020a1c3b89000000b003c6c154d528so6332822wma.4 for ; Mon, 17 Oct 2022 11:54:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tJUVnuacNWlTyv6m1+N8aQHHaFgxaccYp/zofB/4oKU=; b=tqLyzwkEQyDI8pHjAPxOcWoEHlLi2OMgvdxxeZOP2SOpDVIeYmbryA8RKY96a3K+NW x8pgddl1zImIrnvuzmBXPKj8Wi5MDuB8fjld6V5ORmRx5D5eD6CW7oGRU8si1N6oquqf wztd/KCdVBQrzFrVDDw0hhTmuVeYbBw1znCWMxrZoPrznLhJJKkxhDFBWfAf1hQJiuN4 81WtBAeElLWDu5rELMdi7E6jrHKU5gx1A9jQJCRpEebGdDx7jmB//ZvxsQtmxftwvGki vbl5hoJ8TVG5MU3x6lUiLm3LhE3I/7fkjNejM1A5cmCHlYsdjLy8fOvjVpATr1++GNbs F0Pg== X-Gm-Message-State: ACrzQf32So7gCpiyohA9HGvJ8BUojKeEQlYv7fDg2I+Y0iLT51P7srFe dOtQJE4e5R1oEL8ngm4yuAyO9EAb8w7mEQ== X-Google-Smtp-Source: AMsMyM5AwOWxQCWtHhIW27BksUH7qXqDzHiaG48nzGWEGh3K6J5VSfDEZJc+gzdN4oM/odouVCvzmw== X-Received: by 2002:a7b:c341:0:b0:3c4:552d:2ea7 with SMTP id l1-20020a7bc341000000b003c4552d2ea7mr8564732wmj.82.1666032897925; Mon, 17 Oct 2022 11:54:57 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id g16-20020a05600c311000b003c6f1732f65sm8061779wmo.38.2022.10.17.11.54.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 11:54:56 -0700 (PDT) Subject: Re: [PATCH v2 04/29] Step over clone syscall w/ breakpoint, TARGET_WAITKIND_THREAD_CLONED To: Simon Marchi , gdb-patches@sourceware.org References: <20220713222433.374898-1-pedro@palves.net> <20220713222433.374898-5-pedro@palves.net> From: Pedro Alves Message-ID: Date: Mon, 17 Oct 2022 19:54:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 18:55:01 -0000 Hi! On 2022-07-21 2:35 a.m., Simon Marchi wrote: >> + add_thread (linux_target, new_lp->ptid); >> + } >> + >> + /* We just created NEW_LP so it cannot yet contain STATUS. */ >> + gdb_assert (new_lp->status == 0); >> + >> + if (!pull_pid_from_list (&stopped_pids, child_ptid.lwp (), &new_lp->status)) >> + internal_error (__FILE__, __LINE__, _("no saved status for clone lwp")); > gdb_assert_not_reached maybe? > This is based on existing code, but IMO we should just fix internal_error. Here's a patch for that: https://inbox.sourceware.org/gdb-patches/20221017185019.3233941-1-pedro@palves.net/T/#u > Otherwise, IBWN to have a version of gdb_assert that lets us provide a > message.