Re: PING^3. Re: [RFAv5 0/3] Allow the user to define default args for commands and aliases

[Philippe Waroquiers <philippe.waroquiers@skynet.be>]

If there are some comments, I have long week-ends at home to handle them :).
Thanks
Philippe

On Sun, 2020-03-22 at 19:05 +0100, Philippe Waroquiers via Gdb-patches wrote:
> Ping^2?
> 
> Note that this series went under several review cycles since August last year.
> So I would assume it is now reasonably close to be ready to be pushed
> 
> thanks
> Philippe
> 
> 
> 
> On Sun, 2020-03-15 at 14:14 +0100, Philippe Waroquiers via Gdb-patches wrote:
> > Any additional comments ?
> > 
> > Thanks
> > 
> > Philippe
> > 
> > 
> > On Sat, 2020-03-07 at 14:14 +0100, Philippe Waroquiers wrote:
> > > Allow the user to define default args for commands and aliases.
> > > 
> > > This patch series implements, tests and documents the following commands:
> > > 
> > >   set default-args COMMAND [DEFAULT-ARGS...]
> > >   show default-args [COMMAND]
> > >   set enable-default-args [on|off]
> > >   show enable-default-args
> > > 
> > > 
> > > It also changes the alias command to be:
> > >   alias [-a] [--] ALIAS = COMMAND [DEFAULT-ARGS...]
> > > 
> > > 
> > > Using the above default-args commands and arguments, you can
> > > define default arguments for commands or define powerful aliases.
> > > 
> > > For example:
> > > 
> > >   alias bt_ALL = backtrace -entry-values both -frame-arg all -past-main -past-entry -full
> > > 
> > > defines the alias bt_ALL that will give as much information as possible
> > > in a backtrace.
> > > 
> > > Default args can usefully be combined with the 'with' command, such as:
> > > 
> > > Make "wLapPeu" an alias of 2 nested "with":
> > >   alias wLapPeu = with language pascal -- with print elements unlimited --
> > > 
> > > or have an alias pp10 to pretty print an expression with a maximum of
> > > 10 elements:
> > > 
> > >   alias pp10 = with print pretty -- with print elem 10 -- print
> > > 
> > > This patch series also adds a completer for 'alias'.
> > > 
> > > 
> > > This is the version 5 of the patch series.
> > > Compared the version 4, the changes are handling the comments of
> > > Christian and Eli:
> > >   * Declarations are moved close to their first use.
> > >   * strchr (text, '='); used instead of strstr.
> > >   * More consistent use of nullptr instead of NULL
> > >   * std::string default_args used instead of const char *default_args
> > >   * Updated/clarified NEWS and gdb.texinfo, as commented by Eli.
> > > 
> > > Previous versions handled various comments of Pedro and Tom.
> > > 
> > > For what concerns changing 'alias -a' to 'alias -abbreviation":
> > > This can for sure be done (and be backward compatible).  This can however
> > > be done as a separate patch (I still also need to do a similar change
> > > for the 'qcs' flags).
> > > 
> > > Note 1: a preliminary version of this idea (using a command called
> > > 'add-args') was discussed in
> > > https://sourceware.org/ml/gdb-patches/2019-06/msg00395.html
> > > where Tom suggested to make it more GDB like, using 'set' command.
> > > 
> > > Note 2: Following another comment of Tom, there is no '=' character
> > > to separate COMMAND from its default args.
> > > If ever this would be ambiguous in some cases, we could introduce
> > > an optional '=' character to separate COMMAND from its DEFAULT-ARGS.
> > > Similarly, the alias command has no separator between COMMAND
> > > and its DEFAULT-ARGS.
> > > 
> > > 
> > >