Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails

[Pedro Alves <pedro@palves.net>]

On 2021-06-15 6:14 a.m., Bernd Edlinger wrote:
> On 6/15/21 1:35 AM, Pedro Alves wrote:

>> One thing I dislike here (and also about scoped_ignore_sigttou), is that the
>> signal disposition is process-wide.  
>>
>> If we happen to have multiple threads that need to ignore the signal changing the
>> disposition like that, then they may race.
>>
>> We can fix that by making the ignoring be per-thread instead by using
>> sigprocmask + sigtimedwait.  
>>
>> We can also introduce a generic scoped_ignore_signal so that both scoped_ignore_sigttou
>> and scoped_ignore_pipe (and whatever other similar signal we may need to ignore) share
>> the same code.  
>>
>> I gave it a quick try.  See the 4 patches at the top of the
>> users/palves/scoped_ignore_signal branch.
>>
>> This was something that I've thought before about doing for SIGTTOU to be honest.
>> Seeing it being copied over to SIGPIPE was simply the trigger that made me
>> actually give it a try.  
>>
>> WDYT?
>>
> 
> +1

Alright, I posted it here, now with a unit test:

 https://sourceware.org/pipermail/gdb-patches/2021-June/179982.html

Thanks,
Pedro Alves