From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 346E63858D35 for ; Fri, 24 Mar 2023 14:49:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 346E63858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 64B4C21A3A; Fri, 24 Mar 2023 14:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679669367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1y1NqV1QwltBpbbHneKtpT8/DOb+oRQIzp60lfLU+O4=; b=PITsVqAKpggYdQkz1zl6JyITnXye8mcRk3jThSQRt9pnk6rsh782ofR4OfwVAkI7kkzt71 LBf9N6s53xXwTVf1UMYAq45iT4B36APoYFiJ8XINLEOVu9ClPWg5aNt2m19U95h7PC8bFv rNAdy71ZYcGMM5+peMD68ZJg1+Q1BA4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679669367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1y1NqV1QwltBpbbHneKtpT8/DOb+oRQIzp60lfLU+O4=; b=iYPcYUwyjNEOCbXlGf0aO98LRropiXHxYl9RvK5O7WDFV93wkQiSxXNX3IpYnh+Pd8VZKh mEnT/hoSebou1IDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E712138ED; Fri, 24 Mar 2023 14:49:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RRQrEXe4HWTbVwAAMHmgww (envelope-from ); Fri, 24 Mar 2023 14:49:27 +0000 Message-ID: Date: Fri, 24 Mar 2023 15:49:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.cp/m-static.exp regression on Ubuntu 20.04 Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230323134716.2853-1-tdevries@suse.de> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/24/23 15:17, Simon Marchi wrote: > On 3/23/23 09:47, Tom de Vries wrote: >> In commit 722c4596034 ("[gdb/testsuite] Fix gdb.cp/*.exp for remote host"), I >> needed to change ".*/" into "(.*/)?" in: >> ... >> gdb_test "info variable everywhere" \ >> "File .*/m-static\[.\]h.*const int gnu_obj_4::everywhere;" >> ... >> >> However, due to that fact that I got this output: >> ... >> (gdb) info variable everywhere^M >> All variables matching regular expression "everywhere":^M >> ^M >> File /data/vries/gdb/src/gdb/testsuite/gdb.cp/m-static.h:^M >> 8: const int gnu_obj_4::everywhere;^M >> ^M >> File /data/vries/gdb/src/gdb/testsuite/gdb.cp/m-static1.cc:^M >> 8: const int gnu_obj_4::everywhere;^M >> ... >> I decided to make the matching somewhat stricter, to make sure that the two >> matched lines were subsequent. >> >> The commit turned out to be more strict than intended, and caused a regression >> on Ubuntu 20.04, where the output was instead: >> ... >> (gdb) info variable everywhere^M >> All variables matching regular expression "everywhere":^M >> ^M >> File /data/vries/gdb/src/gdb/testsuite/gdb.cp/m-static.h:^M >> 8: const int gnu_obj_4::everywhere;^M >> ... >> >> At that point I realized I'm looking at a bug (filed as PR symtab/30265), >> which manifests on openSUSE Leap 15.4 for native and readnow, and on Ubuntu >> 20.04 for readnow, but not for native. >> >> Before my commit, the test-case passed whether the bug manifested or not. >> >> After my commit, the test-case only passed when the bug manifested. >> >> Fix the test-case regression by reverting to the situation before the commit: >> pass whether the bug manifests or not. We could add an xfail for the PR, but >> I'm expecting a fix soon, so that doesn't look worth the effort. >> >> Tested on x86_64-linux, both on openSUSE Leap 15.4 and Ubuntu 20.04, both with >> native and readnow. >> >> Reported-By: Simon Marchi > > For those wondering, this is already pushed :) Hi Simon, sorry, forgot to mention that here, thanks for the note. Thanks, - Tom