From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id C572D3858D32 for ; Fri, 10 Mar 2023 15:40:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C572D3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 00F2F1FD81; Fri, 10 Mar 2023 15:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678462816; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uDaRnlfCtAv1K/uNbe1O1kx1W7nXdmtDtRM053xhOW4=; b=C0CCqOV4KAO2A/TCIEzq91E/kbQVTvWYYh+8tJ3Ooj/Hr3ruuCiDyWyxWFgKubqQR968B4 9SqAUqp/pbBMzQkTlX/DEDhW2gZlCQw+nLKidpUng8jINC2qAkGmlFfkEpv0e9ETxcJjuI h04WtIszRPT2cBJ4asgZrYquqY6XBFE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678462816; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uDaRnlfCtAv1K/uNbe1O1kx1W7nXdmtDtRM053xhOW4=; b=qzcifL6dHPzc1QLmVehAzN7dBgUhn8zgm+PXC/HucLCVBcHiUSc7Gjb3oKnf0SDRDDAvWV eO1enbSkjcLzs4Dw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE9BD134F7; Fri, 10 Mar 2023 15:40:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Y8INNV9PC2QICwAAMHmgww (envelope-from ); Fri, 10 Mar 2023 15:40:15 +0000 Message-ID: Date: Fri, 10 Mar 2023 16:40:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PING][RFC][gdb/testsuite] Fix inferior pid in gdb.server/server-kill.exp From: Tom de Vries To: gdb-patches@sourceware.org Cc: Andrew Burgess References: <20221011140150.GA15277@delia.home> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/25/22 14:20, Tom de Vries wrote: > On 10/11/22 16:01, Tom de Vries wrote: >> Hi, >> >> Consider this patch in gdb.server/server-kill.exp: >> ... >>   proc kill_server {} { >>       global server_pid >> >> +    remote_exec target "pstree -a -p $server_pid" >>       remote_exec target "kill -9 $server_pid" >>   } >> ... >> >> We have for kill_pid_of=server, as expected, the gdbserver killed: >> ... >> Executing on target: pstree -a -p 6969    (timeout = 300) >> builtin_spawn -ignore SIGHUP pstree -a -p 6969^M >> gdbserver,6969^M >>    `-server-kill,6976^M >> Executing on target: kill -9 6969    (timeout = 300) >> builtin_spawn -ignore SIGHUP kill -9 6969^M >> ... >> >> But for kill_pid_of=inferior, we also have the gdbserver killed: >> ... >> Executing on target: pstree -a -p 6805    (timeout = 300) >> builtin_spawn -ignore SIGHUP pstree -a -p 6805^M >> gdbserver,6805^M >>    `-server-kill,6812^M >> Executing on target: kill -9 6805    (timeout = 300) >> builtin_spawn -ignore SIGHUP kill -9 6805^M >> ... >> >> The proc prepare contains the pid extraction code: >> ... >>      if { $::kill_pid_of == "inferior" } { >>          # Get the pid of GDBServer. >>          set test "p server_pid" >>          set server_pid 0 >>          gdb_test_multiple $test $test { >>              -re " = ($decimal)\r\n$gdb_prompt $" { >>                  set server_pid $expect_out(1,string) >>                  pass $test >>              } >>          } >>      } else { >>          set server_pid [exp_pid -i $::server_spawn_id] >>      } >> ... >> >> The bit for $::kill_pid_of == "inferior" looks like the correct code to >> extract the gdbserver pid (it prints the parent PID of the inferior). >> >> The bit for $::kill_pid_of == "server" does work for local target, but >> for >> remote target using say target board remote-gdbserver-on-localhost, we >> have: >> ... >> Executing on target: pstree -a -p 10354    (timeout = 300) >> builtin_spawn [open ...]^M >> ssh,10354 -l vries localhost/gdbserver --once localhost:2350 s >> XYZ0ZYX >> Executing on target: kill -9 10354    (timeout = 300) >> builtin_spawn [open ...]^M >> XYZ0ZYX >> ... >> In other words, we're not killing the gdbserver, but the ssh session (a >> problem which was already fixed once in commit f90183d7e31 ("Get >> GDBserver >> pid on remote target")). >> >> Fix this by: >> - using the $::kill_pid_of == "inferior" bit for the gdbserver pid, and >> - using the inferior command for the the inferior pid. >> >> This introduces the following 4 FAILs: >> ... >> FAIL: gdb.server/server-kill.exp: kill_pid_of=inferior: test_tstatus: >> tstatus >> FAIL: gdb.server/server-kill.exp: kill_pid_of=inferior: >> test_unwind_nosyms: bt >> FAIL: gdb.server/server-kill.exp: kill_pid_of=inferior: >> test_unwind_syms: bt >> FAIL: gdb.server/server-kill.exp: kill_pid_of=inferior: test_stepi: stepi >> ... >> >> The first in more detail: >> ... >> (gdb) status-packet on >> tstatus^M >> No trace has been run on the target.^M >> Collected 0 trace frames.^M >> Trace buffer has 5242880 bytes of 5242880 bytes free (0% full).^M >> Trace will stop if GDB disconnects.^M >> Not looking at any trace frame.^M >> (gdb) FAIL: gdb.server/server-kill.exp: kill_pid_of=inferior: >> test_tstatus: tstatus >> ... >> >> The test-case contains the comment: >> ... >>   # When KILL_PID_OF is set to 'inferior' then the pid we kill is that >>   # of the inferior running under gdbserver, when this process dies >>   # gdbserver itself will exit. >> ... >> but that doesn't seem to be happening. >> >> I've added a sleep 60 after the kill to rule out any timing issues, >> and indeed >> after 60 seconds the gdbserver is still running. >> >> I don't know gdbserver well enough to decide whether the test-case >> assumption >> is wrong and we need to fix the test-case, or there's a gdbserver problem >> which is known or for which we can file a PR. >> >> Tested on x86_64-linux. >> >> Any comments? >> > > Ping. > I've ended up fixing this problem by commit 079f190d4cf ("[gdb/testsuite] Fix gdb.server/server-kill.exp for remote target"), so this patch is now obsolete. Thanks, - Tom