From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by sourceware.org (Postfix) with ESMTPS id E05E93849ACE for ; Fri, 3 May 2024 16:14:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E05E93849ACE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E05E93849ACE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714752867; cv=none; b=F2MGp2scrxacJj2Xm1/zUs6yQJCqCYNYfNevfXd+Xqq7toz7wt09uRVk/P94QCyjpZ+YU2jic63Eby4RupSwc7oGoJNJXsysq4GTQCH/mX9+zxQmomA8oM+lZKLamuTHsFXLpTXxJIsPQ/kpvDDSAiwg8CH6PqL8Nav/6mjva/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714752867; c=relaxed/simple; bh=HaDP+5GA2MmWByEapeW/XNPwa1ECEWOU+4DZnib46cE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=s+NKZNTjZJL12yFMDSu/ydauaowBEJZw1vYzEqu8T7bCRO7tTewd0Z3Fg5nn8hf4FqBU5l+fiy3wzX4PDJRXqyBuRUgQ5SUZn8BRdvemIfG+tbeTWtd09WjNqi3SgT5OToSMxCUEc+LevfK7l/fB+lVjSxcj1uvl9ds6ON91KII= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2dd615b6c44so103941441fa.0 for ; Fri, 03 May 2024 09:14:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714752864; x=1715357664; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vqw+zsuvemygLv4TEexzHQggAb7S+/5h6U/GMI/pvZE=; b=KYpr3TPiw0kXJFAALede45piES/nsaVH2Ofn+Hm1Meee3ie3h+Zu7C2gZrhLajvfqg baJUsWtRiyvTXPBayd2H1qX3Z750puXcWNG30agO4PvGxQ4Yxr64kNE/QD4PDyAj8KF8 VzDH+RZ2pGZnF8il/aI/5/CUX5lbmGc8BTtfzA2x0OgDrUcItvcdgGPXPHHaUs43sCSZ N3gIxCiCxS2C/8xNZ/JEMmbS0Q/gw+0elhBUm9VScYmqiSn1jFLfwQbu8kaCrY2J1/Lc Niw1mxiZ7hXY0mh8MCo6Y8ZZoV+BmeF/R4HBNvk5xWhnjXmsCtvcBePeZ9Tu/QTkL0tP EvzA== X-Gm-Message-State: AOJu0YyHv6D4XZRa3GxuO0BEqshwak7YqXrHlASXPmdED3PdBUf9VAYx GUk0gI0vtDR2ANTyTTyTZp1MVGxgzauUoVYy2dVncphSZXJpy10O X-Google-Smtp-Source: AGHT+IFEPZewUPJCXckYv/07PqxvO0BsUMOyrNbCJX0JEqDtJTYMhyGfrQGHOt45mMFVVlGrzYQ5zA== X-Received: by 2002:a05:651c:1541:b0:2d2:f5fa:f37e with SMTP id y1-20020a05651c154100b002d2f5faf37emr2203132ljp.51.1714752864395; Fri, 03 May 2024 09:14:24 -0700 (PDT) Received: from ?IPV6:2001:8a0:f93d:b900:7cde:c2ed:ba96:7cc7? ([2001:8a0:f93d:b900:7cde:c2ed:ba96:7cc7]) by smtp.gmail.com with ESMTPSA id s20-20020a05600c45d400b0041bde8ddce9sm9829289wmo.36.2024.05.03.09.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 May 2024 09:14:23 -0700 (PDT) Message-ID: Date: Fri, 3 May 2024 17:14:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbserver: add client_state destructor To: Tom Tromey , Guinevere Larsen Cc: gdb-patches@sourceware.org References: <20240503122906.3808986-1-blarsen@redhat.com> <87bk5ndntn.fsf@tromey.com> <04192a28-b4aa-4e07-878e-bde3f6472b20@redhat.com> <877cgaexgi.fsf@tromey.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <877cgaexgi.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-05-03 16:17, Tom Tromey wrote: >>> At some point we went through the tree and removed all these IIRC. > > Guinevere> I think I have a case of friday brains. You mean removed all nullptr > Guinevere> checks, or removed unnecessary xfrees? > > Sorry. All the checks of null before free were removed at some point. > > Though I see that gdb-xfree.h still does the check. Lol. > IIRC, the gnulib folks looked into this and concluded that no existing > system requires the check before a call to free. That is the original point of xfree existing. It was needed on some ancient Solaris, IIRC. It's free didn't work right with a null argument. Note that bfd uses xmalloc, but does not use xfree, so all such hosts are surely gone. Nowadays, having xfree is still important for the POD checking, of course, and it's nice to have xmalloc/xfree for balance IMHO, thought that's of course debatable.