From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 9C837395A018 for ; Wed, 17 Jun 2020 18:44:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9C837395A018 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 55D7C2C4E14; Wed, 17 Jun 2020 14:44:14 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rRWfN1soOMCq; Wed, 17 Jun 2020 14:44:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 0CC562C4D30; Wed, 17 Jun 2020 14:44:14 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 0CC562C4D30 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KXOIQ-XI0vpE; Wed, 17 Jun 2020 14:44:14 -0400 (EDT) Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id D2FA82C4A7F; Wed, 17 Jun 2020 14:44:13 -0400 (EDT) Subject: Re: [PATCH 2/3] gdb, gdbserver: remove ARM regdat files To: Alan Hayward Cc: gdb-patches , nd References: <20200617022736.1506-1-simon.marchi@efficios.com> <20200617022736.1506-2-simon.marchi@efficios.com> <5584E519-A186-4BB5-9DBF-31ABAF0B2D93@arm.com> From: Simon Marchi Message-ID: Date: Wed, 17 Jun 2020 14:44:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <5584E519-A186-4BB5-9DBF-31ABAF0B2D93@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 18:44:15 -0000 On 2020-06-17 4:06 a.m., Alan Hayward wrote: > > >> On 17 Jun 2020, at 03:27, Simon Marchi via Gdb-patches wrote: >> >> This patch removes the leftover regformats .dat files for the arm >> architecture. There are no longer relevant, since the arm architecture >> has been converted to use feature-based target-descriptions. These .dat >> files are used by GDBserver ports that still use static target >> descriptions. > > I should have removed these when I was removing the corresponding Arm .xml files. > Thanks for cleaning these up. They are easy to forget, I did forget them when removing the gdbserver ports recently... >> >> These .dat files are generated from corresponding .xml files in the >> features directory. And since the corresponding .xml files for these >> arm .dat files don't exist anymore, it is impossible to re-generated >> them. If you delete these .dat files and type "make" in the features >> directory, you'll get: >> >> make: *** No rule to make target '../regformats/arm/arm-with-iwmmxt.dat', needed by 'all'. Stop. >> >> So it removes the entries in the `WHICH` variable of >> gdb/features/Makefile. >> >> Finally, it removes the rule in gdbserver/Makefile to generate .cc files >> from `../gdb/regformats/arm/%.dat`. >> >> gdb/ChangeLog: >> >> * features/Makefile (WHICH): Remove arm files. >> * regformats/arm/arm-with-iwmmxt.dat: Remove. >> * regformats/arm/arm-with-neon.dat: Remove. >> * regformats/arm/arm-with-vfpv2.dat: Remove. >> * regformats/arm/arm-with-vfpv3.dat: Remove. >> >> gdbserver/ChangeLog: >> >> * Makefile.in (%-generated.cc: ../gdb/regformats/arm/%.dat): >> Remove. >> --- >> gdb/features/Makefile | 4 +- >> gdb/regformats/arm/arm-with-iwmmxt.dat | 53 --------------------- >> gdb/regformats/arm/arm-with-neon.dat | 64 -------------------------- >> gdb/regformats/arm/arm-with-vfpv2.dat | 48 ------------------- >> gdb/regformats/arm/arm-with-vfpv3.dat | 64 -------------------------- >> gdbserver/Makefile.in | 3 -- >> 6 files changed, 1 insertion(+), 235 deletions(-) >> delete mode 100644 gdb/regformats/arm/arm-with-iwmmxt.dat >> delete mode 100644 gdb/regformats/arm/arm-with-neon.dat >> delete mode 100644 gdb/regformats/arm/arm-with-vfpv2.dat >> delete mode 100644 gdb/regformats/arm/arm-with-vfpv3.dat >> > > Patch looks good to me. Thanks, I'll push it. Simon